From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com, ardb@kernel.org,
bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com,
dave.hansen@linux.intel.com, jslaby@suse.cz,
linux-arm-kernel@lists.infradead.org, mingo@redhat.com,
ndesaulniers@google.com, peterz@infradead.org,
tglx@linutronix.de, will@kernel.org
Subject: Re: [PATCH v3 5/5] tools: update x86 string routines
Date: Tue, 15 Feb 2022 21:59:52 -0800 [thread overview]
Message-ID: <20220216055952.ovrswb22lm53x5ns@treble> (raw)
In-Reply-To: <20220211151445.2027553-6-mark.rutland@arm.com>
On Fri, Feb 11, 2022 at 03:14:45PM +0000, Mark Rutland wrote:
> When building the perf tool the build system complains that the x86
> string routines are out-of-date:
>
> | Warning: Kernel ABI header at 'tools/arch/x86/lib/memcpy_64.S' differs from latest version at 'arch/x86/lib/memcpy_64.S'
> | diff -u tools/arch/x86/lib/memcpy_64.S arch/x86/lib/memcpy_64.S
> | Warning: Kernel ABI header at 'tools/arch/x86/lib/memset_64.S' differs from latest version at 'arch/x86/lib/memset_64.S'
> | diff -u tools/arch/x86/lib/memset_64.S arch/x86/lib/memset_64.S
>
> This is due to the way the asm-annotations for symbol aliasing were
> reworked, which should have no functional/performance impact.
>
> Import the latest versions, adding the new style SYM_FUNC_ALIAS(),
> SYM_FUNC_ALIAS_LOAD(), SYM_FUNC_ALIAS_WEAK() macros into the perf
> <linux/linkage.h> header. The old style SYM_FUNC_START_ALIAS() and
> SYM_FUNC_END_ALIAS() macros are removed.
>
> Other than removing the build-time warning, there should be no
> functional change as a result of this patch.
These changes should probably be squashed with their corresponding
original kernel changes to avoid breaking bisection for the warnings.
And it helps to keep the interdependent changes together.
--
Josh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-16 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 15:14 [PATCH v3 0/5] linkage: better symbol aliasing Mark Rutland
2022-02-11 15:14 ` [PATCH v3 1/5] linkage: add SYM_FUNC_ALIAS{,_LOCAL,_WEAK}() Mark Rutland
2022-02-11 15:14 ` [PATCH v3 2/5] arm64: clean up symbol aliasing Mark Rutland
2022-02-11 15:14 ` [PATCH v3 3/5] x86: " Mark Rutland
2022-02-11 15:14 ` [PATCH v3 4/5] linkage: remove SYM_FUNC_{START,END}_ALIAS() Mark Rutland
2022-02-11 15:14 ` [PATCH v3 5/5] tools: update x86 string routines Mark Rutland
2022-02-16 5:59 ` Josh Poimboeuf [this message]
2022-02-16 14:15 ` Mark Rutland
2022-02-16 6:00 ` [PATCH v3 0/5] linkage: better symbol aliasing Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216055952.ovrswb22lm53x5ns@treble \
--to=jpoimboe@redhat.com \
--cc=acme@redhat.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox