From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F6CAC433EF for ; Wed, 16 Feb 2022 06:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d/JtCA63e+a2YAirU/Q74cM59oJLeEDpkpTX3ftUX6w=; b=Kc9P6cRnTg8iLL 0bcvPqmjlZMqNScbCOBODSMnnAKexHCo+OxOmmKNyXlmJaZH2SV3/L90FZwuimuYyc+l3pu06BrIn QG9MuHHst2WGfFal8ZWKEL21e00Ajg2Hs+ObsbDGasUATmDPbJm8WCH+FTAWxxY25hYk63Q1OazZa ypJRydhsHUI3CiHldP8/WYk+xs1LJWrEQvOzeyVCz784M2nuLD17YoRw85bpU42Ua4ocg/LbIuvEN TN0NkaaLvHgOAsUd/w53Zqz19VZvJ5/TecY9Q7VOoABXr++fNHu2NX00cBPl/d4RQWCwk+4YtSM9Q GQ41G/AxOSong9jr0vRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKDMu-005czj-Vc; Wed, 16 Feb 2022 06:00:49 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKDMr-005cyS-Jl for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 06:00:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644991244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IVtJkDtiTB1hKGv+nXnAAOQ1ug5ffDsOB5NetPRTYrI=; b=OBUXTng6yCQiEr9eA3P+wwM3/INm97u5pLhTWF0BYxQtH/DK0b+myHECMSaQCTJ0Wm61yn hvC6GoKZBuweXqU/jM1U2AR2DNo/x7pef4PTjuDDgzaqdCcbjPjCjnw3f+IUdDy0fA/nPV 8m560xSQzvIwTrZQICZgF6zjjItQT/8= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-319-BpPDYEv2N-GwkmvnmJrkuQ-1; Wed, 16 Feb 2022 01:00:43 -0500 X-MC-Unique: BpPDYEv2N-GwkmvnmJrkuQ-1 Received: by mail-qk1-f197.google.com with SMTP id bj2-20020a05620a190200b005084968bb24so590810qkb.23 for ; Tue, 15 Feb 2022 22:00:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IVtJkDtiTB1hKGv+nXnAAOQ1ug5ffDsOB5NetPRTYrI=; b=LDrNT9FDdi3Q31r6qkMJUdaSnlR+Ubgl9yv+oVM6/b4YO6c9pGVtO/3bl2bKmjShRw xbP1ClSe6vapOWphssWHyyKG1NmAvV2xh+OPiabR7ISgBQIS5z6i5jAlAJ3SZuMpe9eR wFD0Ut7v4qMwr83N2sCAvq2M/DxQToEt5P6tNQUmP8LrJFpgRtO9uWdbkXFREaoQL9o3 gb7830dT0zND7ImZ7V35n1lhycsc8G/D/pWTtupurWi7X8i1FANSWQ5DLChJ1yxQVp2g MJB4y6HWJaUYF0IszkL16C73S+t3v28ligXfAmX2HKy8Qf8/EqyocUlSR9LN0aujoXH3 SoKQ== X-Gm-Message-State: AOAM533RHT83tFtRnheHhEEDyFaX/8otLoHM3ToCwWHE/8FjtdkzrU8m WiZ+Ha1Ky+R87MCVRlw1ONUog526acJiuZVEhJr+ZWBLurVs5UehHZyjyauOgEPrlTwms/2+5mI iAp8a71uhii5NNr6VE7jrG9FZoNYhT+Pr31o= X-Received: by 2002:a05:622a:44b:b0:2cf:4b06:5cfa with SMTP id o11-20020a05622a044b00b002cf4b065cfamr933675qtx.595.1644991242529; Tue, 15 Feb 2022 22:00:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJzP20QF+Q5eFtyMeIFg2UCeRyv1GHv40qRujvMy8pTnMtYrubrkmL/yeqzjO/CN2P5nYzN+uw== X-Received: by 2002:a05:622a:44b:b0:2cf:4b06:5cfa with SMTP id o11-20020a05622a044b00b002cf4b065cfamr933669qtx.595.1644991242291; Tue, 15 Feb 2022 22:00:42 -0800 (PST) Received: from treble ([2600:1700:6e32:6c00::e]) by smtp.gmail.com with ESMTPSA id j15sm17160411qkp.88.2022.02.15.22.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 22:00:41 -0800 (PST) Date: Tue, 15 Feb 2022 22:00:38 -0800 From: Josh Poimboeuf To: Mark Rutland Cc: linux-kernel@vger.kernel.org, acme@redhat.com, ardb@kernel.org, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, mingo@redhat.com, ndesaulniers@google.com, peterz@infradead.org, tglx@linutronix.de, will@kernel.org Subject: Re: [PATCH v3 0/5] linkage: better symbol aliasing Message-ID: <20220216060038.s2ymjrfghokzmwp4@treble> References: <20220211151445.2027553-1-mark.rutland@arm.com> MIME-Version: 1.0 In-Reply-To: <20220211151445.2027553-1-mark.rutland@arm.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jpoimboe@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_220045_730675_631870B2 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 11, 2022 at 03:14:40PM +0000, Mark Rutland wrote: > This series aims to make symbol aliasing simpler and more consistent. > The basic idea is to replace SYM_FUNC_START_ALIAS(alias) and > SYM_FUNC_END_ALIAS(alias) with a new SYM_FUNC_ALIAS(alias, name), so > that e.g. > > SYM_FUNC_START(func) > SYM_FUNC_START_ALIAS(alias1) > SYM_FUNC_START_ALIAS(alias2) > ... asm insns ... > SYM_FUNC_END(func) > SYM_FUNC_END_ALIAS(alias1) > SYM_FUNC_END_ALIAS(alias2) > EXPORT_SYMBOL(alias1) > EXPORT_SYMBOL(alias2) > > ... can become: > > SYM_FUNC_START(name) > ... asm insns ... > SYM_FUNC_END(name) > > SYM_FUNC_ALIAS(alias1, func) > EXPORT_SYMBOL(alias1) > > SYM_FUNC_ALIAS(alias2, func) > EXPORT_SYMBOL(alias2) > > This avoids repetition and hopefully make it easier to ensure > consistency (e.g. so each function has a single canonical name and > associated metadata). Nice! Other than the minor comment to squash the synced header changes, Acked-by: Josh Poimboeuf -- Josh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel