From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9FE8C433F5 for ; Thu, 17 Feb 2022 11:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bK1PnHM1rSSF+wRFCgcJyg5GixYaLBZfxgeghMSlvM4=; b=d5mebFaOjuWnJd n/5bVZuSNIKVV9/n6lBgyOko2wCpgZKYpl4kiRyCGg6AOIN0jTmdfzjw+buYNNzTDGFNf+tGrZ5JS gZRZn6SbO6UDoYLzkCS0hNIT6IpREhaJXwqJ6Bl8fqiD0JT5a3lwR5twtOv8Ib1AlRh5UMnPpcPvm Hk9jLgjv4/18rLYaPXo6vEHSZ/K6yymnUJEhueuMJES1IVkcEX6H1xSO19nF2koZZrNrXtU3+DvCi ZZIBLNQS6m4SXsYScF2tLcQ8OSSLg3mgh22b9Bo8ct4G5pTpJIzwtzmmKjElIbzPwgtKf2BDrCV06 lKCES3x9l0u2q5Szn0HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKf0U-00A5AX-DT; Thu, 17 Feb 2022 11:31:30 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKf0Q-00A59m-Hg for linux-arm-kernel@lists.infradead.org; Thu, 17 Feb 2022 11:31:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XSxGqHqB4CD4ItwJiT094IbgEYiep/ZGxuAGK8hdbFM=; b=YeqARtQqVs/62u66byIearze8r IE4wuo5lqu2F8ITDkDR5OCNYH1cs8gMHNndNEPY2TfwZkLCO2zhKSl/sAr4oNL1q8eDVZf/TDaxeP k9ZllKSSEZRWRJY3+ukIdU5ynnBZl4oifiNPFAi3PmkX4RtRmRIlhewWGCzV98Kw9KY8=; Received: from p200300ccff1474001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff14:7400:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1nKf0D-0006cT-8F; Thu, 17 Feb 2022 12:31:13 +0100 Date: Thu, 17 Feb 2022 12:31:12 +0100 From: Andreas Kemnade To: Krzysztof Kozlowski Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alistair@alistair23.me, samuel@sholland.org, josua.mayer@jm0.eu, letux-kernel@openphoenux.org Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Message-ID: <20220217123112.3ba70000@aktux> In-Reply-To: <36445c86-036e-0942-a9a4-919595886c67@canonical.com> References: <20220206080016.796556-1-andreas@kemnade.info> <20220206080016.796556-2-andreas@kemnade.info> <36445c86-036e-0942-a9a4-919595886c67@canonical.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_033126_769478_F76B0B23 X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Feb 2022 10:21:15 +0100 Krzysztof Kozlowski wrote: > On 06/02/2022 09:00, Andreas Kemnade wrote: > > Add a binding for the Electrophoretic Display Controller found at least > > in the i.MX6. > > The timing subnode is directly here to avoid having display parameters > > spread all over the plate. > > > > Supplies are organized the same way as in the fbdev driver in the > > NXP/Freescale kernel forks. The regulators used for that purpose, > > like the TPS65185, the SY7636A and MAX17135 have typically a single bit to > > start a bunch of regulators of higher or negative voltage with a > > well-defined timing. VCOM can be handled separately, but can also be > > incorporated into that single bit. > > > > Signed-off-by: Andreas Kemnade > > --- > > .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++ > > 1 file changed, 159 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > [..] > > + > > + DISPLAY-supply: > > + description: > > + A couple of +/- voltages automatically powered on in a defintive order > > Typo, definitive? > yes, of course. > > + > > + VCOM-supply: > > + description: compensation voltage > > + > > + V3P3-supply: > > All of supplies names - lowercase. > > > + description: V3P3 supply > > + > > + epd-thermal-zone: > > + description: > > + Zone to get temperature of the EPD from, practically ambient temperature. > > Is it a phandle? > a string used in of_property_read_string(priv->drm.dev->of_node, "epd-thermal-zone", &thermal); if (thermal) { priv->thermal = thermal_zone_get_zone_by_name(thermal); if (IS_ERR(priv->thermal)) return dev_err_probe(priv->drm.dev, PTR_ERR(priv->thermal), "unable to get thermal"); } [...] > > +examples: > > + - | > > + #include > > + #include > > + > > + epdc: epdc@20f4000 { > > Generic node name, e.g. display-controller > hmm, does IHMO not make too much sense here. E.g. in the imx6sll.dtsi we have lcd-controller next to it. So having epd-controller? But that is exactly what epdc stands for. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel