From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2ED7C433F5 for ; Thu, 17 Feb 2022 20:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lEz3SW3a8BoHQMcy1vfZhGMQDvg+pd0Rs/DjjG3a6Ac=; b=d3GUHja9SYZLIt VOk6/hdWTyRLf75cTPHRD8GBUJUO/vmQBYCD6MIzEZubFVaobEEwgTw7D56Ybi3anYT1lix4AgNtR hFGYw3Jf1xIVPp6zzcYGQIjwjeAJ/33YYQPa7INiu7kp8tSOdZCag81lZskGPRZt7lv+E7YCIsPR6 PT9wj328V9eDd7kOctERPDCDAEN/Zq274A2UNZaLxDPJ0UN2wntw9KKFMs11D/vyOSR2N7DDPS/Ab 1m+l1YVPDrgZt2GdC/11mtJvYh4F2Y2zrbrIH7Fgy2HmzH1XAOhiOsMRMP4tU3yVg5nKxZ4DnEHVS 3QgEp1/FFt4hrcC6ZJ1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKnTm-00C8B1-CQ; Thu, 17 Feb 2022 20:34:19 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKnMp-00C4kA-5e; Thu, 17 Feb 2022 20:27:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9FE6E61C7B; Thu, 17 Feb 2022 20:27:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03691C340E8; Thu, 17 Feb 2022 20:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645129626; bh=qFslgy9Zc+iKVRWaMOWnNLrhzKHJklAO5QBOWjbz0ts=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=tHgd/MrGAYyt2xk5BCf7El2DggYP+6xNARgED3xyZtDN/yyklK5HDdTu2VlCiOWoZ FEP9ldCgarGMOmRk/bxjuTpUgv1zL+xtkkrvTJgCXnb3xifNYIsRMTP1LWbc6PD/oM sq5mwgg/5+Dg6CFpRKtQI+rxwjJ71CnA4H8Gf4VGhAkuT7PxxUMvdDfeCn5muxT9vD Dv2e6K38uzHuxvYTXLv5iaENHkbhsW0kHnBMsdZo9Qmu0Z6etrikbC6HTPNk3IPBHI f/q8wCXs2G3S25hUDejsbNVhh4iAAqGyZmO3JzA9Sf25cg9vq53E4muMq3fkTiRUx3 PekV0DfEZfyDw== MIME-Version: 1.0 In-Reply-To: <20220208124034.414635-22-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-22-wenst@chromium.org> Subject: Re: [PATCH v3 21/31] clk: mediatek: cpumux: Implement error handling in register API From: Stephen Boyd Cc: Chen-Yu Tsai , Chun-Jie Chen , AngeloGioacchino Del Regno , Miles Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org To: Chen-Yu Tsai , Matthias Brugger , Michael Turquette Date: Thu, 17 Feb 2022 12:27:04 -0800 User-Agent: alot/0.10 Message-Id: <20220217202706.03691C340E8@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_122707_358586_3D4B2AAC X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Chen-Yu Tsai (2022-02-08 04:40:24) > The cpumux clk type registration function does not stop or return errors > if any clk failed to be registered, nor does it implement an error > handling path. This may result in a partially working device if any > step failed. > > Make the register function return proper error codes, and bail out if > errors occur. Proper cleanup, i.e. unregister any clks that were > successfully registered, is done in the new error path. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel