From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72B49C433EF for ; Thu, 17 Feb 2022 20:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rPSE0/04eEBr0zzQYSNR3rDqvf/x/wGyfZ5EnsKuBe8=; b=1a37LZxbYjYASu tuuuTSdi8NI1y3No7LfVlqx4ssRJJKgNl7x5FkECX0o8jjIk9xpWFUT5QgCjI2Hc2zrUGyCbmD84W NN1CHoGNQ/Xu2b7VwHhfAqSJdl7IZSpXthIDhf/P86tycV1mOLRvYGcZprub58PKGl65VD5ShnBYX iOWU28+NvvokTQh7OFtlsriT3LqQtfMRsmntdFdibPEItssbp1HwzH7qpbrARgByb6xfri0D8bt5f umoDy0WOVgCVCPICtNmfpPHWpPi6+mY6TUca7PCj4Ny2moXfenmuLOtd5MB/yzYI3M/0yLp41a/DL lpoCRjGg7Wuu386SBxEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKnVO-00C8yV-5q; Thu, 17 Feb 2022 20:35:58 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKnNO-00C523-P0; Thu, 17 Feb 2022 20:27:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6471CB82486; Thu, 17 Feb 2022 20:27:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 048DDC340E8; Thu, 17 Feb 2022 20:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645129660; bh=ilOYBZRzF5qZKxjckhhQqQteFDzfc4LnB9TUkegTnI0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=NynGR/00wKw0k2eFA7b+jXiOys3z4RXbxJzy5i624cXq0jt3ho6bk+Jb6uSZlCGyn FH18ltJSNPHAPLH/2cGRgw3Yzi3wdkK2ZJt0bOMtrTwETVa34DXTXCHhcvDBLXiOL5 +6oQ9Ug6y655pIfts9cLDEOMDX+GpJE0E252aJtiag+NU2lU/4YJf9GA6VwmTAN0Qr CZMWCOApGSkWQpRfjNaD0SS/ICQGfwTmpZDagJ7CFsjaTGtVW6LzRZYrRjCl78hg7+ pUP9ci8dlRnD+JvuuycbP/FRLWGQmsPQMWbUDR3w4jtAGdtIZ8ylV1aTVV4v7r9kz9 ps7D9zGLVP5Ew== MIME-Version: 1.0 In-Reply-To: <20220208124034.414635-24-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-24-wenst@chromium.org> Subject: Re: [PATCH v3 23/31] clk: mediatek: mux: Reverse check for existing clk to reduce nesting level From: Stephen Boyd Cc: Chen-Yu Tsai , Chun-Jie Chen , AngeloGioacchino Del Regno , Miles Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org To: Chen-Yu Tsai , Matthias Brugger , Michael Turquette Date: Thu, 17 Feb 2022 12:27:38 -0800 User-Agent: alot/0.10 Message-Id: <20220217202740.048DDC340E8@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_122743_014943_9F6939B4 X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Chen-Yu Tsai (2022-02-08 04:40:26) > The clk registration code here currently does: > > if (IS_ERR_OR_NULL(clk_data->clks[mux->id])) { > ... do clk registration ... > } > > This extra level of nesting wastes screen real estate. > > Reduce the nesting level by reversing the conditional shown above. > Other than that, functionality is not changed. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel