From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00D9DC433F5 for ; Thu, 17 Feb 2022 20:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RKpnGOBrkZMzFdL/yT7Ut9Xn8IozzGMOoeGwL7LtwQE=; b=ckJ7UgqPgOIYOD XaR/Z/HZ7bdkPINTYf8ElEj9iOpXQFupg0Zu2wYHWUxnvjC1jf27p8zEXqlruf0Auqc1IQwPf0hiP QcM9rJzltxR3Fr6wDOGeR4Id71jNkAKxTKMPdDiFJLU5MitV/FE3W0WeVsOhLahhpmHTD9zM5PApR esz4tGr138OJDeVUKCkNxhOm3bibIrUGJsWulofVjGGvZhqiehijCZMaASJWm/cpTp0A4S4a0XiUC L2R2aXE4Q3adNgZDCArRqEsn7BHD8LMzmX9oeirpqi8nlpiFGvNk8m1+eHE/679cB0QgJ7WRRfTmp tmKFvSonEu/Kg0xyi9Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKndK-00CCoE-34; Thu, 17 Feb 2022 20:44:11 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKnPf-00C689-SF; Thu, 17 Feb 2022 20:30:05 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DA328CE303C; Thu, 17 Feb 2022 20:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D419C340EC; Thu, 17 Feb 2022 20:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645129800; bh=SSsBZlXzBFeoEU5lw4r/D18/9Ff6qo5+77w6dEp8nyA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=d7Dt9lvXsqeoUyL1ISqNJDAqcUutI+/E/7+ZTu+75S2mfvQ4Ti31+UELUzGSSESeG 6tqIYbssvR7mXH5yAoo1u8VYIvjXoYBIjqoyH0iRHf/tnuaChbRWdUwyu+LWknPdZt MbzS6bPy25wxSa2/y3tuKRigDPeEFNDhCiesNVaRWZ28p2KIYPJ60XoVko8HWwHF/K y6iZN5I507RgHIFzU1iV6gIhH6ajfpJ2b/o9pxDGrW1OnJ1D8zJrJgxWFo5b2W29nm b9nEc50yHfFqw6HASUn/E+bSfMFHapyCua9m8YjN7fODNi6XEqx66Pr/U42XTejAoH c/NaHmvrUGt1Q== MIME-Version: 1.0 In-Reply-To: <20220208124034.414635-32-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-32-wenst@chromium.org> Subject: Re: [PATCH v3 31/31] clk: mediatek: Warn if clk IDs are duplicated From: Stephen Boyd Cc: Chen-Yu Tsai , Chun-Jie Chen , AngeloGioacchino Del Regno , Miles Chen , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org To: Chen-Yu Tsai , Matthias Brugger , Michael Turquette Date: Thu, 17 Feb 2022 12:29:58 -0800 User-Agent: alot/0.10 Message-Id: <20220217203000.3D419C340EC@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_123004_143983_156F622B X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Chen-Yu Tsai (2022-02-08 04:40:34) > The Mediatek clk driver library handles duplicate clock IDs in two > different ways: either ignoring the duplicate entry, or overwriting > the old clk. Either way may cause unexpected behavior, and the latter > also causes an orphan clk that cannot be cleaned up. > > Align the behavior so that later duplicate entries are ignored, and > a warning printed. The warning will also aid in making the issue > noticeable. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel