From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAE78C433F5 for ; Fri, 18 Feb 2022 02:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TjtOv1qEncyVUi6P3LaTI5F+aPdxfXYY3B4yDpc2d/8=; b=Ro80B7oOqMwIqr rgvKAcia0sf8dFa+RmxOOpuARjZU6Cu8MyPmhkaWwTBQOR0IQi49Z8L8gOfblMLFJebRJCyah2uPN 9h/JaaULDKW4Mnr2WR0xgjRExJsIcRDjps3+8rbarXDnORca1/Cjqjq7PbftaHrwytOYJQKoO3vPZ 6Auy5ZnWvs+PcssTSyeQi4B7kmGgMJ1bRG9dSFpFs0/MD4s8MyT3uZWNC2AAs3zRx2Olhk8VEYzQ9 2SRPyhKINPI0DkhkiF4ts0c4itnvBSSTAQ97h259XSuvXK2CgZ9uN1EfBomFcoSY9cIJ6X4jjpWZ1 aUxIcp3Cin1z3j5FBpeA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKsXn-00CgK3-LU; Fri, 18 Feb 2022 01:58:47 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKsXk-00CgG1-JG for linux-arm-kernel@lists.infradead.org; Fri, 18 Feb 2022 01:58:45 +0000 Received: by mail-pj1-x1029.google.com with SMTP id k60-20020a17090a4cc200b001b932781f3eso7359490pjh.0 for ; Thu, 17 Feb 2022 17:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZDSkUfp9toni5mt9GhqILhie8mR19f4SRKJDHSNLJMQ=; b=egfIW48oBvJ/rLtSDNSipUVlWRgNK8wpWktEAmc/Pz+571EuPH93FuvLqvVMByQ5db HxtZ13ltXoICHbkwOBttZaBYSeCuox2CL3P4RAqZvDgpbPpaFuIF8QcVfmp9p+Y4VQpc mzA0G2mDcmnDkdl51jrsYO9slg6f8xE9971Xjsbuy4/LKM55y/CrCEgq2tbneTD/xBeK 3lC2cASpiz/4y7xNjRZljYqX0sfxnLI5TUGW/8WBeVgqCZoMhU1ieMHZSNWxYpx/+TzN St8Bj0xwfe32lJ1e+goTg/5mMQlIuZ4oZj8OJMq3iXzKrs2n9g7/mu280HPU3j2r6lV5 0Yaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZDSkUfp9toni5mt9GhqILhie8mR19f4SRKJDHSNLJMQ=; b=BZy/ttqaP/y4Hl66kVIk/YzbUTwtI0zz2+SuHOxWzhazkcHG2tfzVu5gSmgiC7EcuP rq40dPHhSJBRRCh9gmFiMZEeqp6dZEa4UcZA5ZDYswPqNZ6AZ7W/HErMrjvxSchmUgGw FYV9RNzoCalpmtHj6qoXYDIH/onnqIHLVToqaKyg/ZxcKlNrzoRZp70uhR00KZEP06+Z 7lNjPhzBy1cjEhM8M+1O3iSV0f7worT0jCJmC8/n0sVEn8nYLYmXuOhIRAqSwQ/cKEYU iGC9n9TmFySwy0rdt59cWLQpd1ShwQqlBBNnEAtWXPYE78f6BC7t8YFgxHlEQqr5TitE l0VA== X-Gm-Message-State: AOAM531urnYxZQZ8XIPka1G4nDEPGHgCUya50qeJwqXz7vMkoCqMeoTl Fq3BcQ6k83A+odv3vQJqYwU4YQ== X-Google-Smtp-Source: ABdhPJy2k7pnPPA0dR19XFlkrV9I2LgB9Fmjp0AzFRXaw08FvPFHy9T2UllkCBD/Je9vr200hAGEwA== X-Received: by 2002:a17:90b:250f:b0:1b8:f257:c39 with SMTP id ns15-20020a17090b250f00b001b8f2570c39mr5924833pjb.135.1645149515932; Thu, 17 Feb 2022 17:58:35 -0800 (PST) Received: from leoy-ThinkPad-X240s (104.225.159.78.16clouds.com. [104.225.159.78]) by smtp.gmail.com with ESMTPSA id t15sm8956290pgu.13.2022.02.17.17.58.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 17:58:35 -0800 (PST) Date: Fri, 18 Feb 2022 09:58:28 +0800 From: Leo Yan To: Marco Elver Cc: John Garry , peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, jolsa@kernel.org, namhyung@kernel.org, dvyukov@google.com, will@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, irogers@google.com, Thomas Richter Subject: Re: [PATCH] perf test: Skip Sigtrap test for arm+aarch64 Message-ID: <20220218015828.GA925833@leoy-ThinkPad-X240s> References: <1645114959-119064-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_175844_648743_02B6A98B X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 17, 2022 at 06:40:45PM +0100, Marco Elver wrote: > On Thu, 17 Feb 2022 at 18:34, John Garry wrote: > [...] > > >> -#if defined(__powerpc__) || defined(__s390x__) > > >> +#if defined(__powerpc__) || defined(__s390x__) || \ > > >> + defined(__arm__) || defined(__aarch64__) > > >> #define BP_ACCOUNT_IS_SUPPORTED 0 > > >> #else > > >> #define BP_ACCOUNT_IS_SUPPORTED 1 > > > > > > This is now equivalent to BP_SIGNAL_IS_SUPPORTED > > > tools/perf/tests/tests.h -- and different from the original > > > BP_ACCOUNT_IS_SUPPORTED (and makes me wonder why > > > BP_SIGNAL_IS_SUPPORTED wasn't just used from the beginning). Perhaps > > > just use BP_SIGNAL_IS_SUPPORTED. > > > > > > > We currently have BP_ACCOUNT_IS_SUPPORTED defined now in 2x locations: > > > > tests/sigtrap.c > > tests/bp_account.c > > > > bp_account works for arm64, and we don't want to skip that test. So, as > > long as the macro meaning is appropriate, we can reuse > > BP_SIGNAL_IS_SUPPORTED for sigtrap.c > > BP_ACCOUNT seems to say something about the "breakpoint accounting / > measuring" test. BP_SIGNAL is about the tests that want to use > breakpoints to generate signals. More general speaking, I think "BP_ACCOUNT_IS_SUPPORTED = 1" means an architecture can support breakpoint with perf_event. "BP_SIGNAL_IS_SUPPORTED = 1" means an architecture can support breakpoint to generate signals with using perf_event. So "BP_SIGNAL_IS_SUPPORTED = 1" is subset of "BP_ACCOUNT_IS_SUPPORTED = 1". > So it's very much appropriate to use BP_SIGNAL here if, as we have > discovered regardless how they're generated in response to > breakpoints, are broken on arm/arm64. On the day arm/arm64 decides to > fix signals, I'm assuming all tests being skipped with > BP_SIGNAL_IS_SUPPORTED can be re-enabled (or so we hope). Yeah, I agree that BP_SIGNAL_IS_SUPPORTED is better choice for sigtrap.c. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel