From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 518EFC433F5 for ; Fri, 18 Feb 2022 08:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ctw2Qf1wmxAygbAIKUXh1jett+rLrdJzNMGgT/9HXpg=; b=Rfacbpo4bmiyMV wAhrGfgq+Tc+QNCiDWzYS4/+17QsiLSg+pUSClq6wivneE0/CTonH8KDyJGCgT9xMel92ltDQhAsX X2kVqipxWIhXNp4M0+g8w1CDbj2iFuZkuzwTflf2lST9LQxJh+cR14x4ag2LkPvHSJ/S3UiBC2JMl FygkPgm2tjSRo9P0NiZcCt42TYxriBfWbgXf0l3HnQlGXD4JZV9kauTJglPFpQ1dDJhd4h9fIlwfo ELQsZQfXd99dhVtN27J4aT/vxdI0HR19T4JEMpUpAcVdjozpBYThkLqZPNXVEN4hGyP5G0Ftm/i6D sIKSftiEtrE4Cf6VXfLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKyBt-00DFw9-KF; Fri, 18 Feb 2022 08:00:33 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKyBq-00DFvB-7r for linux-arm-kernel@lists.infradead.org; Fri, 18 Feb 2022 08:00:31 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKyBn-0001Pb-Fj; Fri, 18 Feb 2022 09:00:27 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nKyBk-0006aK-Mo; Fri, 18 Feb 2022 09:00:24 +0100 Date: Fri, 18 Feb 2022 09:00:24 +0100 From: Sascha Hauer To: Andy Yan Cc: Heiko =?iso-8859-15?Q?St=FCbner?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Message-ID: <20220218080024.GU18637@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217135823.GR18637@pengutronix.de> <6072461.kR79ftKOrO@diego> <8c0b1d1e-6787-8edc-c1fd-e1b68b92e60e@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8c0b1d1e-6787-8edc-c1fd-e1b68b92e60e@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:48:57 up 69 days, 16:34, 71 users, load average: 0.11, 0.13, 0.14 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220218_000030_303793_DABFFD68 X-CRM114-Status: GOOD ( 41.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > Hi Sascha: > = > On 2/17/22 22:06, Heiko St=FCbner wrote: > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > > > Hi Andy, > > > = > > > Please trim the context in your answers to the relevant parts, it mak= es > > > it easier to find the things you said. > > > = > > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > > > Hi Sascha: > > > > = > > > > > + > > > > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->encod= er_mask) { > > > > > + struct rockchip_encoder *rkencoder =3D to_rockchip_encoder(enc= oder); > > > > > + struct device_node *node, *parent; > > > > > + > > > > > + parent =3D of_get_parent(rkencoder->port); > > > > > + > > > > > + for_each_endpoint_of_node(parent, node) { > > > > Is there any hurt directly use our downstream vendor kernel method = here: use > > > > vcstate->output_if set by encoder driver to get which interface we = should > > > > enable here? > > > There is no vcstate->output_if in mainline currently. Ok, we could add > > > that. The other thing is that there are multiple HDMI interfaces and > > > the id of the HDMI encoder is encoded into output_if. Downstream kern= el > > > adds OF aliases to the HDMI ports. I didn't want to go that route > > > because it doesn't seem to be very elegant to me. > aliases is a very comm strategy in device tree world. Yes, but not for retrieving bit offsets into registers. Normally aliases can be changed at board level without confusing drivers. > And your method also > add need additional dt binds to define RK3568_VOP2_EP_xxx > > > > You method is ok with device tree, but it tied up this driver to d= evice > > > > tree, we are now tring to extend vop2 driver work with ACPI, so we = hope this > > > > driver can be much more flexible. > > > The current rockchip drm driver seems to be pretty much tied to device > > > tree. There are probably many other places that need parallel paths f= or > > > ACPI support, I think we can delay this particular part until we see = the > > > whole picture. In the end we can still retrieve the output_if > > > information differently with ACPI while still retrieving the informat= ion > > > from the device tree the way we are doing currently. > = > The current driver only reference device thee at driver initial, we not w= rap > = > device tree related things in other parts, so if we extend it to support > ACPI, > = > we just need modify the initial code, this make things easier. The device tree parsing could be moved out of vop2_crtc_atomic_enable() into some initialisation path. In the end it's static information, there's no need to do it repeatedly in atomic_enable. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel