From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26672C433EF for ; Mon, 21 Feb 2022 06:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+dX/D8SmVZmBBsvRchoINJhbC7+eTHGFYYAIsHx/XNM=; b=VITeM9ZBkWq2lO n6zwhTUlSBJGHWQYuIE7snHXydrVTHF8lGk0Yzmj9W5EcMBkIHUrAjjsfUNzvq93gbxI2nULa/0Df J6MnUUezFWdw+x4qmIpwjtHkaTDRQ4h/FpZFA9Y5YhHtCKBmdzbVIkTUHDb8gGzNt94aYc1XD7ZuA nPL/Kun01TH1T/1V/lvSmTJEpxKvIMtm+R7itb/ux2PgRbp2OVWk8/72RFmE8++Frl+ox6bH/I10J qqIyQRptzT+sm47a3Rbwxw9kfL16X9rWtUpFZ4aDNBs4e35P0PJ6kpp/NPT32ZD/DG8W4UQl9p9MK h2JGyqG5C6szMzmPSobw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM1jW-003ZPK-VY; Mon, 21 Feb 2022 05:59:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM1jU-003ZOa-4F for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 05:59:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A311B60AE9; Mon, 21 Feb 2022 05:59:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73DF0C340E9; Mon, 21 Feb 2022 05:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645423175; bh=fGwgMYphfpWjyW69aMJ2HqeGEyIaZkfLuN0V8VR8cR8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uFFaM4rD72AYMKjjkZp7mjpnRWFygenAO9MxEQDZoepjDv8SIXADJUObnv5hjkdiM g7SeyXnFBwN2yr0wtNZwlhV6gMq8M9c180bEpRzwKoz18Xd3VK/Fx6cx58+4vgX0IC fhELEl4Q1krhVaQwANHiIPjLKZWxY2OZioeJUgxPzpM0G9drUxFUhS1/kdgzZhlC2P hOcafnb2ki+1fxjKmt3rMXVNfo0izC6tcoCFeGN+LU4h91YBPWup1R9vji2o+mSNum FTU+E1fdiOtIEQ3DowPNil9QrBWqz3swp2mBjI7o7TDT7qL/+mfL9tEdr5+xXpaP3y nngp/R0WMtepw== Date: Mon, 21 Feb 2022 13:59:29 +0800 From: Shawn Guo To: Laurent Pinchart Cc: linux-arm-kernel@lists.infradead.org, Lucas Stach , Pengutronix Kernel Team , Sascha Hauer , Fabio Estevam , NXP Linux Team , Peng Fan , Marek Vasut Subject: Re: [PATCH] soc: imx: gpcv2: Fix clock disabling imbalance in error path Message-ID: <20220221055929.GM2249@dragon> References: <20220218215720.26241-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220218215720.26241-1-laurent.pinchart@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220220_215936_231056_7759D6D7 X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 18, 2022 at 11:57:20PM +0200, Laurent Pinchart wrote: > The imx_pgc_power_down() starts by enabling the domain clocks, and thus > disables them in the error path. Commit 18c98573a4cf ("soc: imx: gpcv2: > add domain option to keep domain clocks enabled") made the clock enable > conditional, but forgot to add the same condition to the error path. > This can result in a clock enable/disable imbalance. Fix it. > > Fixes: 18c98573a4cf ("soc: imx: gpcv2: add domain option to keep domain clocks enabled") > Signed-off-by: Laurent Pinchart Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel