From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF396C433EF for ; Mon, 21 Feb 2022 07:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iobVMwj/7W6tP2p9g4COAvSWsgBEDf4zv+wP+OolXrQ=; b=Qe3FW8KipZzv3Y K3CMuqhM4ORx1q4lrGzW6uyvWx6cznAo26tV9ZP76Ol/dGUvHYATPdRMJoKx6qYy2rlALEoUV+Gux LUpndSrhNkp5Lt9biQaMGBarW7Lp3FM5jmyxNHsjmynS0/FW4otzbslmqLceHkXvnVUhRBmT8/Iqi SRJpwCI/szfYUj+HXE1whkRQIQMcXy0X0rU96vb+wFC5CU0ga7x5Le7GdVdKsSCXP8T0wFHg8Fb3f n987HK7Gdv7mToe/stvey/ycsUl4WKY6YdeQww1/WJIwjz/sVwytJQqMq4z88jsqxh1Jbb1oWtCRy lstVi83qmoiZLNcPlbGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM3H9-0042b7-PV; Mon, 21 Feb 2022 07:38:27 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM3H4-0042Zd-Vz for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 07:38:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7DC9760F93; Mon, 21 Feb 2022 07:38:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FD7FC340E9; Mon, 21 Feb 2022 07:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645429101; bh=mzmB2HuBFhgZBkOnBNlqPbpXB2XyzjVs1S+MOZsmRm4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nEI42yMu1AvuDwmfcweVVH1cUgAX2+EcmPxrSApS5bbQzHRjQmqz/whUqj/u7cP3w iNFPWUszgRIMhVrrwJHdsHykycJ1u2pfLLF5TzPu8P+kTlUDhGqNldS/3hn4sv4IdR r57xHsq8/EsTSwtGC3/SSRSqCFlp0Pl5r/ZuqwKFQcq6/FHuRXjNkcjZIAaoKfNHmh 3aR0F0ETt/+hCQvtlzEttFUPpn/oADcfUhF9RLP4CRG1IvepW76Gi8RuRbKaPym3sl cxKFfvejMon3Qe6vt3RByixK7PKrjXFapTwKh6/Tj7LUXZdbMn7iD35eAQATiaeo4G Zwdo1cxggcu5A== Date: Mon, 21 Feb 2022 15:38:16 +0800 From: Shawn Guo To: Laurent Pinchart Cc: linux-arm-kernel@lists.infradead.org, Lucas Stach , Pengutronix Kernel Team , Sascha Hauer , Fabio Estevam , NXP Linux Team , Peng Fan , Marek Vasut Subject: Re: [PATCH] soc: imx: gpcv2: Fix clock disabling imbalance in error path Message-ID: <20220221073816.GR2249@dragon> References: <20220218215720.26241-1-laurent.pinchart@ideasonboard.com> <20220221055929.GM2249@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220220_233823_116561_AB1A1BB8 X-CRM114-Status: GOOD ( 17.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 21, 2022 at 08:29:24AM +0200, Laurent Pinchart wrote: > Hello Shawn, > > On Mon, Feb 21, 2022 at 01:59:29PM +0800, Shawn Guo wrote: > > On Fri, Feb 18, 2022 at 11:57:20PM +0200, Laurent Pinchart wrote: > > > The imx_pgc_power_down() starts by enabling the domain clocks, and thus > > > disables them in the error path. Commit 18c98573a4cf ("soc: imx: gpcv2: > > > add domain option to keep domain clocks enabled") made the clock enable > > > conditional, but forgot to add the same condition to the error path. > > > This can result in a clock enable/disable imbalance. Fix it. > > > > > > Fixes: 18c98573a4cf ("soc: imx: gpcv2: add domain option to keep domain clocks enabled") > > > Signed-off-by: Laurent Pinchart > > > > Applied, thanks! > > Thank you. > > I've noticed that Lucas' reviewed-by tag didn't end up in the commit in > your imx/fixes branch. Depending on your rebase policy with that branch, > you may want to ammend the commit. Oops! Thanks for reminding, Laurent! Fixed. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel