From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06430C433F5 for ; Mon, 21 Feb 2022 10:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R52rZyuqGKZF1pmFv3qlIHX20wHzMB9aF4vGR94OEQ0=; b=1Wjnyh5IBG2Ddo YE1z74C5yF955huMPOGM+UCXk2CjDIGIJfHdg5ouCRblroXeKB6WFJ0w1vgTYUx2UC5R9aw+Lnh1q 0WVUk1r4a0svmsdmouUWd4IcctP+v3+6EzlJpyjQxL4Zu0uAy1YZ1+SlwVeGUTqlEMUbyZYmUIYbl f3LLFfXloTNCS+7rse9IfVwWMinHrlVsz6KXEuEyvZZQgJMDamhXtKRqgxUpvezFiyvOpQq4Ru3tl NscEzIT0PZJl9AxhNNLXZ/VNmUJBbRPDPFxTaxTONXPx0miOlEJnda0NsvtAkMTwspVMosLF0rKOi O9pAlDu31UPFm5Ojqv3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM5y8-004xAK-9n; Mon, 21 Feb 2022 10:31:00 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM5O1-004hA0-OS for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 09:53:43 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nM5Nx-0007Rt-Vf; Mon, 21 Feb 2022 10:53:37 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nM5Nu-0006XB-4c; Mon, 21 Feb 2022 10:53:34 +0100 Date: Mon, 21 Feb 2022 10:53:34 +0100 From: Sascha Hauer To: Frank Wunderlich Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH v6 17/23] arm64: dts: rockchip: rk356x: Add HDMI nodes Message-ID: <20220221095334.GC18637@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217082954.2967889-18-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:52:17 up 72 days, 18:37, 85 users, load average: 0.08, 0.21, 0.25 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_015341_842732_C67F329C X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 21, 2022 at 09:54:28AM +0100, Frank Wunderlich wrote: > Hi > > > Gesendet: Donnerstag, 17. Februar 2022 um 09:29 Uhr > > Von: "Sascha Hauer" > > > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > > @@ -10,7 +10,6 @@ > > #include > > #include > > #include > > -#include > > why dropping this after adding in part 16? > > > #include > > it looks like you moved this to board includes...imho this should stay > in the rk356x.dtsi, because compilation will fail if a board without > the vop2 (and missing the include) is derived from rk356x.dtsi. I dropped adding the include from Patch 16. The include is not needed by rk356x.dtsi. When a board without vop2 support is added then it won't need the include either. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel