From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3702EC433F5 for ; Mon, 21 Feb 2022 13:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sgVNUwylfrtkIatrnD4XJ3vblykqlKM+iPpHZaGTZFs=; b=ScSHiCXnkAu7CZ d3CqDiAQa+q+Z1GpjxZUll1BaaAtr9MeEaaNr+A8EBlWxxYqbGL6NW6g/Z2QPAsPoBYHToWDgzLnP 8I/3ALLxf7VJGyfR47eo7dELsPKezpIY061gcfSljSF6awmpp9QmA8OfbhLgINLcbBSMIwIk8+CZD TSL89QmBWFXmESKiiqGvZgdff34Dct/i14pFi52YQCwzbUOaZdleklZ60ORNvsLqt92LKBCDnSCFL EMq6jbHKtgyoTy0b36oUCSP6QBLis249SCKhw24gsgTD8R8rzhVvTaz7TVq9aVhKvC+KOFGfbVl0/ iAfZyzQ2rWD3XSIOrLFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM90j-0060JG-Kc; Mon, 21 Feb 2022 13:45:56 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM8WC-005q1V-7X for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 13:14:21 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 21LDDfnW088797; Mon, 21 Feb 2022 07:13:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1645449221; bh=vXu1G0emev+TnkGG5qABAZXlSG+xfFg5QuWYDC2AHek=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Dsv0NFIKFcID9DYTIhgmbO2DQxxSezhh1ln6oR81gCTGWrdNBtZdwVr6RXFw0Zu+D b0h2t3fENlvfOJnnHPQW02XoYC9hDG1fbYEE0q8uOdf/GQ3eLloxdoTVIzGVOpsHrF jPBp3q/6mkYDibbPuzFybwbnJyfSz9WIkaQN4Lg0= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 21LDDfnC096479 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 21 Feb 2022 07:13:41 -0600 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 21 Feb 2022 07:13:40 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 21 Feb 2022 07:13:40 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 21LDDeog070333; Mon, 21 Feb 2022 07:13:40 -0600 Date: Mon, 21 Feb 2022 07:13:40 -0600 From: Nishanth Menon To: Krzysztof Kozlowski CC: Alim Akhtar , Avri Altman , Rob Herring , Wei Xu , Andy Gross , Bjorn Andersson , Vignesh Raghavendra , Tero Kristo , "James E.J. Bottomley" , "Martin K. Petersen" , Chanho Park , Srinivas Kandagatla , Jan Kotas , , , , , , Subject: Re: [RFC PATCH 8/8] arm64: dts: ti: use 'freq-table' in UFS node Message-ID: <20220221131340.q3hjpjevqrfvhggv@specimen> References: <20220219184224.44339-1-krzysztof.kozlowski@canonical.com> <20220219184554.44887-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220219184554.44887-1-krzysztof.kozlowski@canonical.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_051420_396916_FCD19F2E X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19:45-20220219, Krzysztof Kozlowski wrote: > The 'freq-table-hz' property is deprecated by UFS bindings. > The uint32-array requires also element to be passed within one <> block. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index 599861259a30..c3afef0321ae 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -1257,7 +1257,9 @@ ufs@4e84000 { > compatible = "cdns,ufshc-m31-16nm", "jedec,ufs-2.0"; > reg = <0x0 0x4e84000 0x0 0x10000>; > interrupts = ; > - freq-table-hz = <250000000 250000000>, <19200000 19200000>, <19200000 19200000>; > + freq-table = <250000000 250000000 is much more readable and less error prone in case of a large set. > + 19200000 19200000 > + 19200000 19200000>; are you sure the removal of the tuple adds value? > clocks = <&k3_clks 277 0>, <&k3_clks 277 1>, <&k3_clks 277 1>; > clock-names = "core_clk", "phy_clk", "ref_clk"; > dma-coherent; > -- > 2.32.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel