From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: (EXT) Re: [PATCH 2/5] ARM: dts: imx6ul: add TQ-Systems MBa6ULx device trees
Date: Tue, 22 Feb 2022 10:14:10 +0800 [thread overview]
Message-ID: <20220222021410.GU2249@dragon> (raw)
In-Reply-To: <2816666.e9J7NaK4W3@steina-w>
On Mon, Feb 21, 2022 at 04:45:58PM +0100, Alexander Stein wrote:
...
> > > diff --git a/arch/arm/boot/dts/mba6ulx.dtsi
> > > b/arch/arm/boot/dts/mba6ulx.dtsi new file mode 100644
> > > index 000000000000..3a35b1efdc1f
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/mba6ulx.dtsi
> > > @@ -0,0 +1,615 @@
> > > +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > > +/*
> > > + * Copyright 2018-2022 TQ-Systems GmbH
> > > + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
> > > + */
> > > +
> > > +/ {
> > > + model = "TQ-Systems MBA6ULx Baseboard";
> > > +
> > > + aliases {
> > > + mmc0 = &usdhc2;
> > > + mmc1 = &usdhc1;
> > > + rtc0 = &rtc0;
> > > + rtc1 = &snvs_rtc;
> > > + };
> > > +
> > > + backlight: backlight {
> > > + compatible = "pwm-backlight";
> > > + power-supply = <®_mba6ul_3v3>;
> > > + enable-gpios = <&expander_out0 4 GPIO_ACTIVE_HIGH>;
> > > + status = "disabled";
> > > + };
> > > +
> > > + beeper: beeper {
> > > + compatible = "gpio-beeper";
> > > + gpios = <&expander_out1 6 GPIO_ACTIVE_HIGH>;
> > > + };
> > > +
> > > + chosen {
> > > + stdout-path = &uart1;
> > > + };
> >
> > Move 'chosen' node up.
>
> Ok. The binding does not say anything regarding the order with respect to the
> alias node. I've seen examples of both order. So I went with alias 1st, chosen
> 2nd.
Sorry for not being clear, but I was asking to put 'chosen' before
backlight and beeper nodes.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-22 2:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 13:42 [PATCH 0/5] Support for TQMa6ULx & TQMa6ULxL modules Alexander Stein
2022-02-08 13:42 ` [PATCH 1/5] dt-bindings: arm: fsl: add TQ Systems boards based on i.MX6UL(L) Alexander Stein
2022-02-11 16:44 ` Rob Herring
2022-02-08 13:42 ` [PATCH 2/5] ARM: dts: imx6ul: add TQ-Systems MBa6ULx device trees Alexander Stein
2022-02-13 3:12 ` Shawn Guo
2022-02-21 15:45 ` (EXT) " Alexander Stein
2022-02-22 2:14 ` Shawn Guo [this message]
2022-02-08 13:42 ` [PATCH 3/5] ARM: dts: imx6ul: add TQ-Systems MBa6ULxL " Alexander Stein
2022-02-08 13:42 ` [PATCH 4/5] ARM: dts: imx6ull: add TQ-Systems MBa6ULLx " Alexander Stein
2022-02-08 13:42 ` [PATCH 5/5] ARM: dts: imx6ull: add TQ-Systems MBa6ULLxL " Alexander Stein
2022-02-08 16:09 ` Krzysztof Kozlowski
2022-02-10 12:10 ` (EXT) " Alexander Stein
2022-02-10 12:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222021410.GU2249@dragon \
--to=shawnguo@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).