From: Nancy.Lin <nancy.lin@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"jason-jh . lin" <jason-jh.lin@mediatek.com>,
"Nancy . Lin" <nancy.lin@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<singo.chang@mediatek.com>, <srv_heupstream@mediatek.com>
Subject: [PATCH v12 08/23] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1
Date: Tue, 22 Feb 2022 18:07:26 +0800 [thread overview]
Message-ID: <20220222100741.30138-9-nancy.lin@mediatek.com> (raw)
In-Reply-To: <20220222100741.30138-1-nancy.lin@mediatek.com>
MT8195 vdosys1 has more than 32 reset bits and a different reset base
than other chips. Modify mmsys for support 64 bit and different reset
base.
Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/soc/mediatek/mt8195-mmsys.h | 1 +
drivers/soc/mediatek/mtk-mmsys.c | 21 ++++++++++++++++-----
drivers/soc/mediatek/mtk-mmsys.h | 2 ++
3 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/soc/mediatek/mt8195-mmsys.h b/drivers/soc/mediatek/mt8195-mmsys.h
index 11ba79e3275e..628098260f61 100644
--- a/drivers/soc/mediatek/mt8195-mmsys.h
+++ b/drivers/soc/mediatek/mt8195-mmsys.h
@@ -229,6 +229,7 @@
#define MT8195_VDO1_MIXER_SOUT_SEL_IN 0xf68
#define MT8195_MIXER_SOUT_SEL_IN_FROM_DISP_MIXER 0
+#define MT8195_VDO1_SW0_RST_B 0x1d0
#define MT8195_VDO1_MERGE0_ASYNC_CFG_WD 0xe30
#define MT8195_VDO1_MERGE1_ASYNC_CFG_WD 0xe40
#define MT8195_VDO1_MERGE2_ASYNC_CFG_WD 0xe50
diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index 1b0024ee47a9..3f85171c980e 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -19,6 +19,8 @@
#include "mt8195-mmsys.h"
#include "mt8365-mmsys.h"
+#define MMSYS_SW_RESET_PER_REG 32
+
static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = {
.clk_driver = "clk-mt2701-mm",
.routes = mmsys_default_routing_table,
@@ -49,12 +51,16 @@ static const struct mtk_mmsys_driver_data mt8173_mmsys_driver_data = {
.clk_driver = "clk-mt8173-mm",
.routes = mmsys_default_routing_table,
.num_routes = ARRAY_SIZE(mmsys_default_routing_table),
+ .sw_reset_start = MMSYS_SW0_RST_B,
+ .num_resets = 32,
};
static const struct mtk_mmsys_driver_data mt8183_mmsys_driver_data = {
.clk_driver = "clk-mt8183-mm",
.routes = mmsys_mt8183_routing_table,
.num_routes = ARRAY_SIZE(mmsys_mt8183_routing_table),
+ .sw_reset_start = MMSYS_SW0_RST_B,
+ .num_resets = 32,
};
static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data = {
@@ -75,6 +81,8 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
.num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table),
.config = mmsys_mt8195_config_table,
.num_configs = ARRAY_SIZE(mmsys_mt8195_config_table),
+ .sw_reset_start = MT8195_VDO1_SW0_RST_B,
+ .num_resets = 64,
};
static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = {
@@ -133,18 +141,22 @@ static int mtk_mmsys_reset_update(struct reset_controller_dev *rcdev, unsigned l
{
struct mtk_mmsys *mmsys = container_of(rcdev, struct mtk_mmsys, rcdev);
unsigned long flags;
+ u32 offset;
u32 reg;
+ offset = (id / MMSYS_SW_RESET_PER_REG) * sizeof(u32);
+ id = id % MMSYS_SW_RESET_PER_REG;
+
spin_lock_irqsave(&mmsys->lock, flags);
- reg = readl_relaxed(mmsys->regs + MMSYS_SW0_RST_B);
+ reg = readl_relaxed(mmsys->regs + mmsys->data->sw_reset_start + offset);
if (assert)
reg &= ~BIT(id);
else
reg |= BIT(id);
- writel_relaxed(reg, mmsys->regs + MMSYS_SW0_RST_B);
+ writel_relaxed(reg, mmsys->regs + mmsys->data->sw_reset_start + offset);
spin_unlock_irqrestore(&mmsys->lock, flags);
@@ -240,10 +252,11 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
return ret;
}
+ mmsys->data = of_device_get_match_data(&pdev->dev);
spin_lock_init(&mmsys->lock);
mmsys->rcdev.owner = THIS_MODULE;
- mmsys->rcdev.nr_resets = 32;
+ mmsys->rcdev.nr_resets = mmsys->data->num_resets;
mmsys->rcdev.ops = &mtk_mmsys_reset_ops;
mmsys->rcdev.of_node = pdev->dev.of_node;
ret = devm_reset_controller_register(&pdev->dev, &mmsys->rcdev);
@@ -252,8 +265,6 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
return ret;
}
- mmsys->data = of_device_get_match_data(&pdev->dev);
-
#if IS_REACHABLE(CONFIG_MTK_CMDQ)
ret = cmdq_dev_get_client_reg(dev, &mmsys->cmdq_base, 0);
if (ret)
diff --git a/drivers/soc/mediatek/mtk-mmsys.h b/drivers/soc/mediatek/mtk-mmsys.h
index 2694021435d2..4842102cd451 100644
--- a/drivers/soc/mediatek/mtk-mmsys.h
+++ b/drivers/soc/mediatek/mtk-mmsys.h
@@ -102,6 +102,8 @@ struct mtk_mmsys_driver_data {
const unsigned int num_routes;
const struct mtk_mmsys_config *config;
const unsigned int num_configs;
+ u32 sw_reset_start;
+ u32 num_resets;
};
/*
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-22 10:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 10:07 [PATCH v12 00/23] Add MediaTek SoC DRM (vdosys1) support for mt8195 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 01/23] dt-bindings: mediatek: add vdosys1 RDMA definition " Nancy.Lin
2022-03-02 10:13 ` AngeloGioacchino Del Regno
2022-03-07 2:37 ` Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 02/23] dt-bindings: mediatek: add vdosys1 MERGE property " Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 03/23] dt-bindings: mediatek: add ethdr definition " Nancy.Lin
2022-03-02 10:13 ` AngeloGioacchino Del Regno
2022-03-07 2:33 ` Nancy.Lin
2022-03-07 9:42 ` AngeloGioacchino Del Regno
2022-02-22 10:07 ` [PATCH v12 04/23] dt-bindings: reset: mt8195: add vdosys1 reset control bit Nancy.Lin
2022-03-02 10:14 ` AngeloGioacchino Del Regno
2022-02-22 10:07 ` [PATCH v12 05/23] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 06/23] soc: mediatek: add mtk-mmsys config API " Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 07/23] soc: mediatek: add cmdq support of " Nancy.Lin
2022-02-22 10:07 ` Nancy.Lin [this message]
2022-02-22 10:07 ` [PATCH v12 09/23] soc: mediatek: change the mutex defines and the mutex_mod type Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 10/23] soc: mediatek: add mtk-mutex support for mt8195 vdosys1 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 11/23] drm/mediatek: add display MDP RDMA support for MT8195 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 12/23] drm/mediatek: add display merge advance config API " Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 13/23] drm/mediatek: add display merge start/stop API for cmdq support Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 14/23] drm/mediatek: add display merge mute/unmute support for MT8195 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 15/23] drm/mediatek: add display merge async reset control Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 16/23] drm/mediatek: add ETHDR support for MT8195 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 17/23] drm/mediatek: add mediatek-drm plane color encoding info Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 18/23] drm/mediatek: add ovl_adaptor support for MT8195 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 19/23] drm/mediatek: add dma dev get function Nancy.Lin
2022-03-02 10:05 ` AngeloGioacchino Del Regno
2022-03-07 6:20 ` CK Hu
2022-02-22 10:07 ` [PATCH v12 20/23] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 21/23] drm/mediatek: add drm ovl_adaptor sub driver for MT8195 Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 22/23] drm/mediatek: add mediatek-drm of vdosys1 support " Nancy.Lin
2022-02-22 10:07 ` [PATCH v12 23/23] arm64: dts: mt8195: add display node for vdosys1 Nancy.Lin
2022-03-02 10:10 ` AngeloGioacchino Del Regno
2022-03-07 7:26 ` Nancy.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222100741.30138-9-nancy.lin@mediatek.com \
--to=nancy.lin@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=singo.chang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).