From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3F4EC433EF for ; Tue, 22 Feb 2022 15:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FkF2KT5P30HCa90iuGIUyJLIk6gfBaKDBZCfpmPfk1A=; b=SPM+NRWUAjl2Me mK6/eGNjnmvnMO0l5r/wlGZOTFjs/T0/8LTTyeEvUGZeivduJVTLYl+6TKxTd1iojOAlGvlqT0jXT U/JmVvwNDgxE/tT5gYOM3SF4TZSI0V+zAq5CYFsrQZoPTavSAnHqHm75Hf++ZD1jv5PAhkkYplQFU UUNQpVXfs8Adil/XsCjsJ9PbSPeLi6YjTafUdG3efQeF+EdDC2VZSbuwKHMqLLG/b/9zPYIJqVJ6d TEcXes7D+SH+IWsMOF8I8iX7a9GmaycJUVpQKkSfd+8U+wlM/aaB+BPow1+kYBFQ91MymoHIxV5IE Vt3AlG3+GK9+ZtgavqtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMX3J-00AD6n-Qv; Tue, 22 Feb 2022 15:26:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMX1W-00ACAX-6I for linux-arm-kernel@lists.infradead.org; Tue, 22 Feb 2022 15:24:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 17950ED1; Tue, 22 Feb 2022 07:24:17 -0800 (PST) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9FFA73F5A1; Tue, 22 Feb 2022 07:24:15 -0800 (PST) Date: Tue, 22 Feb 2022 15:24:09 +0000 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: robh+dt@kernel.org, Bjorn Helgaas , Thomas Petazzoni , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Russell King , Marc Zyngier , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 10/11] PCI: mvebu: Implement support for legacy INTx interrupts Message-ID: <20220222152409.GA18799@lpieralisi> References: <20220105150239.9628-1-pali@kernel.org> <20220112151814.24361-1-pali@kernel.org> <20220112151814.24361-11-pali@kernel.org> <20220211171917.GA740@lpieralisi> <20220211175202.gku5pkwn5wmjo5al@pali> <20220216234039.stxv5ndd6ai23sbb@pali> <20220222102057.GA17238@lpieralisi> <20220222105129.jg5kwmhvhggsv72n@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220222105129.jg5kwmhvhggsv72n@pali> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_072418_467249_B38DE342 X-CRM114-Status: GOOD ( 52.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 22, 2022 at 11:51:29AM +0100, Pali Roh=E1r wrote: > On Tuesday 22 February 2022 10:21:06 Lorenzo Pieralisi wrote: > > On Thu, Feb 17, 2022 at 12:40:39AM +0100, Pali Roh=E1r wrote: > > > On Friday 11 February 2022 18:52:02 Pali Roh=E1r wrote: > > > > On Friday 11 February 2022 17:19:17 Lorenzo Pieralisi wrote: > > > > > On Wed, Jan 12, 2022 at 04:18:13PM +0100, Pali Roh=E1r wrote: > > > > > > This adds support for legacy INTx interrupts received from othe= r PCIe > > > > > > devices and which are reported by a new INTx irq chip. > > > > > > = > > > > > > With this change, kernel can distinguish between INTA, INTB, IN= TC and INTD > > > > > > interrupts. > > > > > > = > > > > > > Note that for this support, device tree files has to be properl= y adjusted > > > > > > to provide "interrupts" or "interrupts-extended" property with = intx > > > > > > interrupt source, "interrupt-names" property with "intx" string= and also > > > > > > 'interrupt-controller' subnode must be defined. > > > > > > = > > > > > > If device tree files do not provide these nodes then driver wou= ld work as > > > > > > before. > > > > > = > > > > > Nit: this information is not useful. DT rules are written in DT > > > > > bindings, not in kernel commit logs. All I am saying is that firm= ware > > > > > developers should not have to read this log to write firmware. > > > > = > > > > It was not intended for firmware developers, but for reviewers of t= his > > > > patch to understand, what is happening in code and that with old DT > > > > files this patch does not change driver behavior (=3D work as befor= e). > > > > = > > > > > > Signed-off-by: Pali Roh=E1r > > > > > > --- > > > > > > drivers/pci/controller/pci-mvebu.c | 185 +++++++++++++++++++++= ++++++-- > > > > > > 1 file changed, 177 insertions(+), 8 deletions(-) > > > > > > = > > > > > > diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/c= ontroller/pci-mvebu.c > > > > > > index 1e90ab888075..dbb6ecb4cb70 100644 > > > > > > --- a/drivers/pci/controller/pci-mvebu.c > > > > > > +++ b/drivers/pci/controller/pci-mvebu.c > > > > > > @@ -54,9 +54,10 @@ > > > > > > PCIE_CONF_ADDR_EN) > > > > > > #define PCIE_CONF_DATA_OFF 0x18fc > > > > > > #define PCIE_INT_CAUSE_OFF 0x1900 > > > > > > +#define PCIE_INT_UNMASK_OFF 0x1910 > > > > > = > > > > > Nit: I understand it is tempting but here you are redefining or b= etter > > > > > giving a proper label to a register. Separate patch please. > > > > = > > > > Ok! > > > > = > > > > > > +#define PCIE_INT_INTX(i) BIT(24+i) > > > > > > #define PCIE_INT_PM_PME BIT(28) > > > > > > -#define PCIE_MASK_OFF 0x1910 > > > > > = > > > > > See above. > > > > > = > > > > > > -#define PCIE_MASK_ENABLE_INTS 0x0f000000 > > > > > > +#define PCIE_INT_ALL_MASK GENMASK(31, 0) > > > > > > #define PCIE_CTRL_OFF 0x1a00 > > > > > > #define PCIE_CTRL_X1_MODE 0x0001 > > > > > > #define PCIE_CTRL_RC_MODE BIT(1) > > > > > > @@ -110,6 +111,9 @@ struct mvebu_pcie_port { > > > > > > struct mvebu_pcie_window iowin; > > > > > > u32 saved_pcie_stat; > > > > > > struct resource regs; > > > > > > + struct irq_domain *intx_irq_domain; > > > > > > + raw_spinlock_t irq_lock; > > > > > > + int intx_irq; > > > > > > }; > > > > > > = > > > > > > static inline void mvebu_writel(struct mvebu_pcie_port *port, = u32 val, u32 reg) > > > > > > @@ -235,7 +239,7 @@ static void mvebu_pcie_setup_wins(struct mv= ebu_pcie_port *port) > > > > > > = > > > > > > static void mvebu_pcie_setup_hw(struct mvebu_pcie_port *port) > > > > > > { > > > > > > - u32 ctrl, lnkcap, cmd, dev_rev, mask; > > > > > > + u32 ctrl, lnkcap, cmd, dev_rev, unmask; > > > > > > = > > > > > > /* Setup PCIe controller to Root Complex mode. */ > > > > > > ctrl =3D mvebu_readl(port, PCIE_CTRL_OFF); > > > > > > @@ -288,10 +292,30 @@ static void mvebu_pcie_setup_hw(struct mv= ebu_pcie_port *port) > > > > > > /* Point PCIe unit MBUS decode windows to DRAM space. */ > > > > > > mvebu_pcie_setup_wins(port); > > > > > > = > > > > > > - /* Enable interrupt lines A-D. */ > > > > > > - mask =3D mvebu_readl(port, PCIE_MASK_OFF); > > > > > > - mask |=3D PCIE_MASK_ENABLE_INTS; > > > > > > - mvebu_writel(port, mask, PCIE_MASK_OFF); > > > > > > + /* Mask all interrupt sources. */ > > > > > > + mvebu_writel(port, ~PCIE_INT_ALL_MASK, PCIE_INT_UNMASK_OFF); > > > > > > + > > > > > > + /* Clear all interrupt causes. */ > > > > > > + mvebu_writel(port, ~PCIE_INT_ALL_MASK, PCIE_INT_CAUSE_OFF); > > > > > > + > > > > > > + if (port->intx_irq <=3D 0) { > > > > > > + /* > > > > > > + * When neither "summary" interrupt, nor "intx" interrupt was > > > > > > + * specified in DT then unmask all legacy INTx interrupts as= in > > > > > > + * this case driver does not provide a way for masking and > > > > > > + * unmasking of individual legacy INTx interrupts. In this c= ase > > > > > > + * all interrupts, including legacy INTx are reported via one > > > > > > + * shared GIC source and therefore kernel cannot distinguish > > > > > > + * which individual legacy INTx was triggered. These interru= pts > > > > > > + * are shared, so it should not cause any issue. Just > > > > > > + * performance penalty as every PCIe interrupt handler needs= to > > > > > > + * be called when some interrupt is triggered. > > > > > > + */ > > > > > = > > > > > This comment applies to current mainline right (ie it describes h= ow > > > > > current mainline handles INTx) ? IMO you should split it out in a > > > > > separate patch. > > > > = > > > > This above comment describe what happens in if-branch when intx_irq= is > > > > not set (as written in comment "when intx interrupt was not specifi= ed in > > > > DT"). You are right that this is also the behavior in the current > > > > mainline. > > > > = > > > > I'm not sure if this comment can be split out as support for "intx" > > > > interrupt is in this patch. > > > > = > > > > > I understand it is hard but a patch is a logical _change_, this > > > > > comment is a change per se, it is a clarification on current > > > > > behaviour. > > > > = > > > > Ok, I could try to split this comment into two patches, but part ab= out > > > > if-branch comment needs to stay in "this" patch. > > > = > > > I have done it locally. > > > = > > > Let me know when I should resend this patch series and I will include > > > into it also these changes. > > = > > Hi, > > = > > yes please resend it and I will merge it. > = > Done! > https://lore.kernel.org/linux-pci/20220222104625.28461-1-pali@kernel.org/= T/#u Can you rebase it please on top of my pci/mvebu branch ? https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/ Forgive me, I forgot to mention that, thanks. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel