From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AEB6C433EF for ; Tue, 22 Feb 2022 22:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rgeon/K5Xd39M0DVN5+fmao5zQs4Ac6ROpLpQlgvSbI=; b=qgUTHrigddFkyG n9xVAin8I5rW+Z0aLgui1ctK7P1j2ppHXhFXmQpJhu/zr97/K3/ZdOcA9tWMb8L0BegJQFb4Uj8ql NGGT/zbqi7wo9DMAkib9ATB6E6sEBgzEkaLfLsJ5Eu7toH076Z8kLNy3oE4Zap3EeF6qGu9YujH4d ExbRHn8YahatB86uFci5GvRqDV93+Q4uHjKBXeWBn/FwHE+NDBt91TndTecukoiGe3kK12ZW2PdLj b4VEdlkGHDcT48GFpqQq7dtk340JMQiupZkn0OjuGnZJmyrWLawNWksAUKCAMqBajlm2DeKq7KQZo 1DhMTs9XVzjBmIE5r8Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMdjV-00BnJF-CQ; Tue, 22 Feb 2022 22:34:09 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMdjN-00BnHc-M2; Tue, 22 Feb 2022 22:34:07 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: nfraprado) with ESMTPSA id 07B771F442FC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645569240; bh=bgMJpukKsAN/2biajYD0mGaPqwL63HQC8cQg4u9C94g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O+uQejWktUJuxx1ndtBGCiMmIzqI2aGr5fsrAL9xiQZvod9c3+N1eb1Y7E6MkPHVI YnJri23wDglTuWQIrUjh1XTDWfHgHO8CZ/tn+W38Jz/Jn9I7LJNHo8RRn5WfmmWu9Z 74uMw7c35/26DBzTdU5TLzjX1PYImKCzQ/V4RzHAgXCe9DavaKekAaX9Coflafyeux GIY/oHrt2gTyTkCEuoowdF2bqAzaQW3Ohm06/MfUDruQYkomovnE2M9Wb9ZZ5mkoeI 5RhnttcZA6Io9DSPpENTtcsPOXzS8Yv7t5fUMfTVOacDA7DOYItyoT0HAcp9FVgnTT igFCguYvhIPng== Date: Tue, 22 Feb 2022 17:33:55 -0500 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Allen-KH Cheng Cc: Matthias Brugger , Rob Herring , --to=Krzysztof Kozlowski , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai , Ryder Lee Subject: Re: [PATCH v2 17/23] arm64: dts: mt8192: Add vcodec lat and core nodes Message-ID: <20220222223355.o4o6v7yxozsnkz33@notapiano> References: <20220218091633.9368-1-allen-kh.cheng@mediatek.com> <20220218091633.9368-18-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220218091633.9368-18-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_143401_900796_A9511E5B X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 18, 2022 at 05:16:27PM +0800, Allen-KH Cheng wrote: > Add vcodec lat and core nodes for mt8192 SoC. > > Signed-off-by: Allen-KH Cheng > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58 ++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index 936aa788664f..543a80252ce5 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -1291,6 +1291,64 @@ > power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>; > }; > > + vcodec_dec: vcodec_dec@16000000 { It's usually preferred to use '-' instead of '_' in the node name, like: vcodec_dec: vcodec-dec@16000000 { Same thing for the other vcodec nodes below. But more importantly, the Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml dt-binding shows the mtk-vcodec-lat and mtk-vcodec-core as subnodes of vcodec-dec. So I would follow that same structure here. Unless it does make more sense to have the nodes separate like this, but in that case the dt-binding should be updated. > + compatible = "mediatek,mt8192-vcodec-dec"; > + reg = <0 0x16000000 0 0x1000>; /* VDEC_SYS */ > + mediatek,scp = <&scp>; > + iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>; > + }; > + > + vcodec_lat: vcodec_lat@0x16010000 { Again, please drop the '0x' prefix. > + compatible = "mediatek,mtk-vcodec-lat"; > + reg = <0 0x16010000 0 0x800>; /* VDEC_MISC */ > + interrupts = ; > + iommus = <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD_EXT>, > + <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>, > + <&iommu0 M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>, > + <&iommu0 M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>, > + <&iommu0 M4U_PORT_L5_VDEC_LAT0_TILE_EXT>, > + <&iommu0 M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>, > + <&iommu0 M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>, > + <&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>; > + clocks = <&topckgen CLK_TOP_VDEC_SEL>, > + <&vdecsys_soc CLK_VDEC_SOC_VDEC>, > + <&vdecsys_soc CLK_VDEC_SOC_LAT>, > + <&vdecsys_soc CLK_VDEC_SOC_LARB1>, > + <&topckgen CLK_TOP_MAINPLL_D4>; > + clock-names = "vdec-sel", "vdec-soc-vdec", "vdec-soc-lat", "vdec-vdec", > + "vdec-top"; > + assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>; > + assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>; > + power-domains = <&spm MT8192_POWER_DOMAIN_VDEC>; > + }; > + > + vcodec_core: vcodec_core@0x16025000 { Ditto. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel