From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17292C433F5 for ; Wed, 23 Feb 2022 01:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nCs6joLkCldROvFXdQWGCs5YlFEXWtfUsSZMBs3zi04=; b=RjDrLfvv/9n0LT rFTd1Sp2NR28vRkyBXNPBuskgFUNO5cY7SLgDSBGVrX1t4QVgWWQBbWf6FmfsEUro0m7vykARQBwk /Om5jnthNIwCq8GRmshBBrqbLKqaDAsCxlvRtRifntI/DI2GNcB99ROiuprturcMCIAwa2ojQ8UDH HrtaxsYZqjCIe1Mms6p0g52Jlh1TziyIk3BHKySYtvGfhvasUsloE1nZOc4Ip0FUoZuN/iq1lXHst hb1QuWjPRtQjfWWz5Ej1G+ABJcnfx3ndo4TmUYoAibPr0x+g9626RWn5Xli//edRgxTNo5JEIv7We 2+9KWiBeoDRJsb6J0L7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMgFl-00C5L4-Ed; Wed, 23 Feb 2022 01:15:37 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMgEu-00C4uD-Cs for linux-arm-kernel@lists.infradead.org; Wed, 23 Feb 2022 01:14:46 +0000 Received: by mail-ed1-x532.google.com with SMTP id x5so41097452edd.11 for ; Tue, 22 Feb 2022 17:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DNij7dJZj5zCpqmuUWdIbA82PPs/8sAPmCNMapkES6s=; b=XNspZZ4driA4cb2FKagm4/dWDOnodKxf+OlobbFuUf8VqQkTUrI4L+94mfIP+VU5lS omlhFibWic8kSV97vsaLuQs/u0HoESkoOrDFKA9ipYeYB22OExU6AEswJ1FRgW5r+nYW 1n1HgpWnoPj2VblVKVuPMFn6SjEanltt9efvK7zczVo87/IHGED+Y01JDdO63DJfIBTu 4paJX+NOPmwk2OXHNradQ5SEVcaDuUZLbIYGpk6lPW0+kGhJtn7SfuwwKAm2Qecgwi4s Zx5W5K0IQkKAVVZGC8uGWEtcLrUzGo7c0l81pl4ZTUxoEbpqZluGwGbcgxH1cGKmgB35 E5sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DNij7dJZj5zCpqmuUWdIbA82PPs/8sAPmCNMapkES6s=; b=MNSg0Bi+A1snw8jVChL1RO123KwyYkMr4989TYY75jyc+eCofElCop4G6//xd+lYju XojFH2MhVwtvRLlS4yNqBVkqXQnDHO20JRRlgRq35C2Gzxg58JJcH4TXKKbd91IL9Fp1 77F3TyiFUjQTWAs+vIusBMIhCKct/OHhAa+UJLrvL88bq6kuWPYWOL0UB0Q7w9G38WFb pTY+cGUqlmqYxCedaxUOhiarM38d1TZ8FN/6gKgeCkTvgSkGYToOoteL99r+K+RmgN6g eefPgRs9B9QOUPwIP7R7fMCLeC8muOHMXk1pNv/MbD3JPyxPFBP5B2IlaH1mguyGXuM9 V0og== X-Gm-Message-State: AOAM530OtMplPG6gMoSNL+0ikCjrPeRRIPcyeRcyrzD2/SkmCwUwASTa esdsT95JXMMIptQLba0vUfCPkw== X-Google-Smtp-Source: ABdhPJzFf7MKIat98fe1ra0oh3XxS6M4SiPYcL3oOvRcS3tqDQFQR0ugtEpr0i1sUZvufrEyRCc+gA== X-Received: by 2002:a05:6402:278f:b0:410:d242:465e with SMTP id b15-20020a056402278f00b00410d242465emr29984419ede.292.1645578882145; Tue, 22 Feb 2022 17:14:42 -0800 (PST) Received: from leoy-ThinkPad-X240s ([104.245.96.223]) by smtp.gmail.com with ESMTPSA id n25sm10775059eds.89.2022.02.22.17.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 17:14:41 -0800 (PST) Date: Wed, 23 Feb 2022 09:14:36 +0800 From: Leo Yan To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] perf arm-spe: Use advertised caps/min_interval as default sample_period Message-ID: <20220223011436.GA414932@leoy-ThinkPad-X240s> References: <20220221171042.58460-1-german.gomez@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220221171042.58460-1-german.gomez@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220222_171444_486855_6AC8AB03 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 21, 2022 at 05:10:42PM +0000, German Gomez wrote: > When recording SPE traces, the default sample_period is currently being > set to 1 in the perf_event_attr fields, instead of the value advertised > in '/sys/devices/arm_spe_0/caps/min_interval': > > Before: > > $ perf record -e arm_spe// -vv -- sleep 1 > [...] > { sample_period, sample_freq } 1 > [...] > > Use the value from the above sysfs location as a more sensible default > (it was already being read, but the value not being used) > > After: > > $ perf record -e arm_spe// -vv -- sleep 1 > [...] > { sample_period, sample_freq } 1024 > [...] > > Signed-off-by: German Gomez The change looks good to me: Reviewed-by: Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel