From: Bjorn Helgaas <helgaas@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org,
lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
festevam@gmail.com, francesco.dolcini@toradex.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH v7 6/8] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback
Date: Wed, 23 Feb 2022 11:49:40 -0600 [thread overview]
Message-ID: <20220223174940.GA140379@bhelgaas> (raw)
In-Reply-To: <1644992463-14467-7-git-send-email-hongxing.zhu@nxp.com>
On Wed, Feb 16, 2022 at 02:21:01PM +0800, Richard Zhu wrote:
> When link is never came up in the link training after host_init.
> The clocks and power supplies usage counter balance should be handled
> properly on some DWC platforms (for example, i.MX PCIe).
>
> Add a new host_exit() callback into dw_pcie_host_ops, then it could be
> invoked to handle the unbalance issue in the error handling after
> host_init() function when link is down.
Possible rewording, not sure if it captures everything you want:
When the link never comes up after ->host_init(), some drivers,
especially those that don't support hotplug, want to turn off clocks
and power supplies.
Add a new ->host_exit() callback in dw_pcie_host_ops so these
drivers can clean up if ->host_init() fails.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-23 17:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 6:20 [PATCH v7 0/8] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu
2022-02-16 6:20 ` [PATCH v7 1/8] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2022-02-16 6:20 ` [PATCH v7 2/8] PCI: imx6: Add the error propagation from host_init Richard Zhu
2022-02-16 6:20 ` [PATCH v7 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier Richard Zhu
2022-02-16 6:20 ` [PATCH v7 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable PCIe clocks Richard Zhu
2022-02-16 6:21 ` [PATCH v7 5/8] PCI: imx6: Refine the regulator usage Richard Zhu
2022-02-16 6:21 ` [PATCH v7 6/8] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback Richard Zhu
2022-02-23 17:49 ` Bjorn Helgaas [this message]
2022-02-24 7:50 ` Hongxing Zhu
2022-02-16 6:21 ` [PATCH v7 7/8] PCI: imx6: Disable enabled clocks and regulators after link is down Richard Zhu
2022-02-23 17:50 ` Bjorn Helgaas
2022-02-24 7:51 ` Hongxing Zhu
2022-02-16 6:21 ` [PATCH v7 8/8] PCI: imx6: Add the compliance tests mode support Richard Zhu
2022-02-23 17:40 ` Bjorn Helgaas
2022-02-24 7:50 ` Hongxing Zhu
2022-02-24 23:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223174940.GA140379@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).