From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8ECCFC433F5 for ; Thu, 24 Feb 2022 17:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f+tRiepFOHhX9cu9AR7P8nViJXT7DROS1oKybY/PxwY=; b=A0OFIG2EveXze/ CVhiXHykKjCJnp2IA3l1zu2vQLvPl904Khdu8D+KB5G+5ctD5Z01skxTVd+zztHtjTlA5LxwNxlmO 3p2guWoBNFXaxiKwd1mNFNGxAoafkX/WoyeaYeqUjXe8M1AfX+kR0Cq74i0fbRcLymoI41rg634vP 14LVrPJuHlKAyAmkTEoOVrAKT8wJ4KCiVAyybjLVek83A6WKMvuP3FzF1jIQEu33aWrY3BJH+abRj O88xfQfoL2C2Da7Kak3vXX/2Ozs1k+F/ssRSMzqVompsBNFvgtNoqSVVre2JJEii4LfOhkUp11/Tg gFfRVu2Zjv18vzYCwuSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNHoH-001lLZ-A3; Thu, 24 Feb 2022 17:21:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNHoD-001lKW-NT for linux-arm-kernel@lists.infradead.org; Thu, 24 Feb 2022 17:21:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 731C461BA6; Thu, 24 Feb 2022 17:21:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6B3EC340E9; Thu, 24 Feb 2022 17:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645723299; bh=0DvAwOYRhr/x4Z8RjLyIHitIvW2rgVY4my4bYOvYKUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ntSSReLMHcbBQHUBMTCYVDrzvSSn44hsBQFxzZlidhq70sQM38Wvcplme2LvGsIRa roiZ0BAY9FN0HD8IgE7vg33Zn1Xx27d0LAPB6O7/MCciZwV6//sFNfhd11+9WIxSq5 20cU4ISuaEkKa3uvT9i2NMZuv3fFO/RhT3noL5SOD/ziQ3sgzYJ7UDZ4Cbq1Oovq1O 4nAxdYdg8WbPgKXukTmia8wiAG61cow+/s0wdUY0+SfPnJ5P/WJCHw9/yUpXu0mUtD /B7TlcXRXPNk8I86aKsxZnNxOD91XYfKNR6C3uom8rzSOVNf72J2ZY6icllEYsEOMy y6PCXihbPSLfg== Received: by pali.im (Postfix) id A5BEAB6E; Thu, 24 Feb 2022 18:21:36 +0100 (CET) Date: Thu, 24 Feb 2022 18:21:36 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Marcel Menzel , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: Kernel 5.16.3 and above fails to detect PCIe devices on Turris Omnia (Armada 385 / mvebu) Message-ID: <20220224172136.ydx4wu7avmfq4ndt@pali> References: <20220224162532.GA274119@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220224162532.GA274119@bhelgaas> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220224_092141_827488_F066D241 X-CRM114-Status: GOOD ( 26.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 24 February 2022 10:25:32 Bjorn Helgaas wrote: > On Thu, Feb 24, 2022 at 05:00:30PM +0100, Marcel Menzel wrote: > > +linux-pci > > > > Am 24.02.2022 um 14:52 schrieb Marcel Menzel: > > > Am 24.02.2022 um 14:09 schrieb Marcel Menzel: > > > > Hello, > > > > > > > > When upgrading from kernel 5.16.2 to a newer version (tried 5.16.3 > > > > and 5.16.10 with unchanged .config), the Kernel fails to detect both > > > > my installed mPCIe WiFi cards in my Turris Omnia (newer version, > > > > silver case, GPIO pins installed again). > > > > I have two Mediatek MT7915 based cards installed. I also tried with > > > > one Atheros at9k and one ath10k based card, yielding the same > > > > result. On a Kernel version newer than 5.16.2, all cards aren't > > > > getting recognized correctly. > > > > > > > > Before 5.16.3 I also had to disable PCIe ASPM via boot aragument, > > > > otherwise the WiFi drivers would complain about weird device > > > > behaviors and failing to initialize them, but re-enabling it does > > > > not yield any different results. > > Please try this commit, which is headed to mainline today: > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=for-linus&id=c49ae619905eebd3f54598a84e4cd2bd58ba8fe9 > > This commit should fix the PCI enumeration problem. It should fix that regression. If not, please let me know. > If you still have > to disable ASPM, that sounds like a separate problem that we should > also try to debug. This is different and known issue and **not** related to ASPM. I spend some time on it, initially I thought it is bug in Atheros cards, but now I'm in impression that this is issue in Marvell PCIe HW that link retraining (required step of ASPM) triggers either Link Down or Hot Reset which triggers another Atheros issue (this one is already documented in kernel pci quirks code). I will try to implement some workaround for this but requirement is to have all new improvements in pci-mvebu.c + pci-aardvark.c drivers... and review process is slow. So it would not be before all those changes are reviewed and merged. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel