Re: [PATCH v4 11/12] PCI: mvebu: Implement support for legacy INTx interrupts

Bjorn Helgaas
2022-02-25T00:28:25Z

On Tue, Feb 22, 2022 at 04:50:29PM +0100, Pali Rohár wrote:
> This adds support for legacy INTx interrupts received from other PCIe
> devices and which are reported by a new INTx irq chip.
> ...

> + port->intx_irq_domain = irq_domain_add_linear(pcie_intc_node, PCI_NUM_INTX,
> + &mvebu_pcie_intx_irq_domain_ops,
> + port);

Already merged, so no need to change this, but in the future, can you
wrap to fit in 80 columns like the rest of the file?

> + if (port->intx_irq <= 0) {
> + dev_warn(dev, "%s: legacy INTx interrupts cannot be masked individually, "
> + "%pOF does not contain intx interrupt\n",

This is one exception: generally I think quoted strings, especially in
log messages users might see, should be joined no matter how long it
makes the line so they are easier to grep for.