From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A66C433F5 for ; Fri, 25 Feb 2022 00:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=dgte6HsB+qEHVLXwxkOsQ3aQP0nXQ5zBvWXmLWObTEk=; b=zcf12gQqyWl175 eGjp69b6DJjtuOHy7nsGJTKiYdOOWi00ryz8QuNfdWgxpsYXvKcKQnHv6d7SLb7qKI6QjfBBzG+Bo 97Tz+o+Y9/VNiomgsB/zYWsFl69kIXVsPwNBa4Rfzqt/DzlbNB3Nk5JrMb4InvYBw3hw5SJswFxe6 70nFz0lP2ptN02pQsoUxhjAqh3WBLtpAwCPaml/ojccW7TGrNZAYdZMU6x16oKyFh7FgxiSMmMARx 12zuyEXZIi2kYUCScCG9gzf8iac9ciu1dJPHs+gcjxFx8FcxF8AZC5qxG7BidEkPNlbQ35YsdVW2O x8SbCB0eohYWrjeJKN9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNORe-002mff-9G; Fri, 25 Feb 2022 00:26:50 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNORa-002meg-OT for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 00:26:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 44FA0B82A29; Fri, 25 Feb 2022 00:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7D3EC340EF; Fri, 25 Feb 2022 00:26:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645748804; bh=Kd4X7W9ZMN0FCx1p2jz2OwD19f/vEq5w2Uk3RbeSIZw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=OqjZy/1BoP++iTIAtMdnU3jNB/b/urH3EPCTmgtJI9oGnZ7s2QKZPbcpUBPLQd4BI SiTh9LV8apNFtMn0b4LL8GP42UcfGTWYBudEY7O199HUXBUVPzvwk61+4SyhNm29SF B6ivsljK7DaXwPgFSvm4B5ZhRjLNOiU7hC4k25IUFjesc1bDXONGcGGKUGrYe63YZy dX0i3vZAC3l2wZ1CehmPOlAi+tA9/pVrMObBqick/+9Je9mrtvSRQ77gLbsE6EHkGq rAAoPhZCcKWW6147nm53oITZgHwKnK6GV/zJO3KLRT19yZXOuF7dEaDdgJyn2jLpvp xyfF6NrYsna+Q== Date: Thu, 24 Feb 2022 18:26:42 -0600 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Lorenzo Pieralisi , Bjorn Helgaas , Rob Herring , Thomas Petazzoni , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Russell King , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 11/12] PCI: mvebu: Implement support for legacy INTx interrupts Message-ID: <20220225002642.GA306717@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220222155030.988-12-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220224_162647_003126_CD75635C X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 22, 2022 at 04:50:29PM +0100, Pali Roh=E1r wrote: > This adds support for legacy INTx interrupts received from other PCIe > devices and which are reported by a new INTx irq chip. > ... > + port->intx_irq_domain =3D irq_domain_add_linear(pcie_intc_node, PCI_NUM= _INTX, > + &mvebu_pcie_intx_irq_domain_ops, > + port); Already merged, so no need to change this, but in the future, can you wrap to fit in 80 columns like the rest of the file? > + if (port->intx_irq <=3D 0) { > + dev_warn(dev, "%s: legacy INTx interrupts cannot be masked individuall= y, " > + "%pOF does not contain intx interrupt\n", This is one exception: generally I think quoted strings, especially in log messages users might see, should be joined no matter how long it makes the line so they are easier to grep for. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel