From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 193A2C433F5 for ; Fri, 25 Feb 2022 14:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=thr5BAX14Ro2BxCDGQQb64TAlXHDcbDasAX0G9MvNaY=; b=Ez/WbSvypl0kqs 6xES+tOdsc4n3dlsTyz9+vx5f952SCtnDEavXCWZ4zuXivSZZaWYzmjuoByEtKMmjEzQVlD1lI2Pb zuQkhuIS8bd6zg0lG07GhqUV2WsKB9l0hhH96f/HRxclNidZsOHdh4P2D4UmtM8m1i9GOOjaDCtZ5 sygr1DonNPqdbCMPwoSZG5CV25T6JWz/cmj1RwqOgDmLkEwzxeVywUhbYzwCOiCLJ2XiqDeUbTrSX G2x6GzbAM1idWRbohAqGpzT1F7+8gcyVU9/QsBawB84UpfEYd+T8VD2HQLBjQPygA/Lw8hrSQQve5 QeuuhfBqsVmpgvhECOIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNbTs-005NfY-Ru; Fri, 25 Feb 2022 14:22:02 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNbTk-005Ndr-Qt for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 14:21:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F2B0B831F6; Fri, 25 Feb 2022 14:21:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B325CC340E7; Fri, 25 Feb 2022 14:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645798910; bh=GsKnvQuVfFXBuBcqOhKDdBQYq6SipytMCBoHQSMMKdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P46SA6U/tNDYg97yWrJX3GCeKLUS/KBF07QH9U+7a2ApyXo4+jA4rfl5cob7VNTlz T54DjyQEGc4FT/CtzEfQx5YCDV6b4n3/LhpKkI+fMtXetcHTdjj60C1Fk3rsx3cXNK INqUvuGcQR9t3LWCovbVyD/jArJKfFmtShBvRkGI57gdMaLbUl9tI8gl+CuQy0iqIX aX/9Rsg7WuXLVak76fnJ+GRqLN0pwgwGuQIrLkk0ziTPhI3g3aQ4+V4wjAXHRuYLAL qRJqP7UEPY39/mTCy6nVW0apb8mh5sx4s4qiQDXkI+ibqVygyKSo01w1tiUM4o1GW4 opmGEgxOl+kDQ== Date: Fri, 25 Feb 2022 14:21:44 +0000 From: Will Deacon To: Joey Gouly Cc: Robin Murphy , "Russell King (Oracle)" , linux-arm-kernel@lists.infradead.org, nd@arm.com, catalin.marinas@arm.com, mark.rutland@arm.com Subject: Re: [PATCH v1 1/3] arm64: lib: Import latest version of Arm Optimized Routines' strcmp Message-ID: <20220225142144.GC19698@willie-the-truck> References: <20220215170723.21266-1-joey.gouly@arm.com> <20220215170723.21266-2-joey.gouly@arm.com> <626c6da4-547e-aa3e-3968-907e69e061d0@arm.com> <20220217102309.GA27144@e124191.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220217102309.GA27144@e124191.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_062153_235253_D5A10482 X-CRM114-Status: GOOD ( 33.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 17, 2022 at 10:23:09AM +0000, Joey Gouly wrote: > On Wed, Feb 16, 2022 at 06:36:12PM +0000, Robin Murphy wrote: > > On 2022-02-16 16:44, Russell King (Oracle) wrote: > > > On Tue, Feb 15, 2022 at 05:07:21PM +0000, Joey Gouly wrote: > > > > Import the latest version of the Arm Optimized Routines strcmp function based > > > > on the upstream code of string/aarch64/strcmp.S at commit 189dfefe37d5 from: > > > > https://github.com/ARM-software/optimized-routines > > > > > > > > This latest version includes MTE support. > > > > > > > > Signed-off-by: Joey Gouly > > > > Cc: Robin Murphy > > > > Cc: Mark Rutland > > > > Cc: Catalin Marinas > > > > Cc: Will Deacon > > > > --- > > > > arch/arm64/lib/strcmp.S | 238 +++++++++++++++++++++------------------- > > > > 1 file changed, 126 insertions(+), 112 deletions(-) > > > > > > > > diff --git a/arch/arm64/lib/strcmp.S b/arch/arm64/lib/strcmp.S > > > > index 83bcad72ec97..758de77afd2f 100644 > > > > --- a/arch/arm64/lib/strcmp.S > > > > +++ b/arch/arm64/lib/strcmp.S > > > > @@ -1,9 +1,9 @@ > > > > /* SPDX-License-Identifier: GPL-2.0-only */ > > > > > > Looking at the LICENSE file in the above repository, it appears that > > > this code is licensed as "MIT OR Apache-2.0 WITH LLVM-exception". > > > Shouldn't the SPDX line be updated to reflect the origin license of > > > this code? > > > > This is noted in the commits which first imported implementations from Arm > > Optimized Routines (020b199bc70d and earlier): > > > > "Note that for simplicity Arm have chosen to contribute this code > > to Linux under GPLv2 rather than the original MIT license." > > > > Apologies for the confusion - I should have mentioned that to Joey > > beforehand, if I hadn't completely forgotten about it. I think it's just > > been implicit that we'd continue to follow the same approach going forward. > > > > Yes, I didn't mention it because I was just being implicit. > > I've added a note about it in the commit message, and will send out a v2 after > deciding what we should do about the conflict with > https://lore.kernel.org/linux-arm-kernel/20220216162229.1076788-1-mark.rutland@arm.com/ > (since I may have to rebase the patches onto a different base). Please just send a new version based on -rc3 and we can figure out the conflicts when I merge it together. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel