From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA2C8C433F5 for ; Fri, 25 Feb 2022 18:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=SP/PC766OPpZhC4AfcNYMQYr0x7Iph5i7zSyGW05Qb4=; b=oFuoQr96xtJ1AX CoSmXFJyi1JtKsRpaMSfiAWh8FE7QffzzshZLciTiXPSgh91lFWaEu+H84lT3PWKtJ9BgOHfwG9EZ SbMZw6EXxF3fV2I2y4uXtBVFPBkCdMeL2Y0lAhJv/zeU+ezygfa77F0/FSKGIemwVaupqN5eY+hZ2 49FePWElbfz93w5Kvf5hYZ1X3JPfGNO0xMl0B4RJ3pVTgNOVOlV7Nkkt38z20HFvDN02lZPN4tHWg W5pwDJdPdjhcmnB7W0f9bIrRK5+1BU8p6PBAl4b8vHfY6DLv5X0wu8I5fekgrzSXGusbIqSgMunqV QekwyluJ68pnwj1+lN7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNfAg-006XVP-Ea; Fri, 25 Feb 2022 18:18:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNekM-006Me3-Dy for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 17:51:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D48D561DF9; Fri, 25 Feb 2022 17:51:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E26CBC340E7; Fri, 25 Feb 2022 17:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645811473; bh=4OGwXvj6qG40FpaSoNd3Q08HMEjHMoeogTnv4EWa8cg=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ILebw+DPu/ytkCQwojobeXNB8JX0usxgEWR0mD61kJ1R+PoCCL1Tw5MULyNKQzLyX g+agQx4t1UaZhZ6KQ2MFvVIVrH9dAzIDGQjdRxdHeAJ+rRFZszmOQeSq9DBlK8aEVq KEin/IhXQe1qwzCSGjeB4eN/2DATuH801k1+LJo0brl5DIUBXQ5Dj/g4b4MLmJTRhH 1Gbf1nE3/YZzIbx83UY01nQbm28MNJK0W+IBYjm6dvtI6K65V4w7cKtJFKufEiJWIu OQNN1V6GIhVbX02eL++cq8SEQoP9D86aH2/9MPqi/8RnGSrEpoqGiSyZ8TzSo65/DU s4pSYD9Ex+hgQ== Date: Fri, 25 Feb 2022 11:51:11 -0600 From: Bjorn Helgaas To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Lorenzo Pieralisi , Bjorn Helgaas , Rob Herring , Andrew Lunn , Thomas Petazzoni , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Russell King , Gregory Clement , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros Message-ID: <20220225175111.GA367168@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220225182216.2fcf5455@thinkpad> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_095114_550108_C0D34DB0 X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 25, 2022 at 06:22:16PM +0100, Marek Beh=FAn wrote: > On Fri, 25 Feb 2022 09:37:56 -0600 > Bjorn Helgaas wrote: > > Yes, it's a mix. For some recent additions, I've resisted adding the > > _SHIFT macros on the theory that they clutter the file, they never > > change, and the main point of the #defines is readability and so > > grep/tags/etc can find things. > > = > > There are a *few* users of FIELD_PREP() and FIELD_GET(): > > = > > git grep -E "FIELD_(GET|PREP)\(PCI_EXP" > > = > > and I'm inclined to go that direction in the future. What do you > > think? > = > I am also pro that direction. > = > Would you also like to convert current usages in the .c driver files? > = > We can't remove the existing macros since they are in UAPI, but we can > convert drivers so that they don't use _SHIFT macros. Certainly not a high priority, but it actually looks like there aren't *that* many uses in drivers/pci/, so I'd be OK with converting them. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel