From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B0E3C433F5 for ; Sat, 26 Feb 2022 10:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bJS87wQ6fvJsqqQMw8deOIl5MNDHfGQjQwMLNajn6lA=; b=MCKXdpKLTk3bNJ YHaZRQ3WF6W4j1PCdInuLUPk8b57tLQ3piN66lqe63i+I/QfeFd2FnxdBJNCR8IXsurXfwH9dSOKj lGtlBkuWd4MDTVD4Dz8UTmRS3oJQVBiU95vSIdh8bSoA6jYxLEW0nP8EAsCIN3VlljKqFIXAGBUkt lOpn5e6YC9yNeg4KjjLW28l1CTrWHQyx4erhPJv+a3AssUg/wb11m2OMzooSJmLYtmm+l+FTJtP3/ G9z4fDQ20bJj0AeKgo4p7nbSP3bJVsAURnxk7LFXylNp6RYbXkMW8MngCKNVbyR7kqR5Ns4rvoNnM ejvyGdvrEu938ezu0IoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNtwp-007qvF-0m; Sat, 26 Feb 2022 10:05:07 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNtwj-007qtg-Op; Sat, 26 Feb 2022 10:05:04 +0000 X-UUID: 2b13d9e1cd8d49c7b0da699bbda8fd46-20220226 X-UUID: 2b13d9e1cd8d49c7b0da699bbda8fd46-20220226 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1877961646; Sat, 26 Feb 2022 03:04:55 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 26 Feb 2022 01:54:54 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 26 Feb 2022 17:54:52 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 26 Feb 2022 17:54:52 +0800 From: Lecopzer Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 2/5] kernel/watchdog: change watchdog_nmi_enable() to void Date: Sat, 26 Feb 2022 17:54:52 +0800 Message-ID: <20220226095452.16924-1-lecopzer.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: References: MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220226_020501_843064_D6080560 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Sat 2022-02-12 18:43:46, Lecopzer Chen wrote: > > > > Nobody cares about the return value of watchdog_nmi_enable(), > > changing its prototype to void. > > > > --- a/arch/sparc/kernel/nmi.c > > +++ b/arch/sparc/kernel/nmi.c > > @@ -282,11 +282,11 @@ __setup("nmi_watchdog=", setup_nmi_watchdog); > > * sparc specific NMI watchdog enable function. > > * Enables watchdog if it is not enabled already. > > */ > > -int watchdog_nmi_enable(unsigned int cpu) > > +void watchdog_nmi_enable(unsigned int cpu) > > { > > if (atomic_read(&nmi_active) == -1) { > > pr_warn("NMI watchdog cannot be enabled or disabled\n"); > > - return -1; > > + return; > > } > > > > /* > > @@ -295,11 +295,11 @@ int watchdog_nmi_enable(unsigned int cpu) > > * process first. > > */ > > if (!nmi_init_done) > > - return 0; > > + return; > > > > smp_call_function_single(cpu, start_nmi_watchdog, NULL, 1); > > > > - return 0; > > + return; > > Return at the end of the function is superfluous. Thanks, I'll fix in the next patch. > > > } > > /* > > * sparc specific NMI watchdog disable function. > > Otherwise, it looks good. > > Reviewed-by: Petr Mladek > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel