From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A6EAC433F5 for ; Sat, 26 Feb 2022 16:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4hT/aacIgB5y4+K5V0rXIJPRKI9w7PPhGU0HklFqglQ=; b=1CHbf7axB2A0Cf VTHdF0ngemJKlI/ojlEtgzDI69/0EtSEdIuInZ32q2y4b3a0i4Pp2k0UyO5BfMwrfu7zRakj1QENc n0nlKs5Niu+rgJrkaJN67OQvkRJDVBibywydHwkyCj8QsuoOC6ocYLnajfsYCKkM5a5ny3qv4zKA3 0LkzCX+BMRbVnzrW5F8/YgftmAck1osRZz/JrBL473Bx5EsKvvEkPDTFSC3guhpFSPHc6tVb6iHQG BrMXjI5gCe+fujyQ8xWQRSPz3h9Bb51jSVapdvska34UE1SSgU/jINOAWlvzvVXXbdB4hvyb92W4q dK+DelQq19i/zERkWtmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO03C-008FMZ-Js; Sat, 26 Feb 2022 16:36:06 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO038-008FM2-F6 for linux-arm-kernel@lists.infradead.org; Sat, 26 Feb 2022 16:36:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 406A16091B; Sat, 26 Feb 2022 16:36:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F649C340E8; Sat, 26 Feb 2022 16:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645893360; bh=xX8VmDztp3N0GoPaZtIyUGbJBpyw5EhUWfj6kUcQHCc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HR9lfhyI+fHAOfKgfe05UMA/jXHbf9+uZhq595RCkVcX2s0qFxVwi1STNsa5T6+7s oZURCoGXOraYw3UPCridA37xCmIWnbIjMxIHx7OIx/Asb11+gS9mR+i9459ey1S2lI 4glj1gPAul4lWU6WYSqpPPaLit3AhAFDb5HrP0+R0SH1oPRqoa2hkOJBPmZE+PSX6r mfiEtaQotW3aHoj90xMnxT96lX3f6cLtJ3NKhmMYCWUrln5UMYI9/MlHgl5rvmG/Lj ur7/lhQlbd2Z/9pIE/A0PJ1PLDK0rP0SYvtxlhIdU5tHUqWMNFJnu+W3iVL4ZoqtcS othBeSDGXJzKQ== Date: Sat, 26 Feb 2022 16:43:00 +0000 From: Jonathan Cameron To: Michal Simek Cc: Christophe JAILLET , Anand Ashok Dumbre , Lars-Peter Clausen , Michal Simek , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] iio: adc: xilinx-ams: Use devm_delayed_work_autocancel() to simplify code Message-ID: <20220226164300.63b31841@jic23-huawei> In-Reply-To: References: <2626e6a057e40cd2271ef0e5f81d12e607bad5b4.1644776929.git.christophe.jaillet@wanadoo.fr> <20220220114552.53fedd33@jic23-huawei> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220226_083602_599558_AFDDE549 X-CRM114-Status: GOOD ( 17.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 21 Feb 2022 11:02:00 +0100 Michal Simek wrote: > Hi, > > On 2/20/22 12:45, Jonathan Cameron wrote: > > On Sun, 13 Feb 2022 19:29:05 +0100 > > Christophe JAILLET wrote: > > > >> Use devm_delayed_work_autocancel() instead of hand writing it. This is > >> less verbose and saves a few lines of code. > >> > >> devm_delayed_work_autocancel() uses devm_add_action() instead of > >> devm_add_action_or_reset(). This is fine, because if the underlying memory > >> allocation fails, no work has been scheduled yet. So there is nothing to > >> undo. > >> > >> Signed-off-by: Christophe JAILLET > > Looks good to me, but I'd ideally like some input from someone familiar with > > the driver. > > Anand told me that the change is fine that's why here is my > Acked-by: Michal Simek > > Jonathan: Anand decided to do change in his carrier that's why that emails won't > go through. But I am still around if you need something xilinx/amd to test. > > Thanks, > Michal Thanks Michal and best wishes to Anand for whatever comes next! Applied to the togreg branch of iio.git and pushed out as testing for 0-day to take a quick look before I expose this to linux-next. Thanks, Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel