From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2E8FC433EF for ; Sun, 27 Feb 2022 14:00:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mv8D7kBYFg3LfmAz74HmF1Y2975Fv7nYWmDEHaj5j4s=; b=1HAxFZ1sri5Koh t/yhvr4eUAIZuze9gydPyMBIdUpk+EdDSPxM7ha+MMbSyeEw6UE2l2r8WZlF6FtdW0LqqfpJU8XWe eIvElvgjLrSjxYP6r7r2JgyTynGO1C/Uut3XrTPv1dX9OcD5Ss7USP6qW979Qkl50t7jelek6Yax4 DJL1fCiaCbPI4ETjf3f3Efz9bTNUv447AkMl9X6kxSIixjr71CrMMjSFiCjzSjLNCCutIeeUAkE05 Bo7SwYgLL2JhLi/h31ElzXosAorVZUAZOLxljGryrAZ9Ucy7cu8zJCDJLkTSACHvVlZNwyfi8ywPP B0ILUF21zhXuWf1kRi9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOK4t-009KId-Bc; Sun, 27 Feb 2022 13:59:13 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOK0l-009Iew-Hu for linux-arm-kernel@lists.infradead.org; Sun, 27 Feb 2022 13:54:58 +0000 Received: by mail-pg1-x535.google.com with SMTP id 195so9205604pgc.6 for ; Sun, 27 Feb 2022 05:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R5/L3FvnnktNyA34E6kruOzfisqAyzhCs9ooPGmemyU=; b=uuLL8S0E+zI20jKmcmApZ8T7BLy1ekrigcJchDezUrX58/hAEEwRWtQ8ixFg6WwbZF 9Vfe4zkxPKtl6nk75f0qx6s/j4iSpeEI1ioAlj894Gh9jhhSfIwSMw/nYiZz5FpK3mK8 yDqfKHXZuAV686mDbZNgIlvd2AaCcUgsyuwTbyPHLrRORL5h7yaCtg0M5cf+aon/8Yi2 Ho29Y3QLIBQMpe5QW2akghgcYyDEwaubjGYraXpVw+qH+UnYondbitbR0ltIkaAhlDHZ 6VwTPUxe15KRvxs+sPtwHLiGLBPLIMLxxe8indN6XxMJ8sYHw8ZA7HKBU57VUGRnQpso 0j+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R5/L3FvnnktNyA34E6kruOzfisqAyzhCs9ooPGmemyU=; b=3m6Kswjtqr9YNsGO7/BH9sn3N4COHG/o00irJph3h/Tu4XcJD5jFEH4QDDhdDx98th xA7SVu7Ml5X/Uau7D49U11wMJgCcDZd2bw+cwsmbfUdUjR+DK8Udlk8aFqQRo126mD8T I2L4izhc1iiNlu4hlfUAkzMCvHhwN+2JP/G//V9B6OBIoymclODZuFn0H3hZljZK9jV/ CTT7DdXed3d6qn3M7C4ko+3KINU3K5jWzWRrHXVdH8nhhW9TFoC3upt/jtDmAdag9jUu UGvsdvF6LXecjGMB4XMlCADBEa54tVHQLaUbmEQnZnWkIGmoJo1yfAbn00Lu1/3HlGgE 1pMg== X-Gm-Message-State: AOAM530spFO4OLQoc/GuhHJdTWdbH27TIF9J+4gbhM68k4rBQ5NQykLK yWLt7+QYz0K971Z9mhRPeNotIA== X-Google-Smtp-Source: ABdhPJw1trEejf2Gp3RfzHniQF58pqnIWCn0DG0TdWVAUuroABa8H5/f51okcOdZQvFbGHfkKnpNhw== X-Received: by 2002:a63:3111:0:b0:373:a1fa:8998 with SMTP id x17-20020a633111000000b00373a1fa8998mr13312669pgx.415.1645970094678; Sun, 27 Feb 2022 05:54:54 -0800 (PST) Received: from leoy-ThinkPad-X240s ([204.124.180.219]) by smtp.gmail.com with ESMTPSA id v14-20020a056a00148e00b004e1cee6f6b4sm10221833pfu.47.2022.02.27.05.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Feb 2022 05:54:54 -0800 (PST) Date: Sun, 27 Feb 2022 21:54:44 +0800 From: Leo Yan To: Ali Saidi Cc: german.gomez@arm.com, acme@kernel.org, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, benh@kernel.crashing.org, james.clark@arm.com, john.garry@huawei.com, jolsa@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH 2/2] perf arm-spe: Parse more SPE fields and store source Message-ID: <20220227135444.GB107053@leoy-ThinkPad-X240s> References: <9266bfb6-341c-1d9c-e96f-c9f856a5ffb6@arm.com> <20220222192943.20137-1-alisaidi@amazon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220222192943.20137-1-alisaidi@amazon.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220227_055455_637166_39E4A9D0 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 22, 2022 at 07:29:43PM +0000, Ali Saidi wrote: [...] > >So I am just wandering if we can set the field > >sample::data_src::mem_lock for atomic operations, like: > > > > data_src.mem_op = PERF_MEM_OP_LOAD; > > data_src.mem_lock = PERF_MEM_LOCK_ATOMIC; > > > >The field "mem_lock" is only two bits, we can consider to extend the > >structure with an extra filed "mem_lock_ext" if it cannot meet our > >requirement. > > These are for the LOCK instruction on x86. I don't know that we want to > overload the meaning here. Minimally there is value in differentiating > exclusives vs atomics. Good point. Can we consider to add new filed data_src.atomic with below types? PERF_MEM_ATOMIC_INST -> Atomic operations PERF_MEM_ATOMIC_EXCL -> Load-Exclusive/Store-Exclusive PERF_MEM_ATOMIC_ACQUIRE_RELEASE ->Load-Acquire/Store-Release Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel