* [PATCH] arm64: dts: imx8mm-venice: fix spi2 pin configuration
@ 2022-02-28 10:16 Johan Hovold
2022-02-28 18:04 ` Tim Harvey
2022-04-06 13:31 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Johan Hovold @ 2022-02-28 10:16 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer
Cc: Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-arm-kernel, linux-kernel, Johan Hovold, stable, Tim Harvey
Due to what looks like a copy-paste error, the ECSPI2_MISO pad is not
muxed for SPI mode and causes reads from a slave-device connected to the
SPI header to always return zero.
Configure the ECSPI2_MISO pad for SPI mode on the gw71xx, gw72xx and
gw73xx families of boards that got this wrong.
Fixes: 6f30b27c5ef5 ("arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits")
Cc: stable@vger.kernel.org # 5.12
Cc: Tim Harvey <tharvey@gateworks.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
index 28012279f6f6..ecf6c9a6db90 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
@@ -166,7 +166,7 @@ pinctrl_spi2: spi2grp {
fsl,pins = <
MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0xd6
- MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
+ MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0xd6
MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0xd6
>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
index 27afa46a253a..6e0f0a2f6970 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
@@ -231,7 +231,7 @@ pinctrl_spi2: spi2grp {
fsl,pins = <
MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0xd6
- MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
+ MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0xd6
MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0xd6
>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index a59e849c7be2..6c4c9ae9715f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -280,7 +280,7 @@ pinctrl_spi2: spi2grp {
fsl,pins = <
MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0xd6
- MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
+ MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0xd6
MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0xd6
>;
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: imx8mm-venice: fix spi2 pin configuration
2022-02-28 10:16 [PATCH] arm64: dts: imx8mm-venice: fix spi2 pin configuration Johan Hovold
@ 2022-02-28 18:04 ` Tim Harvey
2022-04-06 13:31 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Tim Harvey @ 2022-02-28 18:04 UTC (permalink / raw)
To: Johan Hovold
Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Linux ARM Mailing List, open list, stable
On Mon, Feb 28, 2022 at 2:18 AM Johan Hovold <johan@kernel.org> wrote:
>
> Due to what looks like a copy-paste error, the ECSPI2_MISO pad is not
> muxed for SPI mode and causes reads from a slave-device connected to the
> SPI header to always return zero.
>
> Configure the ECSPI2_MISO pad for SPI mode on the gw71xx, gw72xx and
> gw73xx families of boards that got this wrong.
>
> Fixes: 6f30b27c5ef5 ("arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits")
> Cc: stable@vger.kernel.org # 5.12
> Cc: Tim Harvey <tharvey@gateworks.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
> index 28012279f6f6..ecf6c9a6db90 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
> @@ -166,7 +166,7 @@ pinctrl_spi2: spi2grp {
> fsl,pins = <
> MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
> MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0xd6
> - MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
> + MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0xd6
> MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0xd6
> >;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> index 27afa46a253a..6e0f0a2f6970 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
> @@ -231,7 +231,7 @@ pinctrl_spi2: spi2grp {
> fsl,pins = <
> MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
> MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0xd6
> - MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
> + MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0xd6
> MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0xd6
> >;
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> index a59e849c7be2..6c4c9ae9715f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> @@ -280,7 +280,7 @@ pinctrl_spi2: spi2grp {
> fsl,pins = <
> MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
> MX8MM_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0xd6
> - MX8MM_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0xd6
> + MX8MM_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0xd6
> MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0xd6
> >;
> };
> --
> 2.34.1
>
Johan,
Thanks for catching this!
Acked-by: Tim Harvey <tharvey@gateworks.com>
Best Regards,
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: imx8mm-venice: fix spi2 pin configuration
2022-02-28 10:16 [PATCH] arm64: dts: imx8mm-venice: fix spi2 pin configuration Johan Hovold
2022-02-28 18:04 ` Tim Harvey
@ 2022-04-06 13:31 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-04-06 13:31 UTC (permalink / raw)
To: Johan Hovold
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-arm-kernel, linux-kernel, stable,
Tim Harvey
On Mon, Feb 28, 2022 at 11:16:17AM +0100, Johan Hovold wrote:
> Due to what looks like a copy-paste error, the ECSPI2_MISO pad is not
> muxed for SPI mode and causes reads from a slave-device connected to the
> SPI header to always return zero.
>
> Configure the ECSPI2_MISO pad for SPI mode on the gw71xx, gw72xx and
> gw73xx families of boards that got this wrong.
>
> Fixes: 6f30b27c5ef5 ("arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits")
> Cc: stable@vger.kernel.org # 5.12
> Cc: Tim Harvey <tharvey@gateworks.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-06 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-28 10:16 [PATCH] arm64: dts: imx8mm-venice: fix spi2 pin configuration Johan Hovold
2022-02-28 18:04 ` Tim Harvey
2022-04-06 13:31 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).