From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D74EC433F5 for ; Mon, 28 Feb 2022 16:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+FkOJLKm8+fr+fpvxYYrw4NccYdqGsX5CLchSt8ukzw=; b=tK0xqRwsxAA0jr Y4o6SnYEE0Hb16BZYiPG8usZ6gYkvKUqIvPlNNdWRypyK8lF6ubEApeyh9eVM+PlMqSEFhJMdYaHe 8q4GA4FUh8Z5YTxoOIhfF6h7oP5j250mB4bjYZXLeoFH8hpinaJBk/t/NzFlS9KQ/GyQ5gVPwFf12 8Oq/+pyQIx78cFpgZ0Z10q1u2PbvigKQWFVA5aWQaDrEfcXb1R8L3iT0oQpGXX3CyGmOIRHXVeRUb kJudMc24YTl9fTiSFelAkdYYFI/c0XswSjDkY6OapLO/i+svXWVJOW8r7Ml0Iowdh0VLGPXSa1hrG aWeeKl6+GIUcOgq+Y7Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOjHq-00DPIG-HW; Mon, 28 Feb 2022 16:54:14 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOjHn-00DPHx-Gg for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 16:54:13 +0000 Received: by mail-pf1-x434.google.com with SMTP id k1so993614pfu.2 for ; Mon, 28 Feb 2022 08:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/PP18PnlVf/AcE9TCVp3WkPzAUoq9OmCtcVZO7RF9H0=; b=gKIUb/KnSbcay3ZyS25SnMcMCkia1zVN8fogNkDZhAJy/PZ4nFs1s7suvXkAwiLrgf zMdI+/Uq1FcmfvLktwbNajZiyi9blVd4xqrH72deaYtxQCgr0vIXB4w8JSpJ0pZTIV2u eYz3PEIKyCBVIfD1jZNHmLA5KmL3VAGBwlgVzQIUWQ3wc0unNGZc+4IlJ0s9ja3PBGjy QEAP81qnZf23+Je1wJ7KA/IjQxWbvjqjvrUb1FLbHE2baA7fjU/SMrNHw7VozR1idXC6 FpGRgMGeVXK5J6f4PjEe3oEQJIcAJj7i/1NtdvMywuxlJ/TtqAQ4rCM0Ow3PoF5K0/ux k+8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/PP18PnlVf/AcE9TCVp3WkPzAUoq9OmCtcVZO7RF9H0=; b=FOWheU+gy9ZZu9JL/Y+pBqfvQGSIW4T010FioD7LFMY5ZiXk6Ne6UwkpwmBNm/awxc Okk1YosiTJslGEu6nZm/Y06JTaQV5WN28KGV2jucthqzaeAkvi7Kvn81Rw2/7r2IDisH S4IrIouOhKLs7I9g2V58MRH+Xu4E0HClmUe8oK5B8/p2NWf/RYAm7zpOg0i9f6CNTvmj qXouh8S7AAtp3unRAw3msZKCsenj/I4R6py+/pE+Mr0ZzNiImozU62nLTgjsZCBR9gx9 L6wxtOYWu3nMbOHNr1scfcVO3Er8NyKtB59gOpgakUoPnrS4xfKSzMuLieuUp4HeIlJw zmlQ== X-Gm-Message-State: AOAM532FNzX4nLQIUmdTuPond3xGlAYLydLJzd+sD4v5g9LQyp0RUYLn lRIhU7l+vZN/GSnHVLf7nshmIvqo3dPv+A== X-Google-Smtp-Source: ABdhPJxkrRPzgHLEA6/yaGSmJMHupUBt5XWeQCaT+Zgrv9LZMBwjgbpIY8cgrhjD6wWV3UeC0NUOqw== X-Received: by 2002:a63:8c52:0:b0:378:907d:1c6d with SMTP id q18-20020a638c52000000b00378907d1c6dmr5604028pgn.477.1646067249560; Mon, 28 Feb 2022 08:54:09 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id l2-20020a056a0016c200b004e10af156adsm14601792pfc.190.2022.02.28.08.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 08:54:08 -0800 (PST) Date: Mon, 28 Feb 2022 09:54:06 -0700 From: Mathieu Poirier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] coresight: Drop unused 'none' enum value for each component Message-ID: <20220228165406.GA1278407@p14s> References: <1645005118-10561-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1645005118-10561-1-git-send-email-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_085411_633412_A70F58BB X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Good morning, On Wed, Feb 16, 2022 at 03:21:58PM +0530, Anshuman Khandual wrote: > CORESIGHT_DEV_TYPE_NONE/CORESIGHT_DEV_SUBTYPE_XXXX_NONE values are not used > any where. Actual enumeration can start from 0. Just drop these unused enum > values. > > Cc: Mathieu Poirier > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: Leo Yan > Cc: coresight@lists.linaro.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > drivers/hwtracing/coresight/coresight-core.c | 3 --- > include/linux/coresight.h | 5 ----- > 2 files changed, 8 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 88653d1c06a4..af00dca8d1ac 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -1278,9 +1278,6 @@ static struct attribute *coresight_source_attrs[] = { > ATTRIBUTE_GROUPS(coresight_source); > > static struct device_type coresight_dev_type[] = { > - { > - .name = "none", > - }, > { > .name = "sink", > .groups = coresight_sink_groups, > diff --git a/include/linux/coresight.h b/include/linux/coresight.h > index 93a2922b7653..9f445f09fcfe 100644 > --- a/include/linux/coresight.h > +++ b/include/linux/coresight.h > @@ -36,7 +36,6 @@ > extern struct bus_type coresight_bustype; > > enum coresight_dev_type { > - CORESIGHT_DEV_TYPE_NONE, > CORESIGHT_DEV_TYPE_SINK, > CORESIGHT_DEV_TYPE_LINK, > CORESIGHT_DEV_TYPE_LINKSINK, > @@ -46,7 +45,6 @@ enum coresight_dev_type { > }; > > enum coresight_dev_subtype_sink { > - CORESIGHT_DEV_SUBTYPE_SINK_NONE, > CORESIGHT_DEV_SUBTYPE_SINK_PORT, > CORESIGHT_DEV_SUBTYPE_SINK_BUFFER, > CORESIGHT_DEV_SUBTYPE_SINK_SYSMEM, > @@ -54,21 +52,18 @@ enum coresight_dev_subtype_sink { > }; > > enum coresight_dev_subtype_link { > - CORESIGHT_DEV_SUBTYPE_LINK_NONE, > CORESIGHT_DEV_SUBTYPE_LINK_MERG, > CORESIGHT_DEV_SUBTYPE_LINK_SPLIT, > CORESIGHT_DEV_SUBTYPE_LINK_FIFO, > }; > > enum coresight_dev_subtype_source { > - CORESIGHT_DEV_SUBTYPE_SOURCE_NONE, > CORESIGHT_DEV_SUBTYPE_SOURCE_PROC, > CORESIGHT_DEV_SUBTYPE_SOURCE_BUS, > CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE, > }; > > enum coresight_dev_subtype_helper { > - CORESIGHT_DEV_SUBTYPE_HELPER_NONE, > CORESIGHT_DEV_SUBTYPE_HELPER_CATU, > }; These have never been used in the 7 years the subsystem has existed and I don't see in what kind of situation they could be... I have applied this patch. Thanks, Mathieu > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel