From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F326C433EF for ; Mon, 28 Feb 2022 17:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tV9h+o/U+8djBMcxO3/qitJBbJPTPbo1jwBmaboKR1I=; b=3hdECQZTRquSbJ nw8U4bpCXCmWpLn876EH00w1rDAB95lRjlbwvxm8DZGq/Gwh5OtO4xmP/jqXoiZKhI8HZsUYsgGbT zuR1ckK4h9tAHznHxAFYchKZLreDf2xia8Xlv1MrVUyaIYpv+9x36y4W2BIJCgWYZwjJtJ9XQlgU5 r0nujjgo2gLaMWHglVM3XoHnVIMLT1UQ/DgTsNx6fUM77k8cMq3k8EpfBayN3Da0/GeW1E8PIygRS i4tZ7FrHLAr6l+eHzSXQ8BTl83L8IkFtbPFmU6tr9ZMJmWQl83k97kDO2a+gcJMTmfchxHw8qbC1h ZkUJKxr9Un3X5neSE8TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOjxy-00DYJa-8A; Mon, 28 Feb 2022 17:37:46 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOjxb-00DY9s-DA for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 17:37:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646069843; x=1677605843; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SiZFexYAsMbDBWKC0i6qZTmB2eWvi9q/m/x6dShxuvo=; b=h5hGvGPUzVn5Gia1uS81/ml86BCGIUBQW4LEDbxQqf829tClBAM8so7o XKanEXhJmFr1YCNOcbfSxZrcCKlgwElyJwmpXE2o/7BEi6QxWctYq8uYp 5eutdKE8n8727MISlR1184qXdphCySj2yp5ivgJW4dOqZZ8KUnBPfbOnF E5xCeFpIhc/ytBOtjWrvfEPYwpq5Z2I9tDEQWWE2Vyw458kOxeQz0aW/P FLMLTLNVoH3eAY1Y2bUtG8II4sLBFfx9gb6q959WkRJZKxm3l1CIP6EGA EhVn9ri4p2ixrwM/qvfsH7uJyMtgXxEW/hHD+DoB9LPSVeLM8EhUZyZuX Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="233560495" X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="233560495" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 09:37:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="544807684" Received: from lkp-server01.sh.intel.com (HELO 788b1cd46f0d) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 28 Feb 2022 09:37:20 -0800 Received: from kbuild by 788b1cd46f0d with local (Exim 4.92) (envelope-from ) id 1nOjxS-0007cW-MA; Mon, 28 Feb 2022 17:37:14 +0000 Date: Tue, 1 Mar 2022 01:37:06 +0800 From: kernel test robot To: Claudiu Beznea , daniel.lezcano@linaro.org, tglx@linutronix.de Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: Re: [PATCH 7/7] clocksource/drivers/timer-microchip-pit64b: use mchp_pit64b_{suspend, resume} Message-ID: <202203010158.D812WMzG-lkp@intel.com> References: <20220228111923.1400049-8-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220228111923.1400049-8-claudiu.beznea@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_093723_548956_C932E25E X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Claudiu, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/timers/core] [also build test WARNING on soc/for-next linus/master v5.17-rc6 next-20220225] [cannot apply to daniel-lezcano/clockevents/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Claudiu-Beznea/clocksource-drivers-timer-microchip-pit64b-fixes-and-improvements/20220228-191933 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 35e13e9da9afbce13c1d36465504ece4e65f24fe config: i386-randconfig-a002-20220228 (https://download.01.org/0day-ci/archive/20220301/202203010158.D812WMzG-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/a354e98d1b37361a46d6272ffccc149e3b8bbbca git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Claudiu-Beznea/clocksource-drivers-timer-microchip-pit64b-fixes-and-improvements/20220228-191933 git checkout a354e98d1b37361a46d6272ffccc149e3b8bbbca # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/clocksource/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/clocksource/timer-microchip-pit64b.c:97:27: warning: tentative definition of variable with internal linkage has incomplete non-array type 'struct delay_timer' [-Wtentative-definition-incomplete-type] static struct delay_timer mchp_pit64b_dt; ^ drivers/clocksource/timer-microchip-pit64b.c:97:15: note: forward declaration of 'struct delay_timer' static struct delay_timer mchp_pit64b_dt; ^ drivers/clocksource/timer-microchip-pit64b.c:385:16: error: incomplete definition of type 'struct delay_timer' mchp_pit64b_dt.read_current_timer = mchp_pit64b_dt_read; ~~~~~~~~~~~~~~^ drivers/clocksource/timer-microchip-pit64b.c:97:15: note: forward declaration of 'struct delay_timer' static struct delay_timer mchp_pit64b_dt; ^ drivers/clocksource/timer-microchip-pit64b.c:386:16: error: incomplete definition of type 'struct delay_timer' mchp_pit64b_dt.freq = clk_rate; ~~~~~~~~~~~~~~^ drivers/clocksource/timer-microchip-pit64b.c:97:15: note: forward declaration of 'struct delay_timer' static struct delay_timer mchp_pit64b_dt; ^ drivers/clocksource/timer-microchip-pit64b.c:387:2: error: implicit declaration of function 'register_current_timer_delay' [-Werror,-Wimplicit-function-declaration] register_current_timer_delay(&mchp_pit64b_dt); ^ >> drivers/clocksource/timer-microchip-pit64b.c:484:1: warning: unused label 'pclk_unprepare' [-Wunused-label] pclk_unprepare: ^~~~~~~~~~~~~~~ drivers/clocksource/timer-microchip-pit64b.c:97:27: error: tentative definition has type 'struct delay_timer' that is never completed static struct delay_timer mchp_pit64b_dt; ^ drivers/clocksource/timer-microchip-pit64b.c:97:15: note: forward declaration of 'struct delay_timer' static struct delay_timer mchp_pit64b_dt; ^ 2 warnings and 4 errors generated. vim +/pclk_unprepare +484 drivers/clocksource/timer-microchip-pit64b.c 625022a5f16061 Claudiu Beznea 2019-12-13 430 625022a5f16061 Claudiu Beznea 2019-12-13 431 static int __init mchp_pit64b_dt_init_timer(struct device_node *node, 625022a5f16061 Claudiu Beznea 2019-12-13 432 bool clkevt) 625022a5f16061 Claudiu Beznea 2019-12-13 433 { b9c60a741f06ed Claudiu Beznea 2020-01-06 434 struct mchp_pit64b_timer timer; 625022a5f16061 Claudiu Beznea 2019-12-13 435 unsigned long clk_rate; 625022a5f16061 Claudiu Beznea 2019-12-13 436 u32 irq = 0; 625022a5f16061 Claudiu Beznea 2019-12-13 437 int ret; 625022a5f16061 Claudiu Beznea 2019-12-13 438 625022a5f16061 Claudiu Beznea 2019-12-13 439 /* Parse DT node. */ 625022a5f16061 Claudiu Beznea 2019-12-13 440 timer.pclk = of_clk_get_by_name(node, "pclk"); 625022a5f16061 Claudiu Beznea 2019-12-13 441 if (IS_ERR(timer.pclk)) 625022a5f16061 Claudiu Beznea 2019-12-13 442 return PTR_ERR(timer.pclk); 625022a5f16061 Claudiu Beznea 2019-12-13 443 625022a5f16061 Claudiu Beznea 2019-12-13 444 timer.gclk = of_clk_get_by_name(node, "gclk"); 625022a5f16061 Claudiu Beznea 2019-12-13 445 if (IS_ERR(timer.gclk)) 625022a5f16061 Claudiu Beznea 2019-12-13 446 return PTR_ERR(timer.gclk); 625022a5f16061 Claudiu Beznea 2019-12-13 447 625022a5f16061 Claudiu Beznea 2019-12-13 448 timer.base = of_iomap(node, 0); 625022a5f16061 Claudiu Beznea 2019-12-13 449 if (!timer.base) 625022a5f16061 Claudiu Beznea 2019-12-13 450 return -ENXIO; 625022a5f16061 Claudiu Beznea 2019-12-13 451 625022a5f16061 Claudiu Beznea 2019-12-13 452 if (clkevt) { 625022a5f16061 Claudiu Beznea 2019-12-13 453 irq = irq_of_parse_and_map(node, 0); 625022a5f16061 Claudiu Beznea 2019-12-13 454 if (!irq) { 625022a5f16061 Claudiu Beznea 2019-12-13 455 ret = -ENODEV; 625022a5f16061 Claudiu Beznea 2019-12-13 456 goto io_unmap; 625022a5f16061 Claudiu Beznea 2019-12-13 457 } 625022a5f16061 Claudiu Beznea 2019-12-13 458 } 625022a5f16061 Claudiu Beznea 2019-12-13 459 625022a5f16061 Claudiu Beznea 2019-12-13 460 /* Initialize mode (prescaler + SGCK bit). To be used at runtime. */ 0faff1ca60d69f Claudiu Beznea 2022-02-28 461 ret = mchp_pit64b_init_mode(&timer, MCHP_PIT64B_DEF_FREQ); 625022a5f16061 Claudiu Beznea 2019-12-13 462 if (ret) 625022a5f16061 Claudiu Beznea 2019-12-13 463 goto irq_unmap; 625022a5f16061 Claudiu Beznea 2019-12-13 464 a354e98d1b3736 Claudiu Beznea 2022-02-28 465 if (timer.mode & MCHP_PIT64B_MR_SGCLK) 625022a5f16061 Claudiu Beznea 2019-12-13 466 clk_rate = clk_get_rate(timer.gclk); a354e98d1b3736 Claudiu Beznea 2022-02-28 467 else 625022a5f16061 Claudiu Beznea 2019-12-13 468 clk_rate = clk_get_rate(timer.pclk); 625022a5f16061 Claudiu Beznea 2019-12-13 469 clk_rate = clk_rate / (MCHP_PIT64B_MODE_TO_PRES(timer.mode) + 1); 625022a5f16061 Claudiu Beznea 2019-12-13 470 625022a5f16061 Claudiu Beznea 2019-12-13 471 if (clkevt) 625022a5f16061 Claudiu Beznea 2019-12-13 472 ret = mchp_pit64b_init_clkevt(&timer, clk_rate, irq); 625022a5f16061 Claudiu Beznea 2019-12-13 473 else 625022a5f16061 Claudiu Beznea 2019-12-13 474 ret = mchp_pit64b_init_clksrc(&timer, clk_rate); 625022a5f16061 Claudiu Beznea 2019-12-13 475 625022a5f16061 Claudiu Beznea 2019-12-13 476 if (ret) 625022a5f16061 Claudiu Beznea 2019-12-13 477 goto gclk_unprepare; 625022a5f16061 Claudiu Beznea 2019-12-13 478 625022a5f16061 Claudiu Beznea 2019-12-13 479 return 0; 625022a5f16061 Claudiu Beznea 2019-12-13 480 625022a5f16061 Claudiu Beznea 2019-12-13 481 gclk_unprepare: 625022a5f16061 Claudiu Beznea 2019-12-13 482 if (timer.mode & MCHP_PIT64B_MR_SGCLK) 625022a5f16061 Claudiu Beznea 2019-12-13 483 clk_disable_unprepare(timer.gclk); 625022a5f16061 Claudiu Beznea 2019-12-13 @484 pclk_unprepare: 625022a5f16061 Claudiu Beznea 2019-12-13 485 clk_disable_unprepare(timer.pclk); 625022a5f16061 Claudiu Beznea 2019-12-13 486 irq_unmap: 625022a5f16061 Claudiu Beznea 2019-12-13 487 irq_dispose_mapping(irq); 625022a5f16061 Claudiu Beznea 2019-12-13 488 io_unmap: 625022a5f16061 Claudiu Beznea 2019-12-13 489 iounmap(timer.base); 625022a5f16061 Claudiu Beznea 2019-12-13 490 625022a5f16061 Claudiu Beznea 2019-12-13 491 return ret; 625022a5f16061 Claudiu Beznea 2019-12-13 492 } 625022a5f16061 Claudiu Beznea 2019-12-13 493 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel