From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8299FC433EF for ; Wed, 2 Mar 2022 14:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vnd90/6IaYH8yj756+h7pHLlwRFG6sEZWdRKFL42//c=; b=HLCVjyxxeaNLkUU5hE7to6X48z 88w9VRiNKl3VddRv8qxJDhRXnEuDOV5YAipg5UKokVIiAIuv7GFLq1YSsPeAdwJDxcP1lQWl3FLVa 3vSbXtFTPS73CI721pT8YDybczoGecUoJtStrLgEetMIXGDulSIL/znjbTyJtZbElyZDgWP8jWWjd +uCBtEQirwnchvFA/FWJnfJWGtaT9uudoTvpjD4ICBx5Rk3tt76VASZH6MxHyCC7XkM+HpYAzXBEB DvuPRSMi/UNFaCoToFn5GwcWwCLQRu+77Tn3OMDOcVZrCV/arDov0ctbvRk18P4odLmMb1PH1k3Gv Gz7ZsOyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPPrY-002xiu-Im; Wed, 02 Mar 2022 14:21:56 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPPrU-002xhk-KS for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2022 14:21:54 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id E47B5581057; Wed, 2 Mar 2022 09:21:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 02 Mar 2022 09:21:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=hU6HsrKnth78ZSddWHxb6QvqVJZedVM+vKp04w +0t/A=; b=idvznvAYB6IWlPqt1bftUZQc0o3Ln7Sj+QWhtSkR4jbY8YIJGSNj50 d93ZKiwIBiJ4TwFrE5NoErbnxh9OzoSFWA5Z0lr3mzmDLe9NHYJoDXaXW5stsK9n 8RoiRpfYelWFT0gRxVLg5tApVI3TvCriFGyua4q0XYkNqFhJgx01GZRLH4i0VYo+ dV6rsYyuItFcRRDYDwTFZ+HG5HEXIaIlGHgQ+rIXNZpPLHtmldVSu0v/jcWcI3Qt Nwy/GxtLP5O+ENQapkqYbM7V6kvPyS2SK63MtrwxXsX0A9iR9ZwJhZsaMSUe0WcY UDPvdGlhuCqz8rNNsnob2KNePo/vrXyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hU6HsrKnth78ZSddW Hxb6QvqVJZedVM+vKp04w+0t/A=; b=BqC6X+e4OGKrmXH8Du9ng0ptEkjaa9ovt tBeluC3HTHSkBxEaJoAkjRs7ag/KmoLCVz14w5SAkV7MQVWkeDWVm64XnUHwKycs MayHmtafh2V1jaQLAVxmzB1TFst6WdDAm0ZCqKdd4XRsMl9itvqiZvLr4vKW0Qkb a3OMcH/xOtU8XhkefR/zDmmp//J/8hxEUGBNSBMdcLPd7uVzsVC3Jqxg9YGmcnCz m09dgvd9qmFq4WdvaFnc3kulSleFKdlDUKVHKvuScA0sqF1JUcxHEj3c8BGyugDU 5+4paJEDvvtif3iAc51vXTY5cvvA7fMZK8PhmDgKrzB5zATY3+DkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtgedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Mar 2022 09:21:44 -0500 (EST) Date: Wed, 2 Mar 2022 15:21:42 +0100 From: Maxime Ripard To: Max Krummenacher Cc: Marek Vasut , dri-devel@lists.freedesktop.org, Sascha Hauer , Philipp Zabel , Laurent Pinchart , Fabio Estevam , Linux ARM , DenysDrozdov , David Airlie , Christoph Niedermaier , Pengutronix Kernel Team , Sam Ravnborg , Shawn Guo , Daniel Vetter , NXP Linux Team , Max Krummenacher Subject: Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format Message-ID: <20220302142142.zroy464l5etide2g@houat> References: <20220222084723.14310-1-max.krummenacher@toradex.com> <20220223134154.oo7xhf37bgtvm3ai@houat> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_062153_017481_8BF47012 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2213220508003589912==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2213220508003589912== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k3a6e5aq6fismlwb" Content-Disposition: inline --k3a6e5aq6fismlwb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Please try to avoid top posting On Wed, Feb 23, 2022 at 04:25:19PM +0100, Max Krummenacher wrote: > The goal here is to set the element bus_format in the struct > panel_desc. This is an enum with the possible values defined in > include/uapi/linux/media-bus-format.h. >=20 > The enum values are not constructed in a way that you could calculate > the value from color channel width/shift/mapping/whatever. You rather > would have to check if the combination of color channel > width/shift/mapping/whatever maps to an existing value and otherwise > EINVAL out. >=20 > I don't see the value in having yet another way of how this > information can be specified and then having to write a more > complicated parser which maps the dt data to bus_format. Generally speaking, sending an RFC without explicitly stating what you want a comment on isn't very efficient. That being said, what I (and I can only assume Marek) don't like is the string encoding. Especially when the similar bus-type property uses a integer with the various available bus options we have. Having an integer, with a set of defines that you would map to the proper MEDIA_BUS_* would be more efficient and more elegant. That being said, the first question that needs to be answered is why does this have to be in the DT in the first place? Maxime --k3a6e5aq6fismlwb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYh99dgAKCRDj7w1vZxhR xdaEAP9fW1YJFu2pC0biPazLcBK3CNE9ztJtJFL1JsuwlGokUAD/ezrhXG9q4QiT OJ6Ye6hKheS3IAkQTKa8Isxzn+ILlAg= =cJti -----END PGP SIGNATURE----- --k3a6e5aq6fismlwb-- --===============2213220508003589912== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2213220508003589912==--