From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EDC0C433FE for ; Wed, 2 Mar 2022 19:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=86HrMxi8Y5W9ucrTfNeqlRNrp7a8onuDdCj/oWa/wX0=; b=mnizIg29cjFpoo 4a74IJwuo9IyAv+ea69YVV2qjeaq1Cyl62cywYKyrEjJ+HqmEmpP3uPxqYjBfEx+jUqGvq1CtZ+4N qRBdRW00SaP2hZDSU8zzSx8QDIO24X3NM7LXLy+U9t1ki8GONAmjfa9EkkX4FzcGf0kEsNbjmvDis UZ/q4E1HNSSGGIorLm8uClonGCM+eFR8CxFc2xV+cWQWIQqBeBYxSku8PY0/PcDLiRxItcM0dMHrs 0BnyF87nHsMqZmtub2LEeDtUFz2pPgqfmLOHfVT17dYvP7mK8wW3fyQlYhuFr+t/6VNlNH+IJ2taC LNf5OX0gLmu28iBBk9lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPUHn-003uXn-J4; Wed, 02 Mar 2022 19:05:19 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPUHc-003uTw-Fk for linux-arm-kernel@lists.infradead.org; Wed, 02 Mar 2022 19:05:09 +0000 Received: by mail-pf1-x42b.google.com with SMTP id z16so2746324pfh.3 for ; Wed, 02 Mar 2022 11:05:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1v/GWH828oM9qnw7BmuwPl1OTwbK6th2t0rZuoggB/w=; b=ZhyXOK3wtbHda6wuUihJ05V5rG7u73YYPzNG2P3Rqn46fkvYe+zsehpnNA3JLoYVNQ omuYRrc8bolqhZsCwYCJ00BtBwMy6eO8vebHuG2yJgjmkfx7YK+t7bcFYMBo9MB/CJrA ysj4wSTfCSnNa4hzgbKXWC0roQiVIvleSeh9CwqPJxL2EQ4pUeJRddoqYd6fTRoC1OTE gLKk9K+BMcou31589beb+DxDz7Zx/W2dBBw/NFmeqL9SlKNqr8tRGnrNymWMu9i6V0hk UZd/DBdSwEcJ5Z54tJSA/SzbtKz1n0P1bMlXCXV7OMNwso3UlcDzB6JrpSaUwcrN93IR U2QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1v/GWH828oM9qnw7BmuwPl1OTwbK6th2t0rZuoggB/w=; b=C6CaXQ3fv/hbsVgxoUFlyMAtNyVyRRs+1hwxAwpPjFc86O2ypdY3cH5NIHncTTaxfX lQBTBGZaSa3DmLhLcpm+l40mko0kcw8ePa02QvHiUDpnwosJVd04U9zFkOQI/xep6h7g MEOhYwI348BvdIc9/ArEHPRv+uO4l0OFPJzm5VE5Wvwrk9f1XFA1x9fN8z81iQC7HiLJ j9eNyYXN77VA4OfkH3Z3twusJ3V9Y9MhXEAqE1/kItFDoCyEEo+j97olhHesH2p/DbmM 56W6qC40WroMiWuKmomL8Cr78jtYxm3gQ1H+t5+LoDYotk9zQc58nAoYY0S+Sf/XAeGU FKaA== X-Gm-Message-State: AOAM530edvsXD+aWd4+h2qfFv5YPnduLlsvikoJHulr4y/XsniJB1Zfh m/j6zjVqR7+gMNEVnkt0SVU= X-Google-Smtp-Source: ABdhPJzpPlIv5KYqzsr/vWUHpTcqLEynLR/AoOHj/8TEInuNwABg/YDvtIwl/rkIspDh3TNNwwGSxA== X-Received: by 2002:a05:6a00:21cd:b0:4e1:b09b:18e8 with SMTP id t13-20020a056a0021cd00b004e1b09b18e8mr34456075pfj.60.1646247907314; Wed, 02 Mar 2022 11:05:07 -0800 (PST) Received: from 9a2d8922b8f1 ([122.161.53.154]) by smtp.gmail.com with ESMTPSA id n42-20020a056a000d6a00b004e1a01dcc35sm21486049pfv.150.2022.03.02.11.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 11:05:06 -0800 (PST) Date: Thu, 3 Mar 2022 00:35:01 +0530 From: Kuldeep Singh To: Robin Murphy Cc: Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Linus Walleij Subject: Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property in pl022 Message-ID: <20220302190501.GA2168@9a2d8922b8f1> References: <20220228124345.99474-1-singh.kuldeep87k@gmail.com> <20220228124345.99474-4-singh.kuldeep87k@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_110508_557351_11C45581 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 28, 2022 at 02:36:23PM +0000, Robin Murphy wrote: > On 2022-02-28 12:43, Kuldeep Singh wrote: > > Fix below dtc warning by making necessary addition of "spiclk" in > > clock-names property. > > > > arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000: > > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > > arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000: > > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > > As before, what makes the binding at fault rather than that DT? The PL022's > actual input is named SSPCLK, not SPICLK, so why should a driver which wants > to look up that clock by name expect to look for "spiclk"? That's right. It's the DT which is at the fault of defining spiclk instead of sspclk and need to be fixed in DT itself. I didn't take a look at pl022 doc and acted on the basis of DT info. Moreover, DT also uses sspclk and SSPCLK names interchangeably which are anyway same. This also require updation to follow single convention. Appreciate your comments and valuable inputs. -- Best Regards Kuldeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel