[PATCH] ARM: dts: aspeed: Fix AST2600 quad spi group

[PATCH] ARM: dts: aspeed: Fix AST2600 quad spi group

[Joel Stanley]

Requesting quad mode for the FMC resulted in an error:

  &fmc {
         status = "okay";
 +       pinctrl-names = "default";
 +       pinctrl-0 = <&pinctrl_fwqspi_default>'

[    0.742963] aspeed-g6-pinctrl 1e6e2000.syscon:pinctrl: invalid function FWQSPID in map table


This is because the quad mode pins are a group of pins, not a function.

After applying this patch we can request the pins and the QSPI data
lines are muxed:

 # cat /sys/kernel/debug/pinctrl/1e6e2000.syscon\:pinctrl-aspeed-g6-pinctrl/pinmux-pins |grep 1e620000.spi
 pin 196 (AE12): device 1e620000.spi function FWSPID group FWQSPID
 pin 197 (AF12): device 1e620000.spi function FWSPID group FWQSPID
 pin 240 (Y1): device 1e620000.spi function FWSPID group FWQSPID
 pin 241 (Y2): device 1e620000.spi function FWSPID group FWQSPID
 pin 242 (Y3): device 1e620000.spi function FWSPID group FWQSPID
 pin 243 (Y4): device 1e620000.spi function FWSPID group FWQSPID

Fixes: f510f04c8c83 ("ARM: dts: aspeed: Add AST2600 pinmux nodes")
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi b/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi
index 6dde51c2aed3..e4775bbceecc 100644
--- a/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6-pinctrl.dtsi
@@ -118,7 +118,7 @@ pinctrl_fwspid_default: fwspid_default {
 	};
 
 	pinctrl_fwqspid_default: fwqspid_default {
-		function = "FWQSPID";
+		function = "FWSPID";
 		groups = "FWQSPID";
 	};
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: aspeed: Fix AST2600 quad spi group

[Andrew Jeffery]

On Fri, 4 Mar 2022, at 11:40, Joel Stanley wrote:
> Requesting quad mode for the FMC resulted in an error:
>
>   &fmc {
>          status = "okay";
>  +       pinctrl-names = "default";
>  +       pinctrl-0 = <&pinctrl_fwqspi_default>'
>
> [    0.742963] aspeed-g6-pinctrl 1e6e2000.syscon:pinctrl: invalid 
> function FWQSPID in map table
> 
>
> This is because the quad mode pins are a group of pins, not a function.
>
> After applying this patch we can request the pins and the QSPI data
> lines are muxed:
>
>  # cat 
> /sys/kernel/debug/pinctrl/1e6e2000.syscon\:pinctrl-aspeed-g6-pinctrl/pinmux-pins 
> |grep 1e620000.spi
>  pin 196 (AE12): device 1e620000.spi function FWSPID group FWQSPID
>  pin 197 (AF12): device 1e620000.spi function FWSPID group FWQSPID
>  pin 240 (Y1): device 1e620000.spi function FWSPID group FWQSPID
>  pin 241 (Y2): device 1e620000.spi function FWSPID group FWQSPID
>  pin 242 (Y3): device 1e620000.spi function FWSPID group FWQSPID
>  pin 243 (Y4): device 1e620000.spi function FWSPID group FWQSPID
>
> Fixes: f510f04c8c83 ("ARM: dts: aspeed: Add AST2600 pinmux nodes")
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Looks good to me.

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel