From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E4B5C433F5 for ; Fri, 4 Mar 2022 08:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9nBpj1eNFr/1WnBhkqF2Z3EIlwl+dBUHZVU7tBSZ2Ho=; b=y/7I2Q0vFRhPPB aS4NS5lFW1RlXqJSoC96RcBH3C5JVpV27f/a3EDgds0CLsTSL1ncQbDE1oR3Kmn+hNed9bb8RKYcy IsSRHWm2tIVqNG1YHczhtt9bE2tDRq5alx9oZ5+/L1MYEZlnnWmTBam5CF+8tyh0GBDx+Zv4eppYS P8bYunZMUP5cvtsjmSz5jnNEGz8GtxmiRVmL1a51C1/OOmuO3c9O7xRXMg27uq1iegamLKg7lz86t WfrZITwXuwRFs5XsJlgDxDeWFPfQGhvBzJ/KfkU1jlzUU1fYDk4oe5uNIAwGn2Xg6y2kfrf+lCDs6 LWnWOo/32sRVMNbe8MbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQ3B9-0090TD-VJ; Fri, 04 Mar 2022 08:20:48 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQ3B6-0090R3-AI for linux-arm-kernel@lists.infradead.org; Fri, 04 Mar 2022 08:20:45 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ3An-0002sn-TG; Fri, 04 Mar 2022 09:20:25 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nQ3Am-0002hT-2F; Fri, 04 Mar 2022 09:20:24 +0100 Date: Fri, 4 Mar 2022 09:20:24 +0100 From: Michael Tretter To: Jia-Ju Bai Cc: vkoul@kernel.org, michal.simek@xilinx.com, yukuai3@huawei.com, lars@metafoo.de, libaokun1@huawei.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] dma: xilinx: check the return value of dma_set_mask() in zynqmp_dma_probe() Message-ID: <20220304082024.GO8137@pengutronix.de> References: <20220303024334.813-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220303024334.813-1-baijiaju1990@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:16:28 up 83 days, 17:02, 75 users, load average: 0.05, 0.22, 0.31 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_002044_392964_3A6ED0C5 X-CRM114-Status: GOOD ( 20.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 02 Mar 2022 18:43:34 -0800, Jia-Ju Bai wrote: > The function dma_set_mask() in zynqmp_dma_probe() can fail, so its > return value should be checked. > > Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support") > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai > --- > drivers/dma/xilinx/zynqmp_dma.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c > index 7aa63b652027..963fb1de93af 100644 > --- a/drivers/dma/xilinx/zynqmp_dma.c > +++ b/drivers/dma/xilinx/zynqmp_dma.c > @@ -1050,7 +1050,8 @@ static int zynqmp_dma_probe(struct platform_device *pdev) > zdev->dev = &pdev->dev; > INIT_LIST_HEAD(&zdev->common.channels); > > - dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); > + if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(44))) > + return -EIO; Thanks. You may print an error message with dev_err_probe and forward the return value of dma_set_mask. Michael > dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask); > > p = &zdev->common; > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel