From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC5DEC433F5 for ; Fri, 11 Mar 2022 02:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WJJ9iYeiXz9meKNc17RpFgTpemQMgkvltDVGQnt9ET8=; b=njDFymamXNOlET C3chCpgiw4zXCDDUKT5+wpYe21s07Yt254jtP5hr/MN5WCttMwpm/dobdCSnXGkanswaxS1fCC+V2 kbvyJSXM4ayXV42q4iXCyP5Q6wf40WOlNlHifEtZvA7wjzfNhEAwnQGtz7ia8ddk2nXwwOAM5RHBO J8/b3uHC3Bfy48bmePocC9xpAmitoCMSKTbpC+gF0OSviHKiKKh4ahWEhC6ENwE76JUQqQAWySR8/ QoDBjc3sH84rObam4W4YoDd18YztkwyCKGRnlxDyV0jvy4fkxWCxrJy5BgClCirJrE3gFAmoh1pOX ZltiMJ8siwmhxCV5T2Hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSVQv-00EoMt-9j; Fri, 11 Mar 2022 02:55:13 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSVQr-00EoMR-U7 for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 02:55:11 +0000 Received: by mail-pl1-x636.google.com with SMTP id n18so3902275plg.5 for ; Thu, 10 Mar 2022 18:55:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Me7hT9AANgy5+2Wv0ivBaS8/sti8zcauVvAwoiWjGZ8=; b=LBYuGtdQ52NNz1BpOrKepKeWw3H0APbePuZdtR8reLvS4ufZLcGHyAJ+NkYSxEwbsR 1L4pPldLz6w7oBlQKyTdvQvgLWPfEBb2oNJXaYraH0uey/fmAzjfOg2HD511FBAYb06e U3jcaitOJur6kmuAfFtSRRsqRbGM/Tr9fkwUnjfmLfKa6ephY3HRzoddeCPyZp1L2kgW T+/vLS3AvOTbpPuAWBVjlFdeU6qBZVlVwwCBW5LdgZFJc2u44V9AL4HCZtwhwBWWD4wW qEAzqmHCNQeXuIxXbv0F+fQmYniPBUq6T0FCzQZWONRELMatbefTz/BBpgRPY1qeEPDu xD4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Me7hT9AANgy5+2Wv0ivBaS8/sti8zcauVvAwoiWjGZ8=; b=vYACi35rXNY12HXdN0lGYU/R8kx4fin/GK1KRKci0aggilg8l7dbUVmLpgE4fkup19 lo0hdDO1qDKZpj+dvmldQzJV8a54po8Ovx4M9gSCsOGXmaYr3kyQM+Ml3kGbnWeN/rUh 3x5+U/fAqhiZaUpoYb+pvVmQJf6pIsErLp6nzAZu83jYACG7zOL504RzUtjEi5X0U4to JOjNW5vVyGuVHZBQhffIxQaP/xfrwK8IF3loMPTXZ01gEUy9dvAu6Znlh8YiFuiivQ5a Q7zX6xIT3MaE+4tPOvU1uUQeBClwzxKmlRxgDvmv1TA6e75IVt3F5soYQyYPQ8ggrGp0 6n1g== X-Gm-Message-State: AOAM530bKg6Bzdmb77Uk6idvtW56I87vZENypf6GAJkyGZC6G0bmmCAc P7W6215a6I/lp9+t1YuxnN0= X-Google-Smtp-Source: ABdhPJzmED5JxuqhDqb9IERzE0ga9+GHJcB/S360Jr/np9+iD9u0O6IBcfMXq3aOZZ9/ga5WV+ewxQ== X-Received: by 2002:a17:902:ce09:b0:151:96e2:d4b5 with SMTP id k9-20020a170902ce0900b0015196e2d4b5mr8008486plg.3.1646967308379; Thu, 10 Mar 2022 18:55:08 -0800 (PST) Received: from 9a2d8922b8f1 ([122.161.53.68]) by smtp.gmail.com with ESMTPSA id g13-20020a056a000b8d00b004f75395b2b4sm8398196pfj.55.2022.03.10.18.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 18:55:08 -0800 (PST) Date: Fri, 11 Mar 2022 08:25:02 +0530 From: Kuldeep Singh To: Rob Herring Cc: Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Robin Murphy , Linus Walleij , Krzysztof Kozlowski Subject: Re: [PATCH v2 1/2] dt-bindings: spi: Update clocks property for ARM pl022 Message-ID: <20220311025502.GB54098@9a2d8922b8f1> References: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_185510_000650_7B1C433C X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 10, 2022 at 04:05:37PM -0600, Rob Herring wrote: > On Tue, Mar 08, 2022 at 12:51:24PM +0530, Kuldeep Singh wrote: > > Add missing minItems property to clocks in ARM pl022 bindings. > > > > This helps in resolving below warnings: > > clocks: [[4]] is too short > > clock-names: ['apb_pclk'] is too short > > Again, the error is in the dts files, not the schema. Rob, kindly note this series number is deprecated and I have sent v3 version some time back. Here's the link: https://lore.kernel.org/linux-spi/20220309171847.5345-1-singh.kuldeep87k@gmail.com/T/#u > > > There's 2 possible answers. First, both clock inputs use the same source > clock. That's an easy fix. List the clock twice. Second, one clock is > not described in DT or visible to s/w. It still has to be in the h/w and > could be described as a 'fixed-clock'. A DT should either be all in with > clocks or not use the clock binding IMO. Describing some clocks and not > others is not a good solution. > > For example, let's look at bcm-cygnus as one of the single clock > examples. The first thing I notice is there is a apb_pclk already > defined. The pl330 uses it. The watchdog (also Primecell) lists the > source clock twice. So what should pl022 be? IDK, ask the Broadcom > folks. If they don't know, then list the source clock twice. That's > effectively no change from what we have now. Yes, I took motivation from sp805 watchdog(primecell) while resolving DT conflicts. I found LG and amd seattle platform with single clock in DT for which I have sent patches. Link is below: https://lore.kernel.org/linux-devicetree/CAL_Jsq+k+ridWTkdy4xwTC7VxUTU8tu+Q2BA9kbQVA222PWvZw@mail.gmail.com/ Moreover, I observed that clocks and clock-names are not required properties for pl022. I am wondering reason behind the same when you first made changes. Any specific reason not adding them which I am not aware of or it just got missed? - Kuldeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel