From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27143C433EF for ; Fri, 11 Mar 2022 02:58:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nl741nIQcieagE5NLr8bRGkqcGQsxJztPKt80z30lng=; b=o4uEUkRiD3p9RY NJIRX2MoDJ5bFpmE/2sEHco9GWHSE6UsnFu790TM/5rwX8ggeDFoAhygluVCsvTZbwxszgorlumx3 i52XMrZ5hD02PZwCP+ylqwfVsClT72eVJDYyw14NXAR3nsZ47K8GdP7xxZjk4JZf3UaVEkyvKRMRb CUeCRhgKJU8zHe0YC0FiuGMUKxauPYyhurY5cj/scvVoUmLksK1tBJEcogONPVSk2+OFrhKLt/fbE faY9Zcxba/yUk/vkLT4PvjcOhLaFUBEXXbSKrETaycMoyNK2PErLCYGf7aHVCbW3pSBdHe9XJow93 G95eAGYi3IasQNIneWvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSVT8-00Ep2h-Tw; Fri, 11 Mar 2022 02:57:31 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSVT5-00Ep24-Kj for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 02:57:29 +0000 Received: by mail-pl1-x634.google.com with SMTP id q11so6562824pln.11 for ; Thu, 10 Mar 2022 18:57:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4mGxAN+bed1cqRQjQBn14iEXY6BzLxG8/XtH3YgM+/k=; b=T0Mdk7vH8MtnRfu/Wx3qs6mOhHVbz80A7BVVjjimvvdVk9VcoFXwMj1T8FhvWQzn8Z N0kwQnatyWXjjAGyFinRgfToBFobpnHD3jyd2mr1ZRD4B2bZEfZVEFdpnT9dX5e2H9fk DVDWS1+EBLA03RUJFcBtajOi+8gE+rjUgp7s1HF/sgohdZ563OgfgHB7kAdjrFwigWZp vXkf16gexWdVifGv+bRMg93eEOiyoB/hYtKPU8G/38lHsITTPG4nNU44tfXN2SEN2c+Z ttJDzAOJPK6fHm9uUcJoDRQoRtdCoLZr7aaoOaduw6/A2IBI43RYEYrCey1+Dh4vgDN4 Db3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4mGxAN+bed1cqRQjQBn14iEXY6BzLxG8/XtH3YgM+/k=; b=KzuY/8wUZ5T/K3tKYy0cvAjP0n15V5kOiKhXdIzSlywfkezpevWSupautHqdqtUDbM BKCoXQ7zjbOfmm1kTl6hGshg15Jps6gj3dwizzKZhFIG0YgWUEZe+DGDSaUjhHAWiqDq DAPibIYypM3iNDCsFwO+WUlnEglJtj0b6lJ9yAOk3oIFioQrSyB/y+C8Ayr6EPt6zMq2 5pU/Lp6bS6e5x4J78aJZ6TtKlkTqioi0LeHmRJ44TFArPU+vpvuXWyx2lncbUM5fqisN KTp+d6KVzU8pm6uKHGqPFyKGXdYbndUo9MZIdCPO7p1MrFwCO3CPz6K6c2vt+mlzqDYQ HBMQ== X-Gm-Message-State: AOAM533dtpLFsqdNkci1+/MuqSh9jl0u7MitlSBiAXDWn06AsXMgQZmG tUHrPNHARuOmits8p74cR1IpyigkX0JfZQ== X-Google-Smtp-Source: ABdhPJwiPqnzVkUBtFFNnYqrm+dgYTz7h1VmEwvXmIyRsmDM+Jrty/3vhZCYwjPZQTW1zWaE2QYNPw== X-Received: by 2002:a17:903:22cb:b0:151:9f41:8738 with SMTP id y11-20020a17090322cb00b001519f418738mr8338166plg.46.1646967446844; Thu, 10 Mar 2022 18:57:26 -0800 (PST) Received: from 9a2d8922b8f1 ([122.161.53.68]) by smtp.gmail.com with ESMTPSA id b62-20020a633441000000b0037c794cb68fsm6525593pga.9.2022.03.10.18.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 18:57:26 -0800 (PST) Date: Fri, 11 Mar 2022 08:27:21 +0530 From: Kuldeep Singh To: Rob Herring Cc: Mark Brown , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Robin Murphy , Linus Walleij , Krzysztof Kozlowski Subject: Re: [PATCH v2 2/2] dt-bindings: spi: Update clock-names property for ARM pl022 Message-ID: <20220311025721.GC54098@9a2d8922b8f1> References: <20220308072125.38381-1-singh.kuldeep87k@gmail.com> <20220308072125.38381-2-singh.kuldeep87k@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220310_185727_706309_D028AF5F X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 10, 2022 at 04:08:42PM -0600, Rob Herring wrote: > On Tue, Mar 08, 2022 at 12:51:25PM +0530, Kuldeep Singh wrote: > > Pl022 clock-names can be one of following: > > ['apb_pclk'] or ['sspclk', 'apb_pclk'] > > > > The current schema refers to second case only. Make necessary changes to > > incorporate both the cases and resolve below dtc warning: > > clock-names: 'apb_pclk' is not one of ['sspclk'] > > > > Signed-off-by: Kuldeep Singh > > --- > > v2: > > - Reword commit message > > - Drop SSPCLK > > > > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > > index 7d36e15db5b3..6cfab948624e 100644 > > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > > @@ -38,11 +38,13 @@ properties: > > maxItems: 2 > > > > clock-names: > > - items: > > + oneOf: > > - enum: > > - - SSPCLK > > - - sspclk > > - - const: apb_pclk > > + - apb_pclk > > Are you going to make the driver work with no SPI clock? Because this > change is saying that it is valid to have the APB bus clock and no SPI > clock. Kindly take a loot at newer version to this series as this one is deprecated. https://lore.kernel.org/linux-spi/20220309171847.5345-1-singh.kuldeep87k@gmail.com/ - Kuldeep > > Rob > > > + - items: > > + - enum: > > + - sspclk > > + - const: apb_pclk > > > > pl022,autosuspend-delay: > > description: delay in ms following transfer completion before the > > -- > > 2.25.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel