From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55BA3C433EF for ; Fri, 11 Mar 2022 09:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TTBheAZhOcydlol6aw6HVFr0RLzVhAdePYRavUUUk0M=; b=BsHH+2pHTV3GVV +h+bAiyUx+ffW19oQDPtcFjUiJiQpZwo19VISIM9qvRC8ob57eK4LweChTBXjwPOODrjAA0bJ82Uy 6Tgx89KimUP+UHnhyRF51jOI6kOJhuScM+qkv1X6DbNGCmpe9pYWG6F2b1Y9xoHAruqTceP/+0P0h YqEtfCZWla2rk2M7F5ZbdF/kNQ60oJ40nkF8pxkgkX+9x0yrA0QBahJxevcleHTM9Su3SVihvo/IZ 8rW6A/3Ji/g2fcMKgAHNSMVwLEDyriSTuycMdTi5fays2epnc07UhEZeBZ4hhwuvi1s52HtfG00Bf 11rWYf5qAQs/FsLzFZ7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSbBy-00FlDj-7p; Fri, 11 Mar 2022 09:04:10 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSbBu-00FlCG-Mt for linux-arm-kernel@lists.infradead.org; Fri, 11 Mar 2022 09:04:08 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSb9e-0006HK-2F; Fri, 11 Mar 2022 10:01:46 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nSb9c-0003GS-FT; Fri, 11 Mar 2022 10:01:44 +0100 Date: Fri, 11 Mar 2022 10:01:44 +0100 From: Oleksij Rempel To: Alifer Moraes Cc: linux-kernel@vger.kernel.org, pierluigi.p@variscite.com, Fugang Duan , shawnguo@kernel.org, s.hauer@pengutronix.de, gaopan , linux@rempel-privat.de, eran.m@variscite.com, linux-i2c@vger.kernel.org, kernel@pengutronix.de, Vipul Kumar , festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: Re: [PATCH] i2c: imx: add irqf_no_suspend Message-ID: <20220311090144.GB9910@pengutronix.de> References: <20220307143630.28697-1-alifer.m@variscite.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220307143630.28697-1-alifer.m@variscite.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:59:39 up 90 days, 17:45, 82 users, load average: 0.16, 0.17, 0.11 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220311_010406_755092_6DEBD0C8 X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 07, 2022 at 11:36:30AM -0300, Alifer Moraes wrote: > From: gaopan > > The i2c irq is masked when pcie starts a i2c transfer process > during noirq suspend stage. As a result, i2c transfer fails. > To solve the problem, IRQF_NO_SUSPEND is added to i2c bus. > > Signed-off-by: Gao Pan > Signed-off-by: Fugang Duan > Signed-off-by: Vipul Kumar Reviewed-by: Oleksij Rempel Thank you! > --- > drivers/i2c/busses/i2c-imx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index 27f969b3dc07..fcc09a1e7f44 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1478,7 +1478,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > goto rpm_disable; > > /* Request IRQ */ > - ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, > + ret = request_threaded_irq(irq, i2c_imx_isr, NULL, > + IRQF_SHARED | IRQF_NO_SUSPEND, > pdev->name, i2c_imx); > if (ret) { > dev_err(&pdev->dev, "can't claim irq %d\n", irq); > -- > 2.25.1 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel