* [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Pass 'adv,force-bt656-4'
@ 2022-03-15 1:32 Fabio Estevam
2022-03-15 1:32 ` [PATCH 2/2] ARM: dts: imx6-gw5xxx: " Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2022-03-15 1:32 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, tharvey, Fabio Estevam
A common problem on imx6 designs with AD7180 is that video may get
out sync, producing a 'rolling' image.
Pass 'adv,force-bt656-4' to avoid such problem.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
index 5e58740d40c5..9960f0b31ba9 100644
--- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
@@ -177,6 +177,7 @@ i2c@1 {
adv7180: camera@21 {
compatible = "adi,adv7180";
reg = <0x21>;
+ adv,force-bt656-4;
powerdown-gpios = <&max7310_b 2 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio1>;
interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: imx6-gw5xxx: Pass 'adv,force-bt656-4'
2022-03-15 1:32 [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Pass 'adv,force-bt656-4' Fabio Estevam
@ 2022-03-15 1:32 ` Fabio Estevam
2022-03-15 15:20 ` Tim Harvey
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2022-03-15 1:32 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, tharvey, Fabio Estevam
A common problem on imx6 designs with AD7180 is that video may get
out sync, producing a 'rolling' image.
Pass 'adv,force-bt656-4' to avoid such problem.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6dl-gw52xx.dts | 1 +
arch/arm/boot/dts/imx6dl-gw53xx.dts | 1 +
arch/arm/boot/dts/imx6dl-gw54xx.dts | 1 +
arch/arm/boot/dts/imx6q-gw52xx.dts | 1 +
arch/arm/boot/dts/imx6q-gw53xx.dts | 1 +
arch/arm/boot/dts/imx6q-gw54xx.dts | 1 +
arch/arm/boot/dts/imx6qdl-gw51xx.dtsi | 1 +
arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 1 +
8 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/imx6dl-gw52xx.dts b/arch/arm/boot/dts/imx6dl-gw52xx.dts
index 9ea23dd54f3c..7e52ff8a37c3 100644
--- a/arch/arm/boot/dts/imx6dl-gw52xx.dts
+++ b/arch/arm/boot/dts/imx6dl-gw52xx.dts
@@ -18,6 +18,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio3>;
interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
diff --git a/arch/arm/boot/dts/imx6dl-gw53xx.dts b/arch/arm/boot/dts/imx6dl-gw53xx.dts
index 182e8194c249..5c0a3f4b208b 100644
--- a/arch/arm/boot/dts/imx6dl-gw53xx.dts
+++ b/arch/arm/boot/dts/imx6dl-gw53xx.dts
@@ -18,6 +18,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio3>;
interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
diff --git a/arch/arm/boot/dts/imx6dl-gw54xx.dts b/arch/arm/boot/dts/imx6dl-gw54xx.dts
index a106c4e3e329..22346d46805d 100644
--- a/arch/arm/boot/dts/imx6dl-gw54xx.dts
+++ b/arch/arm/boot/dts/imx6dl-gw54xx.dts
@@ -18,6 +18,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio3>;
interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
diff --git a/arch/arm/boot/dts/imx6q-gw52xx.dts b/arch/arm/boot/dts/imx6q-gw52xx.dts
index 6e1c493c9c8c..c8fe6ea33492 100644
--- a/arch/arm/boot/dts/imx6q-gw52xx.dts
+++ b/arch/arm/boot/dts/imx6q-gw52xx.dts
@@ -18,6 +18,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio3>;
interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
diff --git a/arch/arm/boot/dts/imx6q-gw53xx.dts b/arch/arm/boot/dts/imx6q-gw53xx.dts
index f13df8e9c8c4..a62a3b02029a 100644
--- a/arch/arm/boot/dts/imx6q-gw53xx.dts
+++ b/arch/arm/boot/dts/imx6q-gw53xx.dts
@@ -18,6 +18,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio3>;
interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
diff --git a/arch/arm/boot/dts/imx6q-gw54xx.dts b/arch/arm/boot/dts/imx6q-gw54xx.dts
index d5d46908cf6e..7725e1fb0b92 100644
--- a/arch/arm/boot/dts/imx6q-gw54xx.dts
+++ b/arch/arm/boot/dts/imx6q-gw54xx.dts
@@ -35,6 +35,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio3>;
interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
diff --git a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi
index 069c27fab432..e367084d15f5 100644
--- a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi
@@ -369,6 +369,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio5>;
interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
diff --git a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
index 4662408b225a..905d4260db4c 100644
--- a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
@@ -424,6 +424,7 @@ adv7180: camera@20 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_adv7180>;
reg = <0x20>;
+ adv,force-bt656-4;
powerdown-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
interrupt-parent = <&gpio5>;
interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ARM: dts: imx6-gw5xxx: Pass 'adv,force-bt656-4'
2022-03-15 1:32 ` [PATCH 2/2] ARM: dts: imx6-gw5xxx: " Fabio Estevam
@ 2022-03-15 15:20 ` Tim Harvey
2022-03-15 16:05 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Tim Harvey @ 2022-03-15 15:20 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Shawn Guo, Linux ARM Mailing List
On Mon, Mar 14, 2022 at 6:32 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> A common problem on imx6 designs with AD7180 is that video may get
> out sync, producing a 'rolling' image.
>
> Pass 'adv,force-bt656-4' to avoid such problem.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm/boot/dts/imx6dl-gw52xx.dts | 1 +
> arch/arm/boot/dts/imx6dl-gw53xx.dts | 1 +
> arch/arm/boot/dts/imx6dl-gw54xx.dts | 1 +
> arch/arm/boot/dts/imx6q-gw52xx.dts | 1 +
> arch/arm/boot/dts/imx6q-gw53xx.dts | 1 +
> arch/arm/boot/dts/imx6q-gw54xx.dts | 1 +
> arch/arm/boot/dts/imx6qdl-gw51xx.dtsi | 1 +
> arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 1 +
> 8 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6dl-gw52xx.dts b/arch/arm/boot/dts/imx6dl-gw52xx.dts
> index 9ea23dd54f3c..7e52ff8a37c3 100644
> --- a/arch/arm/boot/dts/imx6dl-gw52xx.dts
> +++ b/arch/arm/boot/dts/imx6dl-gw52xx.dts
> @@ -18,6 +18,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> diff --git a/arch/arm/boot/dts/imx6dl-gw53xx.dts b/arch/arm/boot/dts/imx6dl-gw53xx.dts
> index 182e8194c249..5c0a3f4b208b 100644
> --- a/arch/arm/boot/dts/imx6dl-gw53xx.dts
> +++ b/arch/arm/boot/dts/imx6dl-gw53xx.dts
> @@ -18,6 +18,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> diff --git a/arch/arm/boot/dts/imx6dl-gw54xx.dts b/arch/arm/boot/dts/imx6dl-gw54xx.dts
> index a106c4e3e329..22346d46805d 100644
> --- a/arch/arm/boot/dts/imx6dl-gw54xx.dts
> +++ b/arch/arm/boot/dts/imx6dl-gw54xx.dts
> @@ -18,6 +18,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> diff --git a/arch/arm/boot/dts/imx6q-gw52xx.dts b/arch/arm/boot/dts/imx6q-gw52xx.dts
> index 6e1c493c9c8c..c8fe6ea33492 100644
> --- a/arch/arm/boot/dts/imx6q-gw52xx.dts
> +++ b/arch/arm/boot/dts/imx6q-gw52xx.dts
> @@ -18,6 +18,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> diff --git a/arch/arm/boot/dts/imx6q-gw53xx.dts b/arch/arm/boot/dts/imx6q-gw53xx.dts
> index f13df8e9c8c4..a62a3b02029a 100644
> --- a/arch/arm/boot/dts/imx6q-gw53xx.dts
> +++ b/arch/arm/boot/dts/imx6q-gw53xx.dts
> @@ -18,6 +18,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> diff --git a/arch/arm/boot/dts/imx6q-gw54xx.dts b/arch/arm/boot/dts/imx6q-gw54xx.dts
> index d5d46908cf6e..7725e1fb0b92 100644
> --- a/arch/arm/boot/dts/imx6q-gw54xx.dts
> +++ b/arch/arm/boot/dts/imx6q-gw54xx.dts
> @@ -35,6 +35,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio3>;
> interrupts = <30 IRQ_TYPE_LEVEL_LOW>;
> diff --git a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi
> index 069c27fab432..e367084d15f5 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi
> @@ -369,6 +369,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio5>;
> interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
> diff --git a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> index 4662408b225a..905d4260db4c 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi
> @@ -424,6 +424,7 @@ adv7180: camera@20 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_adv7180>;
> reg = <0x20>;
> + adv,force-bt656-4;
> powerdown-gpios = <&gpio5 20 GPIO_ACTIVE_LOW>;
> interrupt-parent = <&gpio5>;
> interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.25.1
>
Fabio,
This was done to support ADV7280's but the original boards have an
ADV7180. I think its ok to set this even for ADV7180's as the codepath
that uses it won't get hit correct?
I had originally handled this via boot firmware that updated dt per
board model [1][2] but if there is no harm having it set for ADV7180's
as well I'm good with this patch.
Best regards,
Tim
[1] https://github.com/u-boot/u-boot/commit/249ee657e620829b0ebe119936d0e82c83534b45
[2] https://github.com/u-boot/u-boot/commit/bf6bdefd36cfaa53fb4e492e160a9b7349c01d3d
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ARM: dts: imx6-gw5xxx: Pass 'adv,force-bt656-4'
2022-03-15 15:20 ` Tim Harvey
@ 2022-03-15 16:05 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2022-03-15 16:05 UTC (permalink / raw)
To: Tim Harvey; +Cc: Shawn Guo, Linux ARM Mailing List
Hi Tim,
On Tue, Mar 15, 2022 at 12:20 PM Tim Harvey <tharvey@gateworks.com> wrote:
> Fabio,
>
> This was done to support ADV7280's but the original boards have an
> ADV7180. I think its ok to set this even for ADV7180's as the codepath
> that uses it won't get hit correct?
You are correct. The board I tested this fix was based on ADV7280, not ADV7180.
Let's drop this series.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-15 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-15 1:32 [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Pass 'adv,force-bt656-4' Fabio Estevam
2022-03-15 1:32 ` [PATCH 2/2] ARM: dts: imx6-gw5xxx: " Fabio Estevam
2022-03-15 15:20 ` Tim Harvey
2022-03-15 16:05 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).