From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68832C433EF for ; Wed, 16 Mar 2022 17:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uq/+lhGuQbAMOwcgLeP1yTfCkelk3N+tz7/Kxe4MaMo=; b=pVhWzn3OC7y0ty 6amXyOwh2IsSLbqVfYNMkRbDqIWsR7vtHjhrJUhZpG/e+8z1xoiyO6oWUrprk80/R12XVfuE9SxBA Qr3lbvmSDtc6PY+v2xErB2CXsGzSRWSQa0vriRw7/jAOxnHZYJXaCvlZqdPoKoQzwOjKkbruZRjCF bWUFuevtn1Cb18i5ekgbhhSqOYtNzrmZgyf7cynfgGW825Dn+oA3bryG4XUN0ANdbyXyd2ZMjg/R2 j759hz5aAZvk/bAR2iBttOvuKPJJhniXq7L+HH0OaLzRpKEtd9yvx33WyE4nB5SwXsxBc/pPmLcop 6HgR+Xn/U5lzDy6zDaiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUXe9-00E1pi-Qc; Wed, 16 Mar 2022 17:41:17 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUXe7-00E1oh-AN for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 17:41:16 +0000 Received: by mail-pl1-x629.google.com with SMTP id n18so2396554plg.5 for ; Wed, 16 Mar 2022 10:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3Ow+kGtiOY3oh5aaxxEMEYzkd7Bfkm111SMhgSjbTYc=; b=NyKZ2dMQyhMPO9PAhi+GiL/xXA9vyF4L9XDAYzCXVbTfTSJlLWYJ3gax9kK3nXXDIJ 4k9CoGMlJ9U1vx9j065MJYu8hx+2+V0SBQMmuCsQlUGEcLO13IzM58ef4cZJzM7wuyX9 wsUThhe6UWlDwnWZ0VTblKmn41h5S83ZxWMqnVMDacTU8fpfcWQcbB0ukQPC36v0rv3D 1V2gx4iohIzUOb+0R/DR7xXC/+nHz3pAhHlPgbvKkAF8B7CVIkDWWFEd3kL1phGI8GDk E6+bklRHx4K4+ADhC+6Y01iHXlYCNdMMhlUOVIeSKXFohfaJ6xLKbit4vglL4shLUGvm 5Aag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3Ow+kGtiOY3oh5aaxxEMEYzkd7Bfkm111SMhgSjbTYc=; b=LYYJgPE6+7QBQVCpGPEQNg0HnpmV7zYEkobhsGBOdtehQgEs031EqttgNOvZec5/ix Ed6vGXDtFpr4E6vk9YsjtGLq/gSipqQqWuSR46n63a8kbdW2Y8PsXQl4CC5GzWNVYwZD Nu5ypfvmHMfdvd4dGkeLn3DdonL/se1OGl+WumplhFY/6o80pe1RNezdKP2GI8THwgNg UeN8AE6cOkV+b+7IBt2FIN+dl7pQJYud0gJWzvRcMR/02616Xwvcd1sdVnid54HLII25 7GlgL9yEo+tlkpPmJJSukw8NwraIz46q2v+CcEx1xpWQUG5u1AiXAcs/bIt2rcuW/Nxq OoMg== X-Gm-Message-State: AOAM531MWJnUxtKRxnDYY0dsoTz1GYrIo5w2jRYxSnei2LP2Azvd/F7p NKekYFJeQ4DoyVRVbwsMuGA= X-Google-Smtp-Source: ABdhPJylMLMEhg/D+2mxXnfYjAYghwhK/xve8O7Layo/rR+2MMj5hsK0594Ke4+TFFyn2R2xQel1uw== X-Received: by 2002:a17:90b:4f4e:b0:1bf:88f6:e5b5 with SMTP id pj14-20020a17090b4f4e00b001bf88f6e5b5mr11430312pjb.47.1647452474263; Wed, 16 Mar 2022 10:41:14 -0700 (PDT) Received: from 9a2d8922b8f1 ([122.161.51.18]) by smtp.gmail.com with ESMTPSA id y21-20020a056a00191500b004f78813b2d6sm4223887pfi.178.2022.03.16.10.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 10:41:14 -0700 (PDT) Date: Wed, 16 Mar 2022 23:11:08 +0530 From: Kuldeep Singh To: Krzysztof Kozlowski , Marc Zyngier Cc: Marc Zyngier , Mark Rutland , Marc Zyngier , Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list Message-ID: <20220316174108.GB21737@9a2d8922b8f1> References: <20220316095433.20225-1-singh.kuldeep87k@gmail.com> <20220316095433.20225-4-singh.kuldeep87k@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_104115_392630_477511E3 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 16, 2022 at 05:30:26PM +0100, Krzysztof Kozlowski wrote: > On 16/03/2022 10:54, Kuldeep Singh wrote: > > Few platforms such as Renesas RZ/N1D, Calxeda, Alpine etc. are using > > arm,cortex-a15-timer and arm,cortex-a7-timer entries in conjugation with > > arm,armv7-timer which are not currently defined in driver file. Add > > these entries in arch_timer_of_match list to bring them in use. > > > > This looks wrong (also Marc pointed this out) and rationale is not > sufficient. Why do you need these compatibles in the driver? Hi Krzysztof and Marc, I find myself in trouble whenever dealing with compatible entries and had 2 options when I stumble this issue. 1. Remove unused compatible 2. Add required compatible to binding and driver My past experience and advise from other developer says not to remove an existing compatible. And also I found "arm,cortex-a15-timer" in binding which was again not documented and was present in DT. This prompted me to go for second option and make necessary additions in binding and driver following current entries. As per your perspective, current configuration isn't apt which means "arm,cortex-a15-timer" is a stub and is wrongly present in binding. I also observed many other DTs have compatibles which are not present in driver. What is an ideal idealogy behind such cases? - Kuldeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel