From: Lukasz Luba <lukasz.luba@arm.com>
To: linux-kernel@vger.kernel.org
Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com,
Pierre.Gondois@arm.com, ionela.voinescu@arm.com,
viresh.kumar@linaro.org, rafael@kernel.org,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
mka@chromium.org, nm@ti.com, sboyd@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, cristian.marussi@arm.com,
sudeep.holla@arm.com, matthias.bgg@gmail.com
Subject: [[PATCH 2/8] PM: EM: Add artificial EM flag
Date: Wed, 16 Mar 2022 23:52:05 +0000 [thread overview]
Message-ID: <20220316235211.29370-3-lukasz.luba@arm.com> (raw)
In-Reply-To: <20220316235211.29370-1-lukasz.luba@arm.com>
From: Pierre Gondois <Pierre.Gondois@arm.com>
The Energy Model (EM) can be used on platforms which are missing real
power information. Those platforms would implement .get_cost() which
populates needed values for the Energy Aware Scheduler (EAS). The EAS
doesn't use 'power' fields from EM, but other frameworks might use them.
Thus, to avoid miss-usage of this specific type of EM, introduce a new
flags which can be checked by other frameworks.
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
include/linux/energy_model.h | 5 +++++
kernel/power/energy_model.c | 2 ++
2 files changed, 7 insertions(+)
diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
index 0a3a5663177b..92e82a322859 100644
--- a/include/linux/energy_model.h
+++ b/include/linux/energy_model.h
@@ -67,11 +67,16 @@ struct em_perf_domain {
*
* EM_PERF_DOMAIN_SKIP_INEFFICIENCIES: Skip inefficient states when estimating
* energy consumption.
+ *
+ * EM_PERF_DOMAIN_ARTIFICIAL: The power values are artificial and might be
+ * created by platform missing real power information
*/
#define EM_PERF_DOMAIN_MILLIWATTS BIT(0)
#define EM_PERF_DOMAIN_SKIP_INEFFICIENCIES BIT(1)
+#define EM_PERF_DOMAIN_ARTIFICIAL BIT(2)
#define em_span_cpus(em) (to_cpumask((em)->cpus))
+#define em_is_artificial(em) ((em)->flags & EM_PERF_DOMAIN_ARTIFICIAL)
#ifdef CONFIG_ENERGY_MODEL
#define EM_MAX_POWER 0xFFFF
diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
index 0153b0ca7b23..6ecee99af842 100644
--- a/kernel/power/energy_model.c
+++ b/kernel/power/energy_model.c
@@ -384,6 +384,8 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states,
if (milliwatts)
dev->em_pd->flags |= EM_PERF_DOMAIN_MILLIWATTS;
+ else if (cb->get_cost)
+ dev->em_pd->flags |= EM_PERF_DOMAIN_ARTIFICIAL;
em_cpufreq_update_efficiencies(dev);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-16 23:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 23:52 [0/8] Introduce support for artificial Energy Model Lukasz Luba
2022-03-16 23:52 ` [[PATCH 1/8] PM: EM: Add .get_cost() callback Lukasz Luba
2022-03-16 23:52 ` Lukasz Luba [this message]
2022-03-16 23:52 ` [[PATCH 3/8] PM: EM: Use the new .get_cost() callback while registering EM Lukasz Luba
2022-03-16 23:52 ` [[PATCH 4/8] PM: EM: Change the order of arguments in the .active_power() callback Lukasz Luba
2022-03-16 23:52 ` [[PATCH 5/8] PM: EM: Remove old debugfs files and print all 'flags' Lukasz Luba
2022-03-16 23:52 ` [[PATCH 6/8] Documentation: EM: Add artificial EM registration description Lukasz Luba
2022-03-16 23:52 ` [[PATCH 7/8] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Lukasz Luba
2022-03-16 23:52 ` [[PATCH 8/8] powercap: DTPM: Check for Energy Model type Lukasz Luba
2022-03-29 13:29 ` [0/8] Introduce support for artificial Energy Model Cristian Marussi
2022-03-29 13:39 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316235211.29370-3-lukasz.luba@arm.com \
--to=lukasz.luba@arm.com \
--cc=Pierre.Gondois@arm.com \
--cc=cristian.marussi@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox