From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0915C433EF for ; Fri, 18 Mar 2022 02:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n2AQLGubMzToF6VxPHrr0/wzOtRDNF5kT8xRzzKs9nM=; b=D9mXM3wQmxRfYj+g8g8neFLyI0 lQackWFVxi+LRiVmlffIh+IJfNLXwVzTq6w3LyvXXV4a/GONWTr67DTWNHNNaFu3dzhkZ1IBg9jiX j8mhX9qwK8EanWsrL8ZNDjcE3cpwc9Y7VQXazj4ii4aaXTdBSnlsAgVTyLMDTfuhuUvxipQMbkAiE 5/pWznFt9q9FevUzcAaswETDmyuUPXOxZouKEAv3eMb9U8srTzYgBHE0EJuHHiKmrIfNEu4eqw8CL ENdHQT4+7KEYnaPHHi03HrhvDenm52ymLFZJKmH/9vBB5rMEMYJU0rsBoTu9Xr12HgPipz39WBVVn V2X4XgdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV2hD-000Ccp-Kn; Fri, 18 Mar 2022 02:50:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV2h9-000CbI-KG for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 02:50:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647571825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TtfpIMh0hjxedFN+Tl6gjaJX+areyDNcJNycJbTZTWE=; b=ajsIZD6AR0kdeUDPLo/xgsVvU8LfQN0uVVjO3UlTq9I7t4OEZVeI/LvwoeU7JJZOxyB7DU qyFXkBBR7wIlVWjkos43J89jESH1dIMu4NKqYemgah2qICAQ5dPXPdsvnxzCcW04eXl+u6 5Jyueum/xkL2W/WpS4b+b8tRDzrpYlc= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-IGO6du3hNcy9nxHCQGzsPQ-1; Thu, 17 Mar 2022 22:50:21 -0400 X-MC-Unique: IGO6du3hNcy9nxHCQGzsPQ-1 Received: by mail-pj1-f70.google.com with SMTP id o6-20020a17090a9f8600b001c640fa1499so4303583pjp.3 for ; Thu, 17 Mar 2022 19:50:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TtfpIMh0hjxedFN+Tl6gjaJX+areyDNcJNycJbTZTWE=; b=XkTuS30rq1VqEyV03PU+ZLZxZhio+/qrdX6nrQND3VqovX6IgMVnqPrkOKdnSkRE7L ub3d0b3NiPcfbj3MJvM5sreXDrgHwv1ATGqVWkZpjkmCVneFVS+dypNluW64hsoaHxHQ /XbrSIlf6t9xLzM6num309IQU8RLAPo/AfHE6rRaxHj809BLt2pgDoz+g7Ci+DlK44Dj zaIVrtaoHZKXzIAWP/BcRyqqDnXii7Bq5DRh0F+HeAQrxG+1Z2IUg0Ilx4uEGaVU6ygJ Z916JbBpM9t3Wsole64ovW+9/vACmgxudtEcygVE+4PUHvJuzMCvE1b7mp3uMOmq1IXG 56FQ== X-Gm-Message-State: AOAM532jHaBTX8NirkdsUmzbumq7ELfOlO9va2VuQMsN0udEvB0Ij5x4 7yRGaTo91Q1869zzu5tUzcn3oLo6xsJMFXYkIGdtPGfvZ0bmd66WtqsfO3vlEORSFrw8i8D71eX 3LeJtaF9Nb89lSrngagL91m86V/aPaCYT+1c= X-Received: by 2002:a17:90b:33c4:b0:1c6:8598:d4bf with SMTP id lk4-20020a17090b33c400b001c68598d4bfmr6424463pjb.81.1647571820765; Thu, 17 Mar 2022 19:50:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLt3zIH+QYFTliBGLEDR7sfnoegdpTP4CMfMVwJSbXOQs/6+T0WT6xwVyNg/L20iUDcgdmXg== X-Received: by 2002:a17:90b:33c4:b0:1c6:8598:d4bf with SMTP id lk4-20020a17090b33c400b001c68598d4bfmr6424436pjb.81.1647571820410; Thu, 17 Mar 2022 19:50:20 -0700 (PDT) Received: from localhost ([240e:3a1:2e5:800:f995:6136:f760:a3d0]) by smtp.gmail.com with ESMTPSA id b13-20020a056a00114d00b004c122b90703sm8097199pfm.27.2022.03.17.19.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Mar 2022 19:50:19 -0700 (PDT) Date: Fri, 18 Mar 2022 10:48:03 +0800 From: Coiby Xu To: Baoquan He Cc: Coiby Xu , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Young , Will Deacon , "Eric W . Biederman" , open list Subject: Re: [RESEND PATCH v3 1/3] kexec: clean up arch_kexec_kernel_verify_sig Message-ID: <20220318024803.pkkwgknwur2y75mt@Rk> References: <20220304020341.85583-1-coiby.xu@gmail.com> <20220304020341.85583-2-coiby.xu@gmail.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=coxu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_195027_849249_B8080829 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 17, 2022 at 08:45:35PM +0800, Baoquan He wrote: >On 03/04/22 at 10:03am, Coiby Xu wrote: >> From: Coiby Xu >> >> commit 9ec4ecef0af7790551109283ca039a7c52de343c ("kexec_file,x86, >> powerpc: factor out kexec_file_ops functions" allows implementing >> the arch-specific implementation of kernel image verification >> in kexec_file_ops->verify_sig. Currently, there is no arch-specific >> implementation of arch_kexec_kernel_verify_sig. So clean it up. > >This is a nice cleanup, while the log may need to be improved. You >should run ./scripts/checkpatch.pl on your patch before sending out. >When we refer to a commit in log, please refer to >Documentation/process/submitting-patches.rst. Thanks for the reminder! I've used git pre-commit hook to run scripts/checkpatch.pl automatically but obviously this hook doesn't apply to "git rebase --continue" and currently this no git hook that for this situation. I'll use the following trick [1] to avoid this mistake in the future, $ git rebase -i HEAD~3 --reschedule-failed-exec --exec "git show | perl ./scripts/checkpatch.pl" [1] https://stackoverflow.com/a/70568833/1203522 -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel