From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D363FC433F5 for ; Fri, 18 Mar 2022 07:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vyl64BE2dhCknwuCxX5sKh9Zm3n2yIDvDw7FFEb7obU=; b=NAZ5oytYBLjqQU07qTec5Z9QLZ Qa5pTUoXADQ0WPHpKljD5GtoASPAJ5rOQz/46YTpHy70VirF+W/KfaNP32oacg3yxI5g6SxJNQP+R a+cFo/v0QBdTjKJW2/GDc9GXKv7D444uj1VEKVrvSOV50FvpBcjnEsx7rkiKzduWJa0rqvMFli2K3 LHS+XAQS32Nt/l81McEhBSo/Eo6x4Ihx6ZgPZbe4hIHIt/8AwoSdb/kDKG3dz1GVPLwChMCtkV0x0 cE/JkeX4dYvY4GAT46TNAFrdtLmDs14Zgj1PGapKSwXQI38Dy4o+wbfJVzqBmKJ8E7TT6KL4I+63k kjQ+X5yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV6uV-000aU8-7V; Fri, 18 Mar 2022 07:20:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV6uQ-000aSv-6S for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 07:20:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647588025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+24uwlQGfg14hQYJfSh/53X6TSpkqAT/khxrLaLZ2Lc=; b=bk97R1RqX90SWPvvut2SWDWrv2MK6JobuKHBLI6V8YfUVhCnNZ2gt+eCczJDctJj0j2O9v Z4t0k0ztXG1gXuXmPYziD5j3onDvMWFXjl1FXCDv2PwqpFP9CLHy5dszPrUgZdy5HFD+WE mQ9jqqEfHV+lXzW/47I3uLi6YNwnDOg= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-WjlMqDWxNT2dBNINYAe5Xg-1; Fri, 18 Mar 2022 03:20:22 -0400 X-MC-Unique: WjlMqDWxNT2dBNINYAe5Xg-1 Received: by mail-pj1-f69.google.com with SMTP id o12-20020a17090a420c00b001c65aec76c0so4131385pjg.8 for ; Fri, 18 Mar 2022 00:20:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+24uwlQGfg14hQYJfSh/53X6TSpkqAT/khxrLaLZ2Lc=; b=E/Sq2Eec5woJPdsRweyn8wto/SEQcTx1VStW9XaHArIRwxEsMEY0K24pLOUM8V/Reb 2plAucE34MEf5Pkk01UBpm1N0okLc1ixYne/SCoacX/MrntFRZm+9HF/Fnl9w8ouH3UY TzshEiYESzDygWq4ARFCUZRRi/H7vb4wbLBC8fNd0GgawJVyz5ssshMEy4Lkv7Xp/+L9 M+iS1avaEZHTkGNzxoVOZtTDGi6LJE+O4dyk8shqtujIHQoGaSUIYJGUyoaxWGR60Pl8 aI+r44/Ooyv2Wgh066bnJGWdduii5MDN+jyvgDdWjXO5ShCAh7Fa9qJHnlaiygD8bUnN xAJQ== X-Gm-Message-State: AOAM5316qC8RcGUzysW72PfEjNdA4bSMjlAZYuADHqDlTqiHGW7EQZ9D U6A2ewavcb90tIVMmTbOolIHyH+vwB1MMJC4o7xad5hEHdqXWztECL9bru5HP3JtyyFsY520X+P oEhUPeTWbjIJAlkmZq5qZMgMg2y9B6BvY8pc= X-Received: by 2002:a17:902:9b92:b0:153:99b1:1e94 with SMTP id y18-20020a1709029b9200b0015399b11e94mr8839846plp.2.1647588020968; Fri, 18 Mar 2022 00:20:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9Km9O8/P3mK5wn3uIW+zCeYpBsOqzvKmwY8+qMwFLV2pOroryTl/thhqanK4bFwNobKi/xQ== X-Received: by 2002:a17:902:9b92:b0:153:99b1:1e94 with SMTP id y18-20020a1709029b9200b0015399b11e94mr8839819plp.2.1647588020569; Fri, 18 Mar 2022 00:20:20 -0700 (PDT) Received: from localhost ([240e:3a1:2e5:800:f995:6136:f760:a3d0]) by smtp.gmail.com with ESMTPSA id j11-20020a056a00234b00b004f7463022absm8617617pfj.208.2022.03.18.00.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 00:20:19 -0700 (PDT) Date: Fri, 18 Mar 2022 15:18:24 +0800 From: Coiby Xu To: Baoquan He Cc: Coiby Xu , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Young , Will Deacon , "Eric W . Biederman" , open list Subject: Re: [RESEND PATCH v3 1/3] kexec: clean up arch_kexec_kernel_verify_sig Message-ID: <20220318071824.yq3idr5eoogvtslb@Rk> References: <20220304020341.85583-1-coiby.xu@gmail.com> <20220304020341.85583-2-coiby.xu@gmail.com> <20220318024803.pkkwgknwur2y75mt@Rk> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=coxu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_002026_323767_D1BEC4AD X-CRM114-Status: GOOD ( 31.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 18, 2022 at 11:27:09AM +0800, Baoquan He wrote: >On 03/18/22 at 10:48am, Coiby Xu wrote: >> On Thu, Mar 17, 2022 at 08:45:35PM +0800, Baoquan He wrote: >> > On 03/04/22 at 10:03am, Coiby Xu wrote: >> > > From: Coiby Xu >> > > >> > > commit 9ec4ecef0af7790551109283ca039a7c52de343c ("kexec_file,x86, >> > > powerpc: factor out kexec_file_ops functions" allows implementing >> > > the arch-specific implementation of kernel image verification >> > > in kexec_file_ops->verify_sig. Currently, there is no arch-specific >> > > implementation of arch_kexec_kernel_verify_sig. So clean it up. >> > >> > This is a nice cleanup, while the log may need to be improved. You >> > should run ./scripts/checkpatch.pl on your patch before sending out. >> > When we refer to a commit in log, please refer to >> > Documentation/process/submitting-patches.rst. >> >> Thanks for the reminder! I've used git pre-commit hook to run >> scripts/checkpatch.pl automatically but obviously this hook doesn't >> apply to "git rebase --continue" and currently this no git hook that >> for this situation. I'll use the following trick [1] to avoid this >> mistake in the future, >> $ git rebase -i HEAD~3 --reschedule-failed-exec --exec "git show | perl ./scripts/checkpatch.pl" > >Sorry, Coiby. It could be late yesterday so I was dizzy when writing >down the comment, I didn't make my concern clear. What I meant is >the referenced commit in log should be taken in a standard format. >Abstracted one paragraph of Documentation/process/submitting-patches.rst >here. We usually take the first 12 characters of the commit SHA-1 ID >in log, but not the whole of them. > >===== >If you want to refer to a specific commit, don't just refer to the >SHA-1 ID of the commit. Please also include the oneline summary of >the commit, to make it easier for reviewers to know what it is about. >Example:: > > Commit e21d2170f36602ae2708 ("video: remove unnecessary > platform_set_drvdata()") removed the unnecessary > platform_set_drvdata(), but left the variable "dev" unused, > delete it. >===== > >And the right parenthesis enclousing the commit subject is missing. Thanks for the detailed explanation! Your message has got across to me successfully:) I have ran scripts/checkpatch.pl manually after seeing your first reply and checkpatch.pl reported the exact same issues as explained by you today. My approach of avoiding making mistakes on format is to run checkpatch.pl automatically in the git precommit hook so I don't need to remember the details about format. I had expected the git precommit hook could help me find the issues pointed out by you but obviously it failed. So I tried to find out what's wrong. I think the format issues were introduced when doing rebase to improve the old version and the precommit hook wasn't triggered in this case. Another thing I still missed is I used "git diff --cached | scripts/checkpatch.pl" in the pre-commit hook which obviously won't check the format issue in the commit message (it only check the format issue in the code). With the two problems resolved, I shall not make format mistakes in the future:) Btw, checkpatch.pl seems to requires referring to a specific commit on the same line, ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops functions")' #6: commit 9ec4ecef0af7 ("kexec_file,x86, powerpc: factor out kexec_file_ops functions") allows implementing the arch-specific implementation of kernel total: 1 errors, 0 warnings, 61 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] kexec: clean up arch_kexec_kernel_verify_sig" has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Is this a false positive? > >> >> [1] https://stackoverflow.com/a/70568833/1203522 >> >> >> -- >> Best regards, >> Coiby >> > -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel