From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A281C433EF for ; Fri, 18 Mar 2022 09:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N1HoUHVELGbwIcS9qhziyaUCL5OAg9LXPEKGOQtQSgE=; b=MtCqdjMkOyz70BzaS+54LuORYh HqRsgRzV9bKamhSgos3KUK/SFMtVFlVSqU9MAawM17QmAZTLo/hOZugYq90i//fVXnjVmsbEPHOmF z9oraORrN3z0oQF4QWfKEoOdrPzC9jZMUnipBxAzolHCPEofTSJBYOTHa6UDJFU4UmbCW39ERaV0Z Tw7HpXHZ043gM5PjfMPh1Pawyq1wyHWTZebPA9AWiEjXEPkGearV4SbabZKsOUo3Y5E0BS1lHv9wT oFOE1+zNG3K20xEEgcJDBME1ZGGRTIbfeBrFuK3mWtKmdY2QwzgJgjkSRF6LgUC8sKSOqHfGXfGdo MeQDKdHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV9Ag-0011L4-Ee; Fri, 18 Mar 2022 09:45:22 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV9Ad-0011K8-RK for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 09:45:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647596718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2Sklw5vFJoBHTi2JNfxIgqGkvTxQMGfgRs43b1Vh+LU=; b=NLobZVlAggz1NYql8WO81xErQ9Od12Qa4+fIHNscCOcrR7Ffze84KSYUzJvGGAomNCSOq4 MThMd0k/IQ0MXzqbfOcLARxW0t1cRd9TUXuXNFhLGRfjKdMndj1fN9bCb32Uds3LPim1oT o3eCIdxfswkTMX3po9IjBqGfVe2d1XI= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-404-McJhi-ymPGe6Gcfj0H0nIQ-1; Fri, 18 Mar 2022 05:45:17 -0400 X-MC-Unique: McJhi-ymPGe6Gcfj0H0nIQ-1 Received: by mail-pl1-f200.google.com with SMTP id z10-20020a170902708a00b0014fc3888923so3882393plk.22 for ; Fri, 18 Mar 2022 02:45:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2Sklw5vFJoBHTi2JNfxIgqGkvTxQMGfgRs43b1Vh+LU=; b=kWt+pSTm9wGwNXbPqGViSFMvZV7XtXLU+b/p77EnfhIXoYt0HmM2A6gPVGIasiDokq 04j5lyVJQlTLh/GsXRhU6555SRYU81gKbD1mXVG+lQ8BH05ENtxXtncgxh38+HAHcVKo fr0H8V918LVqYyU073VP/aTbEuO9MvEh31BqU8A6SHt2Y56dk5wyYNPl9pubGJLNCGWt cbzuGBy1pNGMp/R51K686vyDtzSOtCEO6wKxXNGuMrX0v6s/Vi9tltmS5rLghbEH0+MM KnVzeHsz06ouJr59NZCrX6/EF/FFzZK81wVCfy6ERrSz5i+vrwZk2eJ7+HZJR88rryc+ Fq0A== X-Gm-Message-State: AOAM530V6IgUu7DopZCFESE9H5T/YquAADW2dJaUsf3Ye2Bcrb7hFdF8 6CXrjrpQQ6Z9uK+qYjUZXol6NG2oNB9I0jVZ+nNx0gQcmz1bXDOYfP+vrmE48xMHFIwiozStVHL 0uQPQA9DI7P7T/mKdcWtAMhKI95583zkQZa0= X-Received: by 2002:a17:90a:d3d3:b0:1bf:2e8d:3175 with SMTP id d19-20020a17090ad3d300b001bf2e8d3175mr10468690pjw.2.1647596716486; Fri, 18 Mar 2022 02:45:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztty7oXoA2AqzOazKbPPcVcNrIQJpdf62DaK3QMw38C5mcbYXwuTbaZ624qRUjJXw2KPOnKg== X-Received: by 2002:a17:90a:d3d3:b0:1bf:2e8d:3175 with SMTP id d19-20020a17090ad3d300b001bf2e8d3175mr10468669pjw.2.1647596716286; Fri, 18 Mar 2022 02:45:16 -0700 (PDT) Received: from localhost ([240e:3a1:2e5:800:f995:6136:f760:a3d0]) by smtp.gmail.com with ESMTPSA id c7-20020aa78e07000000b004f6e4d8ccc8sm8813364pfr.163.2022.03.18.02.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 02:45:15 -0700 (PDT) Date: Fri, 18 Mar 2022 17:43:20 +0800 From: Coiby Xu To: Baoquan He Cc: Coiby Xu , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Young , Will Deacon , "Eric W . Biederman" , open list Subject: Re: [RESEND PATCH v3 1/3] kexec: clean up arch_kexec_kernel_verify_sig Message-ID: <20220318094320.aoia7yahtmy2hksp@Rk> References: <20220304020341.85583-1-coiby.xu@gmail.com> <20220304020341.85583-2-coiby.xu@gmail.com> <20220318024803.pkkwgknwur2y75mt@Rk> <20220318071824.yq3idr5eoogvtslb@Rk> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=coxu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_024519_973525_3786B2A2 X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 18, 2022 at 04:54:01PM +0800, Baoquan He wrote: [...] >> Btw, checkpatch.pl seems to requires referring to a specific commit on >> the same line, >> >> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops functions")' >> #6: commit 9ec4ecef0af7 ("kexec_file,x86, powerpc: factor out >> kexec_file_ops >> functions") allows implementing the arch-specific implementation of kernel >> total: 1 errors, 0 warnings, 61 lines checked >> NOTE: For some of the reported defects, checkpatch may be able to >> mechanically convert to the typical style using --fix or --fix-inplace. >> "[PATCH] kexec: clean up arch_kexec_kernel_verify_sig" has style problems, please review. >> NOTE: If any of the errors are false positives, please report >> them to the maintainer, see CHECKPATCH in MAINTAINERS. >> >> Is this a false positive? > >No, it's not. Youp probably copied the commit subject and modified it. >Please copy below two lines into your patch to replace and try again. > >commit 9ec4ecef0af7 ("kexec_file,x86,powerpc: factor out kexec_file_ops >functions") Yes, you are right. I unintentionally changed the subject. I've sent v4 to fix this commit reference issue and other checkpatch.pl warnings. Thanks! -- Best regards, Coiby _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel