* [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table
@ 2022-03-08 6:57 Peng Fan (OSS)
2022-03-11 18:20 ` Bjorn Andersson
2022-03-24 15:11 ` Mathieu Poirier
0 siblings, 2 replies; 5+ messages in thread
From: Peng Fan (OSS) @ 2022-03-08 6:57 UTC (permalink / raw)
To: bjorn.andersson, mathieu.poirier, shawnguo, s.hauer
Cc: kernel, festevam, linux-imx, linux-remoteproc, linux-arm-kernel,
linux-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Resource table will not be used for memory allocation, no need to create
rproc mem entry.
Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V2:
Add Fixes tag
Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
Address typo
drivers/remoteproc/imx_rproc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 7a096f1891e6..f2bfc9077c19 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
if (!strcmp(it.node->name, "vdev0buffer"))
continue;
+ if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
+ continue;
+
rmem = of_reserved_mem_lookup(it.node);
if (!rmem) {
dev_err(priv->dev, "unable to acquire memory-region\n");
--
2.30.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table
2022-03-08 6:57 [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table Peng Fan (OSS)
@ 2022-03-11 18:20 ` Bjorn Andersson
2022-03-24 15:11 ` Mathieu Poirier
1 sibling, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2022-03-11 18:20 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: mathieu.poirier, shawnguo, s.hauer, kernel, festevam, linux-imx,
linux-remoteproc, linux-arm-kernel, linux-kernel, Peng Fan
On Tue 08 Mar 00:57 CST 2022, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Resource table will not be used for memory allocation, no need to create
> rproc mem entry.
Can you please expand this to cover why the "resource table will not be
used for memory allocation"?
Regards,
Bjorn
>
> Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V2:
> Add Fixes tag
> Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
> Address typo
>
> drivers/remoteproc/imx_rproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..f2bfc9077c19 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> if (!strcmp(it.node->name, "vdev0buffer"))
> continue;
>
> + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> + continue;
> +
> rmem = of_reserved_mem_lookup(it.node);
> if (!rmem) {
> dev_err(priv->dev, "unable to acquire memory-region\n");
> --
> 2.30.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table
2022-03-08 6:57 [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table Peng Fan (OSS)
2022-03-11 18:20 ` Bjorn Andersson
@ 2022-03-24 15:11 ` Mathieu Poirier
2022-03-25 2:02 ` Peng Fan
1 sibling, 1 reply; 5+ messages in thread
From: Mathieu Poirier @ 2022-03-24 15:11 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: bjorn.andersson, shawnguo, s.hauer, kernel, festevam, linux-imx,
linux-remoteproc, linux-arm-kernel, linux-kernel, Peng Fan
On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Resource table will not be used for memory allocation, no need to create
> rproc mem entry.
>
> Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V2:
> Add Fixes tag
> Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-7-peng.fan@oss.nxp.com/
> Address typo
>
> drivers/remoteproc/imx_rproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..f2bfc9077c19 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> if (!strcmp(it.node->name, "vdev0buffer"))
> continue;
>
> + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> + continue;
> +
> rmem = of_reserved_mem_lookup(it.node);
> if (!rmem) {
> dev_err(priv->dev, "unable to acquire memory-region\n");
> --
> 2.30.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table
2022-03-24 15:11 ` Mathieu Poirier
@ 2022-03-25 2:02 ` Peng Fan
2022-03-25 16:02 ` Mathieu Poirier
0 siblings, 1 reply; 5+ messages in thread
From: Peng Fan @ 2022-03-25 2:02 UTC (permalink / raw)
To: Mathieu Poirier, Peng Fan (OSS)
Cc: bjorn.andersson@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
dl-linux-imx, linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi Mathieu,
> Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for
> resource table
>
> On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Resource table will not be used for memory allocation, no need to
> > create rproc mem entry.
> >
> > Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse
> > fw hook")
>
>
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> ootlin.com%2Flinux%2Fv5.17%2Fsource%2FDocumentation%2Fprocess%2Fsu
> bmitting-patches.rst&data=04%7C01%7Cpeng.fan%40nxp.com%7Cae62
> e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8eyJW
> IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000&sdata=Xod3YxSRW8h2WXdnpu1WX4DzRpCTnYE9gVlt9HXMlnU%3
> D&reserved=0
Sorry, I could not get your point of which part conflicts with the patch rules.
Please clarify and I'll improve.
Thanks,
Peng.
>
>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V2:
> > Add Fixes tag
> > Separate the patch from
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> >
> hwork.kernel.org%2Fproject%2Flinux-remoteproc%2Fpatch%2F20220111033
> 333
> > .403448-7-peng.fan%40oss.nxp.com%2F&data=04%7C01%7Cpeng.fan
> %40nxp.
> >
> com%7Cae62e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd
> 99c5c301
> >
> 635%7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC4wL
> >
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> p;sdata
> >
> =CYL9grwXHpUud4qpzFAEijOWv%2BehvefwyZ4aU02wJnw%3D&reserv
> ed=0
> > Address typo
> >
> > drivers/remoteproc/imx_rproc.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> > if (!strcmp(it.node->name, "vdev0buffer"))
> > continue;
> >
> > + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > + continue;
> > +
> > rmem = of_reserved_mem_lookup(it.node);
> > if (!rmem) {
> > dev_err(priv->dev, "unable to acquire memory-region\n");
> > --
> > 2.30.0
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table
2022-03-25 2:02 ` Peng Fan
@ 2022-03-25 16:02 ` Mathieu Poirier
0 siblings, 0 replies; 5+ messages in thread
From: Mathieu Poirier @ 2022-03-25 16:02 UTC (permalink / raw)
To: Peng Fan
Cc: Peng Fan (OSS), bjorn.andersson@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
dl-linux-imx, linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Thu, 24 Mar 2022 at 20:02, Peng Fan <peng.fan@nxp.com> wrote:
>
> Hi Mathieu,
>
> > Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for
> > resource table
> >
> > On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Resource table will not be used for memory allocation, no need to
> > > create rproc mem entry.
> > >
> > > Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse
> > > fw hook")
> >
> >
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> > ootlin.com%2Flinux%2Fv5.17%2Fsource%2FDocumentation%2Fprocess%2Fsu
> > bmitting-patches.rst&data=04%7C01%7Cpeng.fan%40nxp.com%7Cae62
> > e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd99c5c301635
> > %7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8eyJW
> > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> > 3000&sdata=Xod3YxSRW8h2WXdnpu1WX4DzRpCTnYE9gVlt9HXMlnU%3
> > D&reserved=0
>
> Sorry, I could not get your point of which part conflicts with the patch rules.
> Please clarify and I'll improve.
The commitID in the "Fixes" tag should be 12 characters rather than 13
as you have above.
>
> Thanks,
> Peng.
>
>
> >
> >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > V2:
> > > Add Fixes tag
> > > Separate the patch from
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > >
> > hwork.kernel.org%2Fproject%2Flinux-remoteproc%2Fpatch%2F20220111033
> > 333
> > > .403448-7-peng.fan%40oss.nxp.com%2F&data=04%7C01%7Cpeng.fan
> > %40nxp.
> > >
> > com%7Cae62e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd
> > 99c5c301
> > >
> > 635%7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8e
> > yJWIjoiMC4wL
> > >
> > jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> > p;sdata
> > >
> > =CYL9grwXHpUud4qpzFAEijOWv%2BehvefwyZ4aU02wJnw%3D&reserv
> > ed=0
> > > Address typo
> > >
> > > drivers/remoteproc/imx_rproc.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/remoteproc/imx_rproc.c
> > > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > > 100644
> > > --- a/drivers/remoteproc/imx_rproc.c
> > > +++ b/drivers/remoteproc/imx_rproc.c
> > > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> > > if (!strcmp(it.node->name, "vdev0buffer"))
> > > continue;
> > >
> > > + if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > > + continue;
> > > +
> > > rmem = of_reserved_mem_lookup(it.node);
> > > if (!rmem) {
> > > dev_err(priv->dev, "unable to acquire memory-region\n");
> > > --
> > > 2.30.0
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-03-25 16:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-08 6:57 [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table Peng Fan (OSS)
2022-03-11 18:20 ` Bjorn Andersson
2022-03-24 15:11 ` Mathieu Poirier
2022-03-25 2:02 ` Peng Fan
2022-03-25 16:02 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).