From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17B1FC433EF for ; Fri, 25 Mar 2022 17:44:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ovftnC4TlRgdqfsvhd7oofZRjs18WGHzAhW2YbqWdUg=; b=chloHkjF5eUd5Z 9vZqv8ujTmmHQ+ktLXz5xIEjnMmZxLmmSBDAMWTRhAIH5c9LwDcPZ7Cr6NLopy28w429EhBG+nAnk kPwyNLtjLTGI8xhcG2hWbnf2UKCf2kUAApzO+KL8UTG/pzbmwMUvoIHaXOOMlv10XFZ0xN7DLlSH8 eo4OdVgYIKtAF9REOUI2t2WZ624myLbxSliPIt3qxIXC0Ce1qNJakN9CzCIQfL43qXDItciBsfBp7 EWIuwAbve1OHq4m8RA+PZbBeJLTHKPj0j9F6rq/wH2Ux/DVGJp5lGxrgjRkrFICtKw/Pnj6ljpHXU e1DARgmlrgkIYewI0Uiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXnxE-002tMr-AN; Fri, 25 Mar 2022 17:42:28 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXntS-002rtQ-Ud for linux-arm-kernel@lists.infradead.org; Fri, 25 Mar 2022 17:38:36 +0000 Received: by mail-pl1-x629.google.com with SMTP id w4so8789230ply.13 for ; Fri, 25 Mar 2022 10:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ayOYjTZU6HmufvMH+uKYpu/1dCIaQ5A33lYHz9+DMm4=; b=X+FNOez4egUGi+RaEDC5o5ifCxnPeAfq9cKoQQXRcF/X2s6qCcDabfodEZqtqP/0od lcKDpg5zdyKA0VfQxajowo2N9HrIRQBF1bBCnHD2DkeibXkuGPEgOt/UZGMsOcCk0gYL Prm8lhECgBMpAltiHAWJIMm2YO91CQDkFYQssH6ntOXpAWz4JChc3Gb4CrUDQmh5uvsS P3yCPBbSUoWo5SXyWtNxbVV/B8OxseinYxnd6EcJk/8egWfeCX2KLAKfdZXFur5oZWIf ol1ErG6sBtdoxsbv6c1zkZOtjZNrrYbybeS6kSTlU0snIT+/4aXoexhXhIMNsG1rQt7p SV+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ayOYjTZU6HmufvMH+uKYpu/1dCIaQ5A33lYHz9+DMm4=; b=qmXsmL9ztAYkZkoxv/DchiOqoPSURtKKTMdgIWFscf4nu/FASo+OPyoQoM0SRhyB7c oGdhFh7ib+Mq/vxW4lZE4SgiR0VSuTtg8mj89uX2EB7C58LYgIvP2MYkYRWx03XRsJeB MgaBqK2mnfaU2JmnQdI6BQ6nZIcz8C0CBTbJeQHSrcw+HSKbRkmtNvK5ghaAroVBWa0b qSTC3+3c1vjpearjDB6QxdhTw7aeQKMrCAoKJucJN4C93bYSI+3W2w/YVYeX2mgn8ut4 U/rhRCkwCTJefxXZa2ICAcWd9TYvETRmaRX1WFlGcmwwCxNp841nr3VuTT5gZu98HNSM VCjg== X-Gm-Message-State: AOAM532fHm5Qk5Q/HLlSyEL2eYb16fr8J/wQiRyuHY1Fb6IA1jvv/PSN bfVMjtRm6WkYRHWTREm+xjk= X-Google-Smtp-Source: ABdhPJw3p6wgf3puKfvwDvOdglHa/WYaO+uhShtAN0fwz7BRG4eEy82IN781iCaO/bIGRTwjoMTc+w== X-Received: by 2002:a17:90b:33cd:b0:1c6:5db5:5ff9 with SMTP id lk13-20020a17090b33cd00b001c65db55ff9mr14110308pjb.197.1648229912288; Fri, 25 Mar 2022 10:38:32 -0700 (PDT) Received: from 9a2d8922b8f1 ([122.161.51.18]) by smtp.gmail.com with ESMTPSA id pi2-20020a17090b1e4200b001c7b15928e0sm6737763pjb.23.2022.03.25.10.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 10:38:32 -0700 (PDT) Date: Fri, 25 Mar 2022 23:08:26 +0530 From: Kuldeep Singh To: Arnd Bergmann Cc: Viresh Kumar , Rob Herring , Viresh Kumar , Shiraz Hashim , SoC Team , Linux ARM , DTML , Linux Kernel Mailing List Subject: Re: [PATCH v2] ARM: dts: spear13xx: Update SPI dma properties Message-ID: <20220325173826.GA70042@9a2d8922b8f1> References: <20220323175920.93155-1-singh.kuldeep87k@gmail.com> <20220324023904.h2qfxzxlznggbsyr@vireshk-i7> <20220324062547.GA15504@9a2d8922b8f1> <20220325015849.sazvlevnvdqj5z42@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220325_103835_039525_62B309BA X-CRM114-Status: GOOD ( 24.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 25, 2022 at 10:11:41AM +0100, Arnd Bergmann wrote: > On Fri, Mar 25, 2022 at 2:58 AM Viresh Kumar wrote: > > On 24-03-22, 11:55, Kuldeep Singh wrote: > > > Fixed order of values is important in case of properties like > > > compatibles etc. In case of dma-names, yes order shouldn't matter here. > > > > > > This patch is more of appeasing dtbs_check warning rather than fixing > > > something. > > > > Exactly my point. We have seen similar type of issues with other tools, like > > coccinelle, earlier and such patches were rejected as the kernel was just fine > > and tooling needs to be fixed. > > > > > It's safe to go with this patch. > > > I am not sure if there's a provision to exclude dma-names from fix > > > ordering checks. Rob can help here in providing better insights. > > I think it's a question of the scale of the warnings: my understanding is that > there are only a handful of dts files that trigger the warning at all, and it > would be rather hard to change the tooling around this. Since the proposed > dts change is clearly harmless, I don't mind applying it. > > Kuldeep, you have probably looked at all dts files in the kernel, can you > say how many of them are affected by the dma property reordering? I have checked spi-pl022.yaml as of now and this was the only one which was affected with dma ordering. For all dts files, I can definitely give a try and will come up with some numbers. Please note, there are still bindings left to be converted to yaml format, so won't be able to catch those cases. - Kuldeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel