From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D013FC433F5 for ; Sat, 26 Mar 2022 13:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X2bQY/sVl1jysKFnX7n/dwLDKXVACBFbzCLk3sRAv40=; b=Jx126sMvQyuk4l vkOYIaaet/GqWAQ9OghIwzr7IO30MSm+rp2oipVTxgTeUAT0RaMT0Lp9WL8Fv/mvyaM+LRlDL/ioG 9414Bw6d9NRztSkwV+iTgMQkGj4ykckUTVqsC9VcFBP7x1yTRcd0ltYxfNCTb3GKadx8pcrFft5h5 G127nGQFnw1SyqmVgiSwus1yS/gqG1VzHpXjVxujOJWnYdwZXKCaYgGLfCIOO0dOOI2hbQQ92GP7P x/CN/laXZKw936/r168SNNNNBTHk2XKPtEp1Q4uTAlRIXUnNPD7MmbNM/jGlAaN7xNyAphCtWTX8B MV6QLghwCiHLxMe4bQ7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY6uj-004L8A-DY; Sat, 26 Mar 2022 13:57:09 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY6ue-004L6t-CY for linux-arm-kernel@lists.infradead.org; Sat, 26 Mar 2022 13:57:06 +0000 Received: by mail-ej1-x629.google.com with SMTP id bi12so20390129ejb.3 for ; Sat, 26 Mar 2022 06:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lhQ/9h3aosfO3hPFwJIQJoDRXgFc3ALySqBJ9aeA3do=; b=jyR0QQpIv1pg8DLBKyUy57SsVcfgSSBWKVzhDzjtO1U+ttf/UmmhpEGrcPwSWnPWUB K3CrdQpHrvLgAiaZqPst5VfazuoT4mL+Y3RjAsK4a74bzgj/LuBVvywd5EHRp67tQS7/ SjdVHJHRnie6Blf/LzHv7mYE1iz6lmsS6mdhCdt8Ez6ewb2KoU18OU7CFWTdJtDQNKDu j0QHKVR2Dc02WGDhzmdJzatS8LCIQMPHfnNdkkY+Mh/KtkYpyfBRiiJPXDHnYI4XxesX r7lPJ+sitmDjD9+0L4hqyj52EAjO03ozG2/huWdzaV2aCPidPDp/QEGzhTdXPvT/Akay 5Zxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lhQ/9h3aosfO3hPFwJIQJoDRXgFc3ALySqBJ9aeA3do=; b=oFSWJ4HqS2D3lYRLG5Dco/6h6Uykt4na84BZEVaWRKwIrjCCJ59CW64xtp8aumypdt iFto88qVBzYMfTSEhiMjzdw15E5I2iW43GewJTsJeLS03JXD+NH+pZBZYh3//NaeKDLp 9Xaf5O/dDnu2hmPPflCdNrCRqE7YA7JGHLLjeYEevavgIyBZfBT20Tsns06QIfJrt6Xj LZbKLhNKcM7lh7M0CO7F5F4nerMmKKiAEkGdjDpoVNP338vxsMlImOfg8PlhWXI7FeTF viJapDKsBVGJUcIiwZNVRqQHqLX3dBT/bS34hMVHNiZ9Z3AMMfJNiV+onB1zsLgDS1D5 WwpQ== X-Gm-Message-State: AOAM533c0Jvi+kd2BD2LdWWB/aYKaPJXGNRcU/vzFFwsQD+OEar662CX JAicNqspNeKgvgtKsHc1n6QM1A== X-Google-Smtp-Source: ABdhPJy565DNLBwcL4ofm0QqI01C5J8RZSuRoOAEPeLrdhwPpMVxtyG9K+e/ftRtB2/L3v1kX0iCRg== X-Received: by 2002:a17:907:3f86:b0:6db:b745:f761 with SMTP id hr6-20020a1709073f8600b006dbb745f761mr16698723ejc.610.1648303021647; Sat, 26 Mar 2022 06:57:01 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([104.245.96.34]) by smtp.gmail.com with ESMTPSA id bs7-20020a056402304700b004197e5d2350sm4092657edb.54.2022.03.26.06.56.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 06:57:01 -0700 (PDT) Date: Sat, 26 Mar 2022 21:56:53 +0800 From: Leo Yan To: Arnaldo Carvalho de Melo Cc: Ali Saidi , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, german.gomez@arm.com, benh@kernel.crashing.org, Nick.Forrington@arm.com, alexander.shishkin@linux.intel.com, andrew.kilroy@arm.com, james.clark@arm.com, john.garry@huawei.com, jolsa@kernel.org, kjain@linux.ibm.com, lihuafei1@huawei.com, mark.rutland@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, will@kernel.org Subject: Re: [PATCH v4 2/4] perf arm-spe: Use SPE data source for neoverse cores Message-ID: <20220326135653.GE20556@leoy-ThinkPad-X240s> References: <20220324183323.31414-1-alisaidi@amazon.com> <20220324183323.31414-3-alisaidi@amazon.com> <20220326134754.GD20556@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220326_065704_438596_1A8B479F X-CRM114-Status: GOOD ( 19.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 26, 2022 at 10:52:01AM -0300, Arnaldo Carvalho de Melo wrote: > Em Sat, Mar 26, 2022 at 09:47:54PM +0800, Leo Yan escreveu: > > Hi Ali, German, > > > > On Thu, Mar 24, 2022 at 06:33:21PM +0000, Ali Saidi wrote: > > > > [...] > > > > > +static void arm_spe__synth_data_source_neoverse(const struct arm_spe_record *record, > > > + union perf_mem_data_src *data_src) > > > { > > > - union perf_mem_data_src data_src = { 0 }; > > > + /* > > > + * Even though four levels of cache hierarchy are possible, no known > > > + * production Neoverse systems currently include more than three levels > > > + * so for the time being we assume three exist. If a production system > > > + * is built with four the this function would have to be changed to > > > + * detect the number of levels for reporting. > > > + */ > > > > > > - if (record->op == ARM_SPE_LD) > > > - data_src.mem_op = PERF_MEM_OP_LOAD; > > > - else > > > - data_src.mem_op = PERF_MEM_OP_STORE; > > > > Firstly, apologize that I didn't give clear idea when Ali sent patch sets > > v2 and v3. > > Ok, removing this as well. > > Thanks for reviewing. Thanks a lot, Arnaldo. Yeah, it's good to give a bit more time to dismiss the concerns in this patch. Sorry again for the inconvenience. Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel