From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C33AC433F5 for ; Sat, 26 Mar 2022 15:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=0YlvyzKFDHZm9ncOtFhTyJGWXeRVU8GrvLgLSsGjMGE=; b=i17612gdEdmQ6s e6dPS6XOah5yibnkNiRvjUgWfOloCFSRHdxLyX5/1Mpsk35M6xwnJVy1vaxwV8gGTO8ibMUPJq0lE UdW4AWB3cGwYkeBIIcd/cIk3xOEGB4+SxSTs37280jw6LTbYXnlRpPG5IjVBdjeti7CNlnOUg9eIw wEqob5fcqL0N86ImsAiduDHdytBe6UZx4lf2HaiNVFQl7+oVKbyJAC6VKKKCgXfliuzSL797geG/7 Kw2KkrqxflnZ2B9O0bOD8z3/B2UEwCGC/RL1Gx+Dy+t8ZefjBtp4L0klTK8Pn+VJM2/HXTwSR+gPu xj+imE5HaWhV+ggg7ztQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY88P-004UFp-Fe; Sat, 26 Mar 2022 15:15:21 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY88M-004UFL-BS for linux-arm-kernel@lists.infradead.org; Sat, 26 Mar 2022 15:15:19 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-dacc470e03so10911631fac.5 for ; Sat, 26 Mar 2022 08:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G9fuVH7zcW0Y8oWLY7Gg4W7/qrDj3pdQpw5laKOjja0=; b=BTtzs3+lYZuvCrGTa+bZz5yf1bKnzqAM5DUZfVMiezLN02EU79Z9xTiIBr32DuAMKK GhIaZPYxCRm6pwezC6fNWS3Ia1Y4a+nn1rGN7EHvc3vJBNyqpxeUZzyC234De+NpAHGA qTYPvKr4eN8r/jdwDXEsIybXghTO2yQ16xngWx0sHMD/YPikTqOaqMJESzEX0h1gZWNu TwHWQRxA/6g59PqLPy/NLkvIodKzQFbpY4TByFXieySOBhah8Xi9ojr2qXapkyzv+SRw 5Dd6udTP/d77V0DnGccJAZDBxzNSD+jCmbYY8g6RS5LrYMkwwUX2ANWX2ra9VKDT1Aqf ZiLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G9fuVH7zcW0Y8oWLY7Gg4W7/qrDj3pdQpw5laKOjja0=; b=qmrVzRpwH1vGquuhDJTYZg5ChtVZYAlX1pv0kRSVK78YsTT8S+lSvKgNhkikl4+o4m ZF3rJ8hja/mRQER47YYYAsvRnwwwiUSlHjIe+BJVSlfwq6+T6vgXPSKXtzTr+RYEBnZT bLLVm6tgTbiBiR7029iqXsSaHej8wGcYInE4iPBsoIe2VvYioTTObiMeHSxQ9IJlBDxw 9rWALzna0IuEtf1lh3J/Aimkp4CWS3m2lnnpREiheLZoXRJpnz4ovyRcynhXT8APc061 Fk6nBme28orVRy7Beu8ZlA+ho+xQtvwOEwGkRBVIscHBZyoGkP2QgmnHbsJ1KIkyMzIt Bepg== X-Gm-Message-State: AOAM5328dsxfKQ5s/WFrQYV0FZag5IpYXkTyrZ0H7cBimP3ZQFHL6n9y CPgG0C6CCTgZRaWKw9eQeuAI45t3Zfw= X-Google-Smtp-Source: ABdhPJxhYS5z7ObW1OSN7NxQwQv9aI0ZnjthZO9Y/nOJ+SKUU98RBbFaGkirrUbi1kB6YcHDu+bnwQ== X-Received: by 2002:a05:6870:d182:b0:dd:bf35:48 with SMTP id a2-20020a056870d18200b000ddbf350048mr7190526oac.255.1648307716768; Sat, 26 Mar 2022 08:15:16 -0700 (PDT) Received: from localhost.localdomain ([2804:431:d77f:649f:4653:af38:d076:c840]) by smtp.gmail.com with ESMTPSA id i4-20020a4addc4000000b00324bd261e5fsm3768000oov.11.2022.03.26.08.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 08:15:16 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: marcel.ziswiler@toradex.com, otavio@ossystems.com.br, linux-arm-kernel@lists.infradead.org, Fabio Estevam Subject: [PATCH] ARM: dts: imx6qdl-apalis: Fix sgtl5000 detection issue Date: Sat, 26 Mar 2022 12:14:55 -0300 Message-Id: <20220326151455.1171719-1-festevam@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220326_081518_431251_C66872F5 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On a custom carrier board with a i.MX6Q Apalis SoM, the sgtl5000 codec on the SoM is often not detected and the following error message is seen when the sgtl5000 driver tries to read the ID register: sgtl5000 1-000a: Error reading chip id -6 The reason for the error is that the MCLK clock is not provided early enough. Fix the problem by describing the MCLK pinctrl inside the codec node instead of placing it inside the audmux pinctrl group. With this change applied the sgtl5000 is always detected on every boot. Fixes: 693e3ffaae5a ("ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM") Signed-off-by: Fabio Estevam --- arch/arm/boot/dts/imx6qdl-apalis.dtsi | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi b/arch/arm/boot/dts/imx6qdl-apalis.dtsi index ed2739e39085..bd763bae596b 100644 --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi @@ -286,6 +286,8 @@ vgen6_reg: vgen6 { codec: sgtl5000@a { compatible = "fsl,sgtl5000"; reg = <0x0a>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_sgtl5000>; clocks = <&clks IMX6QDL_CLK_CKO>; VDDA-supply = <®_module_3v3_audio>; VDDIO-supply = <®_module_3v3>; @@ -517,8 +519,6 @@ MX6QDL_PAD_DISP0_DAT20__AUD4_TXC 0x130b0 MX6QDL_PAD_DISP0_DAT21__AUD4_TXD 0x130b0 MX6QDL_PAD_DISP0_DAT22__AUD4_TXFS 0x130b0 MX6QDL_PAD_DISP0_DAT23__AUD4_RXD 0x130b0 - /* SGTL5000 sys_mclk */ - MX6QDL_PAD_GPIO_5__CCM_CLKO1 0x130b0 >; }; @@ -811,6 +811,12 @@ MX6QDL_PAD_NANDF_CS1__GPIO6_IO14 0x000b0 >; }; + pinctrl_sgtl5000: sgtl5000grp { + fsl,pins = < + MX6QDL_PAD_GPIO_5__CCM_CLKO1 0x130b0 + >; + }; + pinctrl_spdif: spdifgrp { fsl,pins = < MX6QDL_PAD_GPIO_16__SPDIF_IN 0x1b0b0 -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel