From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24C50C433F5 for ; Sat, 26 Mar 2022 19:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=famVIN1OW+BeB7WPJrpncNbVNag1ukOtvJt4HgCvzK8=; b=qSVSbHRs5YN6LD c190MU4d5fyuSJsaUY3qfXxhRfXSzqpHbyUIyrv85L1VIZoXD23oiXTA9hhL+6uFETE2uQHAWa1Lc uWS2r9TpYz/KZYMFA+wUK1IOViLHTRTuV2r2OgI8fcu3cyNXnax//b+UmIMSfRyDGmS6gK/Xof5n6 MeCgXt0SyXKlJ4UrZ5eV6bpPRu8oHd0NSCY/i+VLDNF02JgqjfASOTYCktwbqkpk0KsrX48swLyFq 8c7XNy5Zc4W7LVzcPn9+0viJhtOBRRojjrJuOZZ06Rxj5wGNFrY7H7uVXOBwSuhQ9KrXIZ81cqJne twtvSkujMYrZB0SEYGEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYBsc-004mMy-PI; Sat, 26 Mar 2022 19:15:18 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYBsZ-004mM2-M2 for linux-arm-kernel@lists.infradead.org; Sat, 26 Mar 2022 19:15:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1648322116; x=1679858116; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1qVgAAwGius5rPbM23I010ii9ouqb5CWP42FZkdIMuk=; b=cDEFBKghE/NQa3mKPQ281hy/Yv2GQu6z99vW8oijzLUFWds84lOlxnba ELK2ZU7eirhBVpeSGI+fhQ6v8BysP0YBbGEFl0M0KG92K9ICgKvemQA4R SXokp1nURh/UBnL7K/zw/IvMliVY+eS3TPWDmkpsdDxaKuBhU3tG3ySoG I=; X-IronPort-AV: E=Sophos;i="5.90,213,1643673600"; d="scan'208";a="189390323" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1d-54a073b7.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP; 26 Mar 2022 19:15:12 +0000 Received: from EX13MTAUWC001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1d-54a073b7.us-east-1.amazon.com (Postfix) with ESMTPS id AA33C9765A; Sat, 26 Mar 2022 19:15:06 +0000 (UTC) Received: from EX13D02UWC004.ant.amazon.com (10.43.162.236) by EX13MTAUWC001.ant.amazon.com (10.43.162.135) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Sat, 26 Mar 2022 19:15:02 +0000 Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D02UWC004.ant.amazon.com (10.43.162.236) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Sat, 26 Mar 2022 19:15:01 +0000 Received: from dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (172.19.181.128) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.32 via Frontend Transport; Sat, 26 Mar 2022 19:15:01 +0000 Received: by dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (Postfix, from userid 5131138) id 1534917E0; Sat, 26 Mar 2022 19:15:00 +0000 (UTC) From: Ali Saidi To: CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 4/4] perf mem: Support HITM for when mem_lvl_num is any Date: Sat, 26 Mar 2022 19:14:54 +0000 Message-ID: <20220326191454.15084-1-alisaidi@amazon.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220326062303.GC20556@leoy-ThinkPad-X240s> References: <20220326062303.GC20556@leoy-ThinkPad-X240s> MIME-Version: 1.0 Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220326_121515_902283_8E7A35A8 X-CRM114-Status: GOOD ( 13.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 26 Mar 2022 22:23:03 +0000, Leo Yan wrote: > On Thu, Mar 24, 2022 at 06:33:23PM +0000, Ali Saidi wrote: > > For loads that hit in a the LLC snoop filter and are fulfilled from a > > higher level cache on arm64 Neoverse cores, it's not usually clear what > > the true level of the cache the data came from (i.e. a transfer from a > > core could come from it's L1 or L2). Instead of making an assumption of > > where the line came from, add support for incrementing HITM if the > > source is CACHE_ANY.A [snip] > > This might break the memory profiling result for x86, see file > arch/x86/events/intel/ds.c: > > 97 void __init intel_pmu_pebs_data_source_skl(bool pmem) > 98 { > 99 u64 pmem_or_l4 = pmem ? LEVEL(PMEM) : LEVEL(L4); > ... > 105 pebs_data_source[0x0d] = OP_LH | LEVEL(ANY_CACHE) | REM | P(SNOOP, HITM); > 106 } > Thanks for catching this Leo, I'll add your fix. Ali _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel