From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA7BEC433F5 for ; Sun, 27 Mar 2022 06:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+tDeZnP9dLvmSNJ3RasBanpcU0klWZDu59PxcSlp0lM=; b=F+qMst5kir0Pdf 2PoqvVTLDt+UKr6m8yOJTEGoUg0AUnQcm0qKj/DswL9dsLLFKy+2Y56qKlbcB6ywIb3TZ8JMy8uHB uSKCFJQ4TvRMSXH2jwS1oysL2q4yv75vk57eRbwRKcOOYl7TkN0SUiwoiLbhUMue2F8UgddU/yUwI fNxmZIoHx1DTxqJmg2sDTFkl6wF55ps8qPSNRoJwdO8/Ie0qINjgoVGCUHOgY3xAq8oId9+YlqHne JEZ8pXBv1eVWEjegqMmZ8uBbw9ioxWNat8pCZ8H9myXYIfdcX0WMp5OrKCxBmJpqPKamRHoyF5leO l+GIWJdtC6Y5Hj+22jOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYM8D-005E0R-II; Sun, 27 Mar 2022 06:12:05 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYM8A-005Dzo-4K for linux-arm-kernel@lists.infradead.org; Sun, 27 Mar 2022 06:12:03 +0000 Received: by mail-pf1-x42c.google.com with SMTP id b13so7981006pfv.0 for ; Sat, 26 Mar 2022 23:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=BE+aA36i8c3R5wojjNo4XL/AkAZANQ6GWopioCR7lsc=; b=Nw2r6AW4z/IkzWG3sJ1kq9jiOS0NTZtYmMnksU9Kj20S7JH68xRaP93m21TynLpjml KkXjALXA6lTXTyMtfeOYFAkHwD3zl7ElW4zV+5FurtFTdxqvR/Cr2i8ZjThSpkmYBtCn TkbMS/VpLspECre+tm/1SkjcGqn4naNiNvmC0am9gRpqV/XXgLri9gcP4dwhUGtNz3/l /B3qmFGlug2UMdKZG8BtakV3miPozC4OH/zWhI+m22oOXb3+OkdtmaVfSXbw7TCpI7z2 4VDe967Jw5PIvKAxMpNBbPk+fcx96Uwlf40SS6bh1I4M+gypREFTpVEIcFsJ6cGtXBJ0 +Vew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BE+aA36i8c3R5wojjNo4XL/AkAZANQ6GWopioCR7lsc=; b=kWPNnUxhnQ4Vh9u52QXdTfInJFC7vf84WBze6yDwaUgHN5s8ptwrKQh2r1wcwO0JzH fCtGcPmibiTFxF/unyTNdITRZem2xu7hY2wIg3cRfc4L1ayjf3vhBL6ggvULizoEkDgp OZrjnYgXIiXGOfTiyWObVdlI5Lrs+Q6Jz+GN9J75PoCKQwSw1oWHVofOcXgdaiGThw9z lSXE2Qo4jz2dhkPB5B5zagMVlRX5T9/WifxHibg7q3Nf06KyQiA3ZtJL2HfMKDZxmhYD z17+pa2hnmEwS8dUt1+FaNFxBQyOoympCvvlAsUGJYNpMZWv77BQenWdCAt2qAy5y9rU /bvQ== X-Gm-Message-State: AOAM531E/JQEFtucbIhiqHKiC8XXTpylEngxJwJ6w3/jUl4ZpnGkoC8b 4If2M0WbzsTeuGFaLr1X8ZE= X-Google-Smtp-Source: ABdhPJyIGF8CYoN8BLP/kuL47FMddIbBlo1ZP1EE47uXttVNcUR/kg8Fcm9ClWqDCfbuDe9b4MljEA== X-Received: by 2002:a05:6a00:130e:b0:4cc:3c7d:4dec with SMTP id j14-20020a056a00130e00b004cc3c7d4decmr17646042pfu.32.1648361520552; Sat, 26 Mar 2022 23:12:00 -0700 (PDT) Received: from localhost.localdomain ([115.220.243.108]) by smtp.googlemail.com with ESMTPSA id j13-20020a056a00130d00b004f1025a4361sm11903794pfu.202.2022.03.26.23.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Mar 2022 23:12:00 -0700 (PDT) From: Xiaomeng Tong To: ludovic.desroches@microchip.com Cc: tudor.ambarus@microchip.com, vkoul@kernel.org, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaomeng Tong , stable@vger.kernel.org Subject: [PATCH] dma: at_xdmac: fix a missing check on list iterator Date: Sun, 27 Mar 2022 14:11:54 +0800 Message-Id: <20220327061154.4867-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220326_231202_199674_B1E2C86B X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The bug is here: __func__, desc, &desc->tx_dma_desc.phys, ret, cookie, residue); The list iterator 'desc' will point to a bogus position containing HEAD if the list is empty or no element is found. To avoid dev_dbg() prints a invalid address, use a new variable 'iter' as the list iterator, while use the origin variable 'desc' as a dedicated pointer to point to the found element. Cc: stable@vger.kernel.org Fixes: 82e2424635f4c ("dmaengine: xdmac: fix print warning on dma_addr_t variable") Signed-off-by: Xiaomeng Tong --- drivers/dma/at_xdmac.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 1476156af74b..def564d1e8fa 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1453,7 +1453,7 @@ at_xdmac_tx_status(struct dma_chan *chan, dma_cookie_t cookie, { struct at_xdmac_chan *atchan = to_at_xdmac_chan(chan); struct at_xdmac *atxdmac = to_at_xdmac(atchan->chan.device); - struct at_xdmac_desc *desc, *_desc; + struct at_xdmac_desc *desc, *_desc, *iter; struct list_head *descs_list; enum dma_status ret; int residue, retry; @@ -1568,11 +1568,13 @@ at_xdmac_tx_status(struct dma_chan *chan, dma_cookie_t cookie, * microblock. */ descs_list = &desc->descs_list; - list_for_each_entry_safe(desc, _desc, descs_list, desc_node) { - dwidth = at_xdmac_get_dwidth(desc->lld.mbr_cfg); - residue -= (desc->lld.mbr_ubc & 0xffffff) << dwidth; - if ((desc->lld.mbr_nda & 0xfffffffc) == cur_nda) + list_for_each_entry_safe(iter, _desc, descs_list, desc_node) { + dwidth = at_xdmac_get_dwidth(iter->lld.mbr_cfg); + residue -= (iter->lld.mbr_ubc & 0xffffff) << dwidth; + if ((iter->lld.mbr_nda & 0xfffffffc) == cur_nda) { + desc = iter; break; + } } residue += cur_ubc << dwidth; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel