From: Jonathan Cameron <jic23@kernel.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org,
Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>,
Michal Simek <monstr@monstr.eu>, Hyun Kwon <hyun.kwon@xilinx.com>,
Shubhrajyoti Datta <shubhraj@xilinx.com>,
Jean-Francois Dagenais <jeff.dagenais@gmail.com>,
Olivier Dugas <dugaso@sonatest.com>,
Manish Narani <mnarani@xilinx.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: fix for_each_child.cocci warnings
Date: Sun, 27 Mar 2022 14:38:20 +0100 [thread overview]
Message-ID: <20220327143820.45fc1d6d@jic23-huawei> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2203260927200.3141@hadrien>
On Sat, 26 Mar 2022 09:28:12 +0100 (CET)
Julia Lawall <julia.lawall@inria.fr> wrote:
> From: kernel test robot <lkp@intel.com>
>
> For_each_child_of_node should have of_node_put() before return.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>
> CC: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
The upstream version (in IIO for now, but I'd imagine will hit Linus'
tree in next few days) of this looks rather different (no dt code an more)
so I suspect this fix is for a now dead branch...
Jonathan
> ---
>
> tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
> head: 1870e0fa79a9d58c6748c34550f3ccea0b515933
> commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/1029] iio: adc: Add Xilinx AMS driver
> :::::: branch date: 35 hours ago
> :::::: commit date: 8 weeks ago
>
> Please take the patch only if it's a positive warning. Thanks!
>
> drivers/iio/adc/xilinx-ams.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev *
> ams_channels + num_channels);
> if (ret < 0) {
> kfree(ams_channels);
> + of_node_put(child_node);
> return ret;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-27 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 8:28 [PATCH] iio: adc: fix for_each_child.cocci warnings Julia Lawall
2022-03-27 13:38 ` Jonathan Cameron [this message]
2022-03-27 19:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220327143820.45fc1d6d@jic23-huawei \
--to=jic23@kernel.org \
--cc=dugaso@sonatest.com \
--cc=hyun.kwon@xilinx.com \
--cc=jeff.dagenais@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnarani@xilinx.com \
--cc=monstr@monstr.eu \
--cc=rajnikant.bhojani@xilinx.com \
--cc=shubhraj@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox