From: Pratyush Yadav <p.yadav@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Julia Lawall <julia.lawall@inria.fr>, <kbuild-all@lists.01.org>,
<linux-arm-kernel@lists.infradead.org>,
Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>,
Michal Simek <monstr@monstr.eu>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Michael Walle <michael@walle.cc>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: fix minmax.cocci warnings
Date: Tue, 29 Mar 2022 17:08:43 +0530 [thread overview]
Message-ID: <20220329113843.nngzktxoa6c5vxcw@ti.com> (raw)
In-Reply-To: <9a20ed24-be9d-bbec-19da-56c0ff68cbda@ti.com>
On 28/03/22 11:28AM, Vignesh Raghavendra wrote:
> Hi.
>
> On 26/03/22 2:00 pm, Julia Lawall wrote:
> > From: kernel test robot <lkp@intel.com>
> >
> > Use min to simplify the code.
> >
> > Generated by: scripts/coccinelle/misc/minmax.cocci
> >
> > Fixes: 2747bc2106aa ("mtd: spi-nor: Add dual parallel and stacked mode support")
> > CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
> > ---
> >
> > tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
> > head: 1870e0fa79a9d58c6748c34550f3ccea0b515933
> > commit: 2747bc2106aa429773d9a932c799aa6229595148 [840/1029] mtd: spi-nor: Add dual parallel and stacked mode support
> > :::::: branch date: 34 hours ago
> > :::::: commit date: 8 weeks ago
> >
> > drivers/mtd/spi-nor/core.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > --- a/drivers/mtd/spi-nor/core.c
> > +++ b/drivers/mtd/spi-nor/core.c
> > @@ -2034,10 +2034,7 @@ static int spi_nor_read(struct mtd_info
> > (offset << nor->shift);
> > }
> > }
> > - if (len < rem_bank_len)
> > - read_len = len;
> > - else
> > - read_len = rem_bank_len;
> > + read_len = min(len, rem_bank_len);
>
> This chunk does not exist in mainline. Seems like xlnx local changes.
Yes. I was very confused for a bit until I realized. It would be nice if
upstream maintainers and mailing lists were not Cced if the patch does
not target the mainline branch.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-29 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 8:30 [PATCH] mtd: spi-nor: fix minmax.cocci warnings Julia Lawall
2022-03-28 5:58 ` Vignesh Raghavendra
2022-03-29 11:38 ` Pratyush Yadav [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-09 11:35 Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329113843.nngzktxoa6c5vxcw@ti.com \
--to=p.yadav@ti.com \
--cc=amit.kumar-mahapatra@xilinx.com \
--cc=julia.lawall@inria.fr \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=monstr@monstr.eu \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox